searching for reviewer(mrbkap)
b8551dbe2a7770ae75252bf229b555c58036cf6d: Bug 1142229 - Part 1: Clean up and refactor test cases for the Nuwa process. r=mrbkap, a=bajaj
Cervantes Yu <cyu@mozilla.com> - Thu, 09 Apr 2015 15:26:49 +0800 - rev 188815
Push 857 by ryanvm@gmail.com at Fri, 10 Apr 2015 15:03:45 +0000
Bug 1142229 - Part 1: Clean up and refactor test cases for the Nuwa process. r=mrbkap, a=bajaj
b348acfcdd19cb1591f6a3a1e840113c34d66268: Bug 942104 - Add an event listener "ondiscoverystatechanged". r=gyeh, r=mrbkap, a=1.4+
Eric Chou <echou@mozilla.com> - Fri, 23 May 2014 14:00:14 +0800 - rev 187687
Push 171 by ryanvm@gmail.com at Fri, 23 May 2014 15:05:43 +0000
Bug 942104 - Add an event listener "ondiscoverystatechanged". r=gyeh, r=mrbkap, a=1.4+
7d980d9af3558249c9d2e3d4f45cadfb421adc8d: Bug 1003766, StopSyncLoopRunnable::Cancel should call base class Cancel. r=mrbkap, a=lsblakk.
Ben Turner <bent.mozilla@gmail.com> - Wed, 30 Apr 2014 13:44:03 -0700 - rev 187608
Push 144 by ryanvm@gmail.com at Tue, 20 May 2014 19:25:15 +0000
Bug 1003766, StopSyncLoopRunnable::Cancel should call base class Cancel. r=mrbkap, a=lsblakk.
82b2949b1ec2e69dcd446c0e69c603fbb0b3b734: Bug 982909 - Consistently use inner window when calling OpenJS. r=jst, r=mrbkap, a=lsblakk
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 13 Mar 2014 12:22:07 -0400 - rev 186888
Push 6 by ryanvm@gmail.com at Mon, 28 Apr 2014 19:04:19 +0000
Bug 982909 - Consistently use inner window when calling OpenJS. r=jst, r=mrbkap, a=lsblakk
21e6b31e84a1dcef8d18468874b39abe6c16ce37: Bug 944309 - Change null check for window from assert to full check/fail in Notification.cpp. r=mrbkap, r=mhenretty, a=lsblakk
Kyle Machulis <kyle@nonpolynomial.com> - Thu, 05 Dec 2013 15:26:04 -0800 - rev 186431
Push 6 by ryanvm@gmail.com at Mon, 28 Apr 2014 19:04:19 +0000
Bug 944309 - Change null check for window from assert to full check/fail in Notification.cpp. r=mrbkap, r=mhenretty, a=lsblakk
0592732e6f9a94ac6232e88e3db2dbee46b3aeed: Bug 897678 - Make worker code stop using propertyops, as a step toward removing propertyops altogether. r=mrbkap, a=akeybl
Jeff Walden <jwalden@mit.edu> - Thu, 08 Aug 2013 15:55:23 -0700 - rev 186078
Push 6 by ryanvm@gmail.com at Mon, 28 Apr 2014 19:04:19 +0000
Bug 897678 - Make worker code stop using propertyops, as a step toward removing propertyops altogether. r=mrbkap, a=akeybl
e522b5f583eebf07c5ed560856250150f208b4f3: Bug 982909 - Consistently use inner window when calling OpenJS. r=jst, r=mrbkap
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 13 Mar 2014 12:22:07 -0400 - rev 184426
Bug 982909 - Consistently use inner window when calling OpenJS. r=jst, r=mrbkap
8e02bf51cb69487012ed06607ada59a82c9799e0: Bug 969273: Implement a toy principal type for the JS shell, for testing. r=mrbkap r=waldo
Jim Blandy <jimb@mozilla.com> - Fri, 07 Mar 2014 11:50:41 -0800 - rev 183599
Bug 969273: Implement a toy principal type for the JS shell, for testing. r=mrbkap r=waldo
49fcef3c246f332c219fdbe9746557be36ee014a: Bug 969273: Move JSPrincipals-related types and functions to their own header. r=mrbkap
Jim Blandy <jimb@mozilla.com> - Fri, 07 Mar 2014 11:50:41 -0800 - rev 183598
Bug 969273: Move JSPrincipals-related types and functions to their own header. r=mrbkap JSSubsumesOp seems to have gotten dragged into Class.h somehow, but it's not a metaobject protocol type at all. It belongs with JSSecurityCallbacks and friends, which together form a chunk that could be neatly abstracted.
b6d23f380d7dba5c5b9c9d57d7ff2e1ee5bc8e98: Bug 960820 - Ignore contexts and saved frame chains for exception stack, and rely on the principal check. r=luke,mrbkap sr=bz
Bobby Holley <bobbyholley@gmail.com> - Wed, 05 Mar 2014 08:18:06 -0800 - rev 183070
Bug 960820 - Ignore contexts and saved frame chains for exception stack, and rely on the principal check. r=luke,mrbkap sr=bz It would be nice to update the JS shell tests to make sure the principal check works, but we can't do that without bug 969273. So we add an XPConnect test that verifies the filtering behavior.
962b2f4d2ea14b5a51bbc9221ccf36441899c20f: Bug 978398 - Rename custom element callbacks from enteredView/leftView to attached/detached. r=mrbkap
William Chen <wchen@mozilla.com> - Fri, 28 Feb 2014 17:45:31 -0800 - rev 182910
Bug 978398 - Rename custom element callbacks from enteredView/leftView to attached/detached. r=mrbkap
9a5adc9f2dab20691bb367a4b9baa44f59e34f52: Bug 978468 - Add some MOZ_FINAL to XBL. r=mrbkap
Andrew McCreight <continuation@gmail.com> - Tue, 04 Mar 2014 09:49:39 -0800 - rev 182809
Bug 978468 - Add some MOZ_FINAL to XBL. r=mrbkap
33eb31ac3741e575df36b905a40a8fe493935175: Bug 976318 - Template element contents owner document should be an inert template document. r=mrbkap
William Chen <wchen@mozilla.com> - Mon, 03 Mar 2014 12:03:23 -0800 - rev 182637
Bug 976318 - Template element contents owner document should be an inert template document. r=mrbkap
1238bfc6607bfcfbecef5e57011676c0ea88f352: Bug 976651 - Encapsulate the Read of a new nsXBLPrototypeBinding::Read a little better. r=mrbkap
Andrew McCreight <continuation@gmail.com> - Thu, 27 Feb 2014 10:04:10 -0800 - rev 182063
Bug 976651 - Encapsulate the Read of a new nsXBLPrototypeBinding::Read a little better. r=mrbkap
b0e36a2e2ee5bb7a4b50dafcc3838992cb95f350: Bug 977248: Remove quirk.css rule that selects on an attribute that was only set by the old HTML parser. r=mrbkap
L. David Baron <dbaron@dbaron.org> - Wed, 26 Feb 2014 23:00:13 -0800 - rev 181902
Bug 977248: Remove quirk.css rule that selects on an attribute that was only set by the old HTML parser. r=mrbkap
3070f00e7833006dfaf5a18708becc43c1708ab8: Bug 976790 - Fix assertion failure, r=mrbkap.
Ben Turner <bent.mozilla@gmail.com> - Wed, 26 Feb 2014 15:53:43 -0800 - rev 181868
Bug 976790 - Fix assertion failure, r=mrbkap.
3d4a094ac17e373b5b242a636d0bb7d0686519ee: Bug 976790 - Fix assertion failure, r=mrbkap.
Ben Turner <bent.mozilla@gmail.com> - Wed, 26 Feb 2014 13:31:32 -0800 - rev 181828
Bug 976790 - Fix assertion failure, r=mrbkap.
174ec7df74aec1229fcb0df50ee08c42175ccd67: Bug 856140 - Sync our document.registerElement implementation to the current version of the spec. r=mrbkap
William Chen <wchen@mozilla.com> - Sun, 23 Feb 2014 13:01:26 -0800 - rev 181124
Bug 856140 - Sync our document.registerElement implementation to the current version of the spec. r=mrbkap
7dc90f3c1a213ba65292985de8c3d7c002bc8512: Bug 974546 - SpecialPowers wrappers should catch, wrap, and rethrow exceptions for callables. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 20 Feb 2014 08:57:20 -0800 - rev 180716
Bug 974546 - SpecialPowers wrappers should catch, wrap, and rethrow exceptions for callables. r=mrbkap
bfd52575b6d39a61fbab1387c3f6d846ea2949fe: Bug 965346 - Part 1: Ensure that callback is called, even when reply is null. r=mrbkap
Ted Clancy (:tedders1) <tclancy@mozilla.com> - Thu, 13 Feb 2014 08:51:12 -0800 - rev 180630
Bug 965346 - Part 1: Ensure that callback is called, even when reply is null. r=mrbkap
1f73309205ad159a5533483f99fbb9391d49c0fd: Bug 956382 - Remove implementations of *IgnoringDomain variants. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 13 Feb 2014 18:57:36 -0800 - rev 179740
Bug 956382 - Remove implementations of *IgnoringDomain variants. r=mrbkap
5874930ca0f99b8bcf76b443f456253bf4f28cd5: Bug 956382 - Remove usage of explicit *IgnoringDomain variants. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 13 Feb 2014 18:57:36 -0800 - rev 179739
Bug 956382 - Remove usage of explicit *IgnoringDomain variants. r=mrbkap
18d581a3cdda20a54de51540ac7e7fa99144e7ad: Bug 956382 - Remove unused CAPS gunk. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 13 Feb 2014 18:57:36 -0800 - rev 179738
Bug 956382 - Remove unused CAPS gunk. r=mrbkap
d8de4338ba02b092da9d0db0be091445e570d4fd: Bug 956382 - Hoist nsScriptSecurityManager::CheckSameOriginPrincipal into nsPrincipal::EqualsConsideringDomain. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 13 Feb 2014 18:57:36 -0800 - rev 179737
Bug 956382 - Hoist nsScriptSecurityManager::CheckSameOriginPrincipal into nsPrincipal::EqualsConsideringDomain. r=mrbkap
ce0bc42b933d307befb0cdccbee80ab2831f7a1a: Bug 956382 - Ignore document.domain by default. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 13 Feb 2014 18:57:36 -0800 - rev 179736
Bug 956382 - Ignore document.domain by default. r=mrbkap
31e3a45440b8a641f3f86cac23b2bfd69e7b5f68: Bug 956382 - Remove useless security checks in nsDocument. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 13 Feb 2014 18:57:36 -0800 - rev 179735
Bug 956382 - Remove useless security checks in nsDocument. r=mrbkap In an o-cap world, we'll generally not get references to cross-origin elements. And even if we do, we'll fail at the binding layer (when we try to CheckedUnwrap the security wrapper).
3d34cdd10637397f4a99c49e2283d61075b94670: Bug 956382 - Consider document.domain in wacky postMessage security check. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 13 Feb 2014 18:57:35 -0800 - rev 179734
Bug 956382 - Consider document.domain in wacky postMessage security check. r=mrbkap We can clean this stuff up in bug 968460.
5863efef36ed1d0111502c3ca65afe4170e85121: Bug 956382 - Consider document.domain for showModalDialog's dialogArguments and returnValue. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 13 Feb 2014 18:57:35 -0800 - rev 179733
Bug 956382 - Consider document.domain for showModalDialog's dialogArguments and returnValue. r=mrbkap
5c99be23516c1d497fe8b390a76df232157a5226: Bug 956382 - Consider document.domain when doing Location security checks. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 13 Feb 2014 18:57:35 -0800 - rev 179732
Bug 956382 - Consider document.domain when doing Location security checks. r=mrbkap
d4c5f52beb20ecd7a7a7581a994416f3bb9b41ac: Bug 956382 - Consider document.domain when deciding whether to return contentDocument. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 13 Feb 2014 18:57:35 -0800 - rev 179731
Bug 956382 - Consider document.domain when deciding whether to return contentDocument. r=mrbkap
4d72b6493e1dd3385b1dc3076cdd09835f3a160d: Bug 956382 - Consider document.domain when computing security wrappers. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 13 Feb 2014 18:57:35 -0800 - rev 179730
Bug 956382 - Consider document.domain when computing security wrappers. r=mrbkap
a0fd5acb4ea537d42f0e5391015f11d164e4afba: Bug 956382 - Add AccessCheck::subsumesConsideringDomain and clean up other implementations. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 13 Feb 2014 18:57:34 -0800 - rev 179729
Bug 956382 - Add AccessCheck::subsumesConsideringDomain and clean up other implementations. r=mrbkap We now assert that we have a principal when we enter the wrap callback, and we now have a convenient overload defined in nsIPrincipal.idl.
d4308d295f7d63359abafb82f98c348af001aa18: Bug 956382 - Introduce an explicit API to do principal checks with document.domain. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 13 Feb 2014 18:57:34 -0800 - rev 179728
Bug 956382 - Introduce an explicit API to do principal checks with document.domain. r=mrbkap
804ed7a7eb9f1d3d917ce2342c55efa92ba4afa3: Bug 965901 - Add an ENUMERATE policy action. r=gabor sr=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 13 Feb 2014 10:54:08 -0800 - rev 179603
Bug 965901 - Add an ENUMERATE policy action. r=gabor sr=mrbkap
ada4e3d61c3b85c3254b57a850b4af4c063fd383: Bug 965901 - Track and assert the policy action in AutoEnterPolicy/assertEnteredPolicy. r=gabor sr=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Thu, 13 Feb 2014 10:54:07 -0800 - rev 179602
Bug 965901 - Track and assert the policy action in AutoEnterPolicy/assertEnteredPolicy. r=gabor sr=mrbkap
ff7fd36c4a22ddc03a92c5595369c1a9a2d1e49f: Bug 965921 - Handle addons that expose JS-implemented XPCOM components to content. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Mon, 10 Feb 2014 10:27:24 -0800 - rev 178945
Bug 965921 - Handle addons that expose JS-implemented XPCOM components to content. r=mrbkap
b987d99d861ada90942361a4d5fa8d4048f79617: Bug 853356 - gUM video permisson prompt. r=fabrice, felipc, wjohnston, mrbkap, jimm, jesup, khuey, jsmith
Alfredo Yang <ayang@mozilla.com> - Sun, 09 Feb 2014 15:34:40 -0500 - rev 178784
Bug 853356 - gUM video permisson prompt. r=fabrice, felipc, wjohnston, mrbkap, jimm, jesup, khuey, jsmith
5f286819d8b151e5d14efc0abcf40fc0246d64d6: Bug 967206 - Remove !mDoc->EventHandlingSuppressed() assertion in ~nsGlobalWindow; r=mrbkap
Ms2ger <ms2ger@gmail.com> - Sun, 09 Feb 2014 09:04:39 +0100 - rev 178727
Bug 967206 - Remove !mDoc->EventHandlingSuppressed() assertion in ~nsGlobalWindow; r=mrbkap
c3530d73e8fe246e364b8337eea3ba0a762e47bd: Bug 956218 - '(PBackground) Add a mechanism for communicating with a non-main I/O thread via thread and process links'. r=mrbkap.
Ben Turner <bent.mozilla@gmail.com> - Tue, 26 Nov 2013 23:59:41 -0800 - rev 178233
Bug 956218 - '(PBackground) Add a mechanism for communicating with a non-main I/O thread via thread and process links'. r=mrbkap.
246619a2799221016d400aec982cbf02d378c28e: Bug 956218 - '(PBackground) Add a mechanism for communicating with a non-main I/O thread via thread and process links'. r=mrbkap.
Ben Turner <bent.mozilla@gmail.com> - Tue, 26 Nov 2013 23:59:41 -0800 - rev 178226
Bug 956218 - '(PBackground) Add a mechanism for communicating with a non-main I/O thread via thread and process links'. r=mrbkap.
e9a091fd0265f894828f0d99355279b83643949d: Bug 962604 - Add ActorDestroy handling to CPOWs (r=mrbkap)
Bill McCloskey <wmccloskey@mozilla.com> - Wed, 05 Feb 2014 08:39:59 -0800 - rev 177967
Bug 962604 - Add ActorDestroy handling to CPOWs (r=mrbkap)
1b0404fd3518277a43deb067aeda6f694c417045: Bug 982909 - Consistently use inner window when calling OpenJS. r=jst, r=mrbkap, a=abillings
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 13 Mar 2014 12:22:07 -0400 - rev 177523
Bug 982909 - Consistently use inner window when calling OpenJS. r=jst, r=mrbkap, a=abillings
5e88c90d7fe752cf139ca6ca7efbd44827d2f3bc: Bug 965921 - Handle addons that expose JS-implemented XPCOM components to content. r=mrbkap, a=sledru
Bobby Holley <bobbyholley@gmail.com> - Mon, 10 Feb 2014 10:27:24 -0800 - rev 177008
Bug 965921 - Handle addons that expose JS-implemented XPCOM components to content. r=mrbkap, a=sledru
b1974150d1a511db41e06cb1067d77962740ff16: Bug 965082 - Tests. r=mrbkap,r=gabor
Bobby Holley <bobbyholley@gmail.com> - Wed, 29 Jan 2014 13:07:13 -0800 - rev 176088
Bug 965082 - Tests. r=mrbkap,r=gabor
2d36a17e88c591ebafb2473f0ba32d5630c04b6e: Bug 965082 - Only run the {get,set}PrototypeOf override for non-SecurityWrappers. r=mrbkap,r=gabor
Bobby Holley <bobbyholley@gmail.com> - Wed, 29 Jan 2014 13:07:13 -0800 - rev 176087
Bug 965082 - Only run the {get,set}PrototypeOf override for non-SecurityWrappers. r=mrbkap,r=gabor
f8768358ad0f8ce7ff522eba6f2b812d6534f1b8: Bug 965082 - Unify duplicate bits of state of proxies. r=mrbkap,r=gabor
Bobby Holley <bobbyholley@gmail.com> - Wed, 29 Jan 2014 13:07:13 -0800 - rev 176086
Bug 965082 - Unify duplicate bits of state of proxies. r=mrbkap,r=gabor Conceptually, these all boil down to "is this a security wrapper?"
103b26ebd28a3b00a72feedae12350fb1012c3c6: Bug 811635 - Part 6: DOM API test. r=mrbkap, r=bz
Henry Chang <hchang@mozilla.com> - Mon, 27 Jan 2014 11:22:15 +0800 - rev 175906
Bug 811635 - Part 6: DOM API test. r=mrbkap, r=bz
020c2d3fca927d9d2eccac91dd9078a87608a1e8: Bug 811635 - Part 1: WebIDLs/IDLs for WifiP2pManager and WifiP2pStatusChangeEvent. r=vchang, sr=mrbkap
Henry Chang <hchang@mozilla.com> - Tue, 28 Jan 2014 15:47:51 +0800 - rev 175901
Bug 811635 - Part 1: WebIDLs/IDLs for WifiP2pManager and WifiP2pStatusChangeEvent. r=vchang, sr=mrbkap
042a31391d5585840da4e114af557efeaab58d51: Bug 959585, clear capturing content before entering modal state, r=mrbkap, f=enn
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 28 Jan 2014 09:15:47 -0800 - rev 175895
Bug 959585, clear capturing content before entering modal state, r=mrbkap, f=enn
cc32cb2daf2782ba95029cd30c462bc0c03653ae: Bug 957688 - Remove nsIXPCSecurityManager::CanAccess and nsScriptSecurityManager::CheckPropertyAccessImpl. r=mrbkap
Bobby Holley <bobbyholley@gmail.com> - Fri, 24 Jan 2014 16:08:26 -0800 - rev 175413
Bug 957688 - Remove nsIXPCSecurityManager::CanAccess and nsScriptSecurityManager::CheckPropertyAccessImpl. r=mrbkap \o/