Addressing review nit for bug 464202 that was improperly addressed in changeset 59d84ac24da2
authorShawn Wilsher <sdwilsh@shawnwilsher.com>
Thu, 20 Nov 2008 14:11:03 -0500
changeset 21855 b923f6b41e01fc0eaf2fe7a97b0df8b0b4d639a1
parent 21854 5b81a5dc74859b9820435fd4e93ee4af2b803494
child 21856 36156fbf817d8a0e2d54a271cf0bff94a1c41c13
push idunknown
push userunknown
push dateunknown
bugs464202
milestone1.9.1b2pre
Addressing review nit for bug 464202 that was improperly addressed in changeset 59d84ac24da2 original patch r=mrbkap, a=beltzner
storage/src/mozStorageService.cpp
--- a/storage/src/mozStorageService.cpp
+++ b/storage/src/mozStorageService.cpp
@@ -108,20 +108,18 @@ mozStorageService::XPConnect()
   return sXPConnect;
 }
 
 mozStorageService::~mozStorageService()
 {
     gStorageService = nsnull;
     PR_DestroyLock(mLock);
 
-    if (sXPConnect) {
-        NS_IF_RELEASE(sXPConnect);
-        sXPConnect = nsnull;
-    }
+    NS_IF_RELEASE(sXPConnect);
+    sXPConnect = nsnull;
 }
 
 nsresult
 mozStorageService::Init()
 {
     mLock = PR_NewLock();
     if (!mLock)
         return NS_ERROR_OUT_OF_MEMORY;