Bug 575657 - [e10s] TabChild should use NS_NOTREACHED in addition to NS_ERROR_NOT_IMPLEMENTED r=doug.turner a=approval2.0
authorMike Kristoffersen <mkristoffersen@mozilla.com>
Wed, 03 Nov 2010 14:00:49 +0100
changeset 57131 f3f9c6b6e30a8342de1fe494043c21839e7ade8b
parent 57130 c3e5072b75531e2e3e9baed5f09fc8d458b4d370
child 57132 905b4f845a71ff6b41bfb8638b91e3241b30c5dd
push idunknown
push userunknown
push dateunknown
reviewersdoug.turner, approval2.0
bugs575657
milestone2.0b8pre
Bug 575657 - [e10s] TabChild should use NS_NOTREACHED in addition to NS_ERROR_NOT_IMPLEMENTED r=doug.turner a=approval2.0
dom/ipc/TabChild.cpp
--- a/dom/ipc/TabChild.cpp
+++ b/dom/ipc/TabChild.cpp
@@ -156,138 +156,171 @@ NS_INTERFACE_MAP_BEGIN(TabChild)
 NS_INTERFACE_MAP_END
 
 NS_IMPL_ADDREF(TabChild)
 NS_IMPL_RELEASE(TabChild)
 
 NS_IMETHODIMP
 TabChild::SetStatus(PRUint32 aStatusType, const PRUnichar* aStatus)
 {
+  NS_NOTREACHED("TabChild::SetStatus not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::GetWebBrowser(nsIWebBrowser** aWebBrowser)
 {
+  NS_NOTREACHED("TabChild::GetWebBrowser not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::SetWebBrowser(nsIWebBrowser* aWebBrowser)
 {
+  NS_NOTREACHED("TabChild::SetWebBrowser not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::GetChromeFlags(PRUint32* aChromeFlags)
 {
   *aChromeFlags = mChromeFlags;
   return NS_OK;
 }
 
 NS_IMETHODIMP
 TabChild::SetChromeFlags(PRUint32 aChromeFlags)
 {
-  NS_ERROR("trying to SetChromeFlags from content process?");
+  NS_NOTREACHED("trying to SetChromeFlags from content process?");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::DestroyBrowserWindow()
 {
+  NS_NOTREACHED("TabChild::SetWebBrowser not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::SizeBrowserTo(PRInt32 aCX, PRInt32 aCY)
 {
+  NS_NOTREACHED("TabChild::SizeBrowserTo not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::ShowAsModal()
 {
+  NS_NOTREACHED("TabChild::ShowAsModal not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::IsWindowModal(PRBool* aRetVal)
 {
   *aRetVal = PR_FALSE;
   return NS_OK;
 }
 
 NS_IMETHODIMP
 TabChild::ExitModalEventLoop(nsresult aStatus)
 {
+  NS_NOTREACHED("TabChild::ExitModalEventLoop not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::SetStatusWithContext(PRUint32 aStatusType,
                                     const nsAString& aStatusText,
                                     nsISupports* aStatusContext)
 {
+  NS_NOTREACHED("TabChild::SetStatusWithContext not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::SetDimensions(PRUint32 aFlags, PRInt32 aX, PRInt32 aY,
                              PRInt32 aCx, PRInt32 aCy)
 {
+  NS_NOTREACHED("TabChild::SetDimensions not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::GetDimensions(PRUint32 aFlags, PRInt32* aX,
                              PRInt32* aY, PRInt32* aCx, PRInt32* aCy)
 {
+  NS_NOTREACHED("TabChild::GetDimensions not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::SetFocus()
 {
+  NS_NOTREACHED("TabChild::SetFocus not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::GetVisibility(PRBool* aVisibility)
 {
   *aVisibility = PR_TRUE;
   return NS_OK;
 }
 
 NS_IMETHODIMP
 TabChild::SetVisibility(PRBool aVisibility)
 {
+  NS_NOTREACHED("TabChild::SetVisibility not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::GetTitle(PRUnichar** aTitle)
 {
+  NS_NOTREACHED("TabChild::GetTitle not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::SetTitle(const PRUnichar* aTitle)
 {
+  NS_NOTREACHED("TabChild::SetTitle not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::GetSiteWindow(void** aSiteWindow)
 {
+  NS_NOTREACHED("TabChild::GetSiteWindow not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::Blur()
 {
+  NS_NOTREACHED("TabChild::Blur not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::FocusNextElement()
 {
   SendMoveFocus(PR_TRUE);
   return NS_OK;