Bug 813383 - Use firstElementChild/nextElementSibling/lastElementChild instead of firstChild/nextSibling/lastChild when possible. r=felipe
authorJared Wein <jwein@mozilla.com>
Mon, 19 Nov 2012 17:54:12 -0800
changeset 119311 1aab9de3c55472c04651164b445357cb1bf5b87c
parent 119310 5c2a58449a3d04ac1adade9a93f82f7a9a61d33d
child 119312 a047867610ac825164dac5ce5bec25cfacd80df7
push idunknown
push userunknown
push dateunknown
reviewersfelipe
bugs813383
milestone20.0a1
Bug 813383 - Use firstElementChild/nextElementSibling/lastElementChild instead of firstChild/nextSibling/lastChild when possible. r=felipe
browser/base/content/socialchat.xml
--- a/browser/base/content/socialchat.xml
+++ b/browser/base/content/socialchat.xml
@@ -174,33 +174,33 @@
           return !!this.querySelector("[collapsed]");
         ]]></getter>
       </property>
 
       <property name="collapsedChildren">
         <getter><![CDATA[
           // A generator yielding all collapsed chatboxes, in the order in
           // which they should be restored.
-          let child = this.lastChild;
+          let child = this.lastElementChild;
           while (child) {
             if (child.collapsed)
               yield child;
-            child = child.previousSibling;
+            child = child.previousElementSibling;
           }
         ]]></getter>
       </property>
 
       <property name="visibleChildren">
         <getter><![CDATA[
           // A generator yielding all non-collapsed chatboxes.
-          let child = this.firstChild;
+          let child = this.firstElementChild;
           while (child) {
             if (!child.collapsed)
               yield child;
-            child = child.nextSibling;
+            child = child.nextElementSibling;
           }
         ]]></getter>
       </property>
 
       <property name="collapsibleChildren">
         <getter><![CDATA[
           // A generator yielding all children which are able to be collapsed
           // in the order in which they should be collapsed.
@@ -354,18 +354,18 @@
           }
           this.chatboxForURL.delete(aChatbox.getAttribute('src'));
         ]]></body>
       </method>
 
       <method name="removeAll">
         <body><![CDATA[
           this.selectedChat = null;
-          while (this.firstChild) {
-            this._remove(this.firstChild);
+          while (this.firstElementChild) {
+            this._remove(this.firstElementChild);
           }
           // and the nub/popup must also die.
           this.nub.collapsed = true;
         ]]></body>
       </method>
 
       <method name="initChatBox">
         <!-- ideally this would be a method on the chatbox itself, but the