Bug 857376 - Use 2k page_size for databases on B2G. r=mak, sr=mossop, a=tef+
☠☠ backed out by e7620c6e01d2 ☠ ☠
authorBen Turner <bent.mozilla@gmail.com>
Mon, 08 Apr 2013 08:51:45 -0400
changeset 118986 aa6f30aa779cca11c329c1eb1d98d56340f2ee51
parent 118985 ed94f222170cd349b892f257f3c6918145eac011
child 118987 3f96276c678a3381c5b5c215316d0a10e5188aeb
push id635
push userryanvm@gmail.com
push dateMon, 08 Apr 2013 12:54:53 +0000
reviewersmak, mossop, tef
bugs857376
milestone18.0
Bug 857376 - Use 2k page_size for databases on B2G. r=mak, sr=mossop, a=tef+
db/sqlite3/src/Makefile.in
storage/public/mozIStorageConnection.idl
--- a/db/sqlite3/src/Makefile.in
+++ b/db/sqlite3/src/Makefile.in
@@ -67,30 +67,30 @@ EXPORTS = \
 CSRCS = \
   sqlite3.c \
   $(NULL)
 
 # -DSQLITE_SECURE_DELETE=1 will cause SQLITE to 0-fill delete data so we
 # don't have to vacuum to make sure the data is not visible in the file.
 # -DSQLITE_ENABLE_FTS3=1 enables the full-text index module.
 # -DSQLITE_CORE=1 statically links that module into the SQLite library.
-# -DSQLITE_DEFAULT_PAGE_SIZE=32768 and SQLITE_MAX_DEFAULT_PAGE_SIZE=32768
+# -DSQLITE_DEFAULT_PAGE_SIZE=2048 and SQLITE_MAX_DEFAULT_PAGE_SIZE=32768
 # increases the page size from 1k, see bug 416330.  The value must stay in sync
 # with mozIStorageConnection::DEFAULT_PAGE_SIZE.
 # -DSQLITE_MAX_SCHEMA_RETRY increases the times SQLite may try to reparse
 # statements when the schema changes. This is important when supporting lots of
 # concurrent connections, especially when they use shared cache.
 # Note: Be sure to update the configure.in checks when these change!
 DEFINES = \
   -DSQLITE_SECURE_DELETE=1 \
   -DSQLITE_THREADSAFE=1 \
   -DSQLITE_CORE=1 \
   -DSQLITE_ENABLE_FTS3=1 \
   -DSQLITE_ENABLE_UNLOCK_NOTIFY=1 \
-  -DSQLITE_DEFAULT_PAGE_SIZE=32768 \
+  -DSQLITE_DEFAULT_PAGE_SIZE=2048 \
   -DSQLITE_MAX_DEFAULT_PAGE_SIZE=32768 \
   -DSQLITE_MAX_SCHEMA_RETRY=25 \
   $(NULL)
 
 # -DSQLITE_ENABLE_LOCKING_STYLE=1 to help with AFP folders
 ifeq ($(MOZ_WIDGET_TOOLKIT),cocoa)
 DEFINES += -DSQLITE_ENABLE_LOCKING_STYLE=1
 endif
--- a/storage/public/mozIStorageConnection.idl
+++ b/storage/public/mozIStorageConnection.idl
@@ -20,25 +20,25 @@ interface nsIFile;
  * mozIStorageConnection represents a database connection attached to
  * a specific file or to the in-memory data storage.  It is the
  * primary interface for interacting with a database, including
  * creating prepared statements, executing SQL, and examining database
  * errors.
  *
  * @threadsafe
  */
-[scriptable, uuid(b2a4b534-f92e-4387-9bd9-d10408173925)]
+[scriptable, uuid(eaca7250-2cbc-4a1f-ba12-2f30da42e4fc)]
 interface mozIStorageConnection : nsISupports {
   /**
    * The default size for SQLite database pages used by mozStorage for new
    * databases.
    * This value must stay in sync with the SQLITE_DEFAULT_PAGE_SIZE define in
    * /db/sqlite3/src/Makefile.in
    */
-  const long DEFAULT_PAGE_SIZE = 32768;
+  const long DEFAULT_PAGE_SIZE = 2048;
 
   /**
    * Closes a database connection.  Callers must finalize all statements created
    * for this connection prior to calling this method.  It is illegal to use
    * call this method if any asynchronous statements have been executed on this
    * connection.
    *
    * @throws NS_ERROR_UNEXPECTED