Bug 729135: Fix virtual function warnings in core plugin code. r=bsmedberg
authorJosh Aas <joshmoz@gmail.com>
Wed, 22 Feb 2012 00:19:27 -0500
changeset 90254 615ee091ee66e30230bf57cfe82aeb9e694ab1ae
parent 90253 a1f579a1ad62a97361740ca50d0cd278844d4b1c
child 90255 c73a25f9fbd3d674b82c0ae996154c499513bdd1
push idunknown
push userunknown
push dateunknown
reviewersbsmedberg
bugs729135
milestone13.0a1
Bug 729135: Fix virtual function warnings in core plugin code. r=bsmedberg
dom/plugins/base/nsNPAPIPlugin.cpp
dom/plugins/base/nsPluginStreamListenerPeer.cpp
--- a/dom/plugins/base/nsNPAPIPlugin.cpp
+++ b/dom/plugins/base/nsNPAPIPlugin.cpp
@@ -683,17 +683,17 @@ public:
   NS_DECL_ISUPPORTS
 
 protected:
   nsIOutputStream *fStream;
   NPStream        fNPStream;
 
 public:
   nsNPAPIStreamWrapper(nsIOutputStream* stream);
-  ~nsNPAPIStreamWrapper();
+  virtual ~nsNPAPIStreamWrapper();
 
   void GetStream(nsIOutputStream* &result);
   NPStream* GetNPStream() { return &fNPStream; }
 };
 
 class nsPluginThreadRunnable : public nsRunnable,
                                public PRCList
 {
--- a/dom/plugins/base/nsPluginStreamListenerPeer.cpp
+++ b/dom/plugins/base/nsPluginStreamListenerPeer.cpp
@@ -1330,16 +1330,19 @@ public:
                                nsIChannel* newChannel)
     : mWeakListener(do_GetWeakReference(listener))
     , mParent(parent)
     , mOldChannel(oldChannel)
     , mNewChannel(newChannel)
   {
   }
 
+  ChannelRedirectProxyCallback() {}
+  virtual ~ChannelRedirectProxyCallback() {}
+
   NS_DECL_ISUPPORTS
 
   NS_IMETHODIMP OnRedirectVerifyCallback(nsresult result)
   {
     if (NS_SUCCEEDED(result)) {
       nsCOMPtr<nsINPAPIPluginStreamInfo> listener = do_QueryReferent(mWeakListener);
       if (listener)
         listener->ReplaceRequest(mOldChannel, mNewChannel);