Bug 390699 - "Let DUMP_SYMS_BIN be set from environment". r=luser, a=bz.
authorbent.mozilla@gmail.com
Sun, 19 Aug 2007 11:06:53 -0700
changeset 4796 168e5b87c86bf532ff081db740c4917ef0f89939
parent 4795 a3eb6479cf0c404eff6c1f1d299c9f7c17d16d93
child 4797 a59ffaa491b8140e5491035ecf355ef4be67b21c
push idunknown
push userunknown
push dateunknown
reviewersluser, bz
bugs390699
milestone1.9a8pre
Bug 390699 - "Let DUMP_SYMS_BIN be set from environment". r=luser, a=bz.
Makefile.in
--- a/Makefile.in
+++ b/Makefile.in
@@ -129,34 +129,34 @@ ifdef MOZ_PROFILE
 	/bin/find $(DIST) -name "*.dbg" -exec mv {} $(DIST)/$(BUILDID) \;
 endif # MOZ_PROFILE
 endif # MOZILLA_OFFICIAL
 endif # WINNT
 
 ifeq ($(OS_ARCH),WINNT)
 # we want to copy PDB files on Windows
 MAKE_SYM_STORE_ARGS := -c
-DUMP_SYMS_BIN := $(topsrcdir)/toolkit/crashreporter/tools/win32/dump_syms.exe
+DUMP_SYMS_BIN ?= $(topsrcdir)/toolkit/crashreporter/tools/win32/dump_syms.exe
 # PDB files don't get moved to dist, so we need to scan the whole objdir
 MAKE_SYM_STORE_PATH := .
 endif
 ifeq ($(OS_ARCH),Darwin)
 # need to pass arch flags for universal builds
 ifdef UNIVERSAL_BINARY
 MAKE_SYM_STORE_ARGS := -a "ppc i386" --vcs-info
 MAKE_SYM_STORE_PATH := $(DIST)/universal
 else
 MAKE_SYM_STORE_ARGS := -a $(OS_TEST) --vcs-info
 MAKE_SYM_STORE_PATH := $(DIST)/bin
 endif
-DUMP_SYMS_BIN := $(DIST)/host/bin/dump_syms
+DUMP_SYMS_BIN ?= $(DIST)/host/bin/dump_syms
 endif
 ifeq ($(OS_ARCH),Linux)
 MAKE_SYM_STORE_ARGS := --vcs-info
-DUMP_SYMS_BIN := $(DIST)/host/bin/dump_syms
+DUMP_SYMS_BIN ?= $(DIST)/host/bin/dump_syms
 MAKE_SYM_STORE_PATH := $(DIST)/bin
 endif
 
 ifdef MOZ_SYMBOLS_EXTRA_BUILDID
 EXTRA_BUILDID := -$(MOZ_SYMBOLS_EXTRA_BUILDID)
 endif
 
 buildsymbols: