searching for reviewer(waldo)
aa9fa3143f909865c26b3012355b72e608fc2f3b: Bug 821804 - Allow unitialized WeakPtrs to work properly. r=Waldo, a=tef+
Jeff Muizelaar <jmuizelaar@mozilla.com> - Tue, 18 Dec 2012 11:37:14 -0500 - rev 119025
Push 649 by ryanvm@gmail.com at Wed, 10 Apr 2013 12:34:26 +0000
Bug 821804 - Allow unitialized WeakPtrs to work properly. r=Waldo, a=tef+ This ensures that the WeakPtr always points at a valid object and avoids the need to test for that during operations.
af9270e8f2050d7eb97ace87f2f11138a28b4630: Bug 849785 - Avoid repeated computation of local standard time vs. UTC time difference. r=waldo, a=lsblakk
Brian Hackett <bhackett1024@gmail.com> - Fri, 15 Mar 2013 16:37:45 -0600 - rev 118765
Push 558 by bhackett@mozilla.com at Fri, 15 Mar 2013 22:37:56 +0000
Bug 849785 - Avoid repeated computation of local standard time vs. UTC time difference. r=waldo, a=lsblakk
d683eefee3f0f92441f5fa39d80cdcdb7dc6dcb4: Bug 803688 - Remove LinkedListElements from their list when they're destructed, and assert that a LinkedList is empty when it's destructed. r=waldo, a=tef+
Justin Lebar <justin.lebar@gmail.com> - Wed, 24 Oct 2012 12:40:35 -0400 - rev 118608
Push 494 by ryanvm@gmail.com at Tue, 26 Feb 2013 14:37:52 +0000
Bug 803688 - Remove LinkedListElements from their list when they're destructed, and assert that a LinkedList is empty when it's destructed. r=waldo, a=tef+
7a2beec4629b85a96d3ab41c4aa6e87fd9225817: Bug 818023 - fun_getProperty: Use non-buitin script iterator. r=waldo, a=bajaj
Nicolas B. Pierron <nicolas.b.pierron@mozilla.com> - Thu, 10 Jan 2013 11:19:21 -0800 - rev 118211
Push 278 by ryanvm@gmail.com at Thu, 17 Jan 2013 00:42:54 +0000
Bug 818023 - fun_getProperty: Use non-buitin script iterator. r=waldo, a=bajaj
83dfc9ad403f90e2ba6343ffc690c5b688dca41b: Bug 804988 - Clear the DSTOffsetCache when timezone change is detected. r=Waldo, a=blocking-basecamp
Benjamin Chen <bechen@mozilla.com> - Mon, 24 Dec 2012 16:00:28 +0800 - rev 117945
Push 127 by ryanvm@gmail.com at Mon, 07 Jan 2013 02:29:00 +0000
Bug 804988 - Clear the DSTOffsetCache when timezone change is detected. r=Waldo, a=blocking-basecamp
078191be059693596a8f25532010a6f67559c197: Bug 807112 - Change MOZ_EXPORT_API and MOZ_IMPORT_API to not take the type. r=Waldo, a=jlebar
Rafael Ávila de Espíndola <respindola@mozilla.com> - Wed, 31 Oct 2012 18:18:12 -0400 - rev 117533
Push 28 by ryanvm@gmail.com at Fri, 14 Dec 2012 01:37:47 +0000
Bug 807112 - Change MOZ_EXPORT_API and MOZ_IMPORT_API to not take the type. r=Waldo, a=jlebar
a04be19aa439d69cbeb753d1277836cfc4099feb: Bug 805416 - Refactor macros to avoid the need for empty macro arguments. r=Waldo, a=jlebar
Rafael Ávila de Espíndola <respindola@mozilla.com> - Tue, 30 Oct 2012 16:12:22 -0400 - rev 117532
Push 28 by ryanvm@gmail.com at Fri, 14 Dec 2012 01:37:47 +0000
Bug 805416 - Refactor macros to avoid the need for empty macro arguments. r=Waldo, a=jlebar
559b5433642102966ba7a11081f92861af0020fd: Bug 809677 - Refactor httpd.js to work when modules are functions. r=Waldo, a=blocking-basecamp
Gregory Szorc <gps@mozilla.com> - Fri, 09 Nov 2012 14:48:28 -0800 - rev 117239
Push 1 by ffxbld at Tue, 04 Dec 2012 22:26:59 +0000
Bug 809677 - Refactor httpd.js to work when modules are functions. r=Waldo, a=blocking-basecamp
79257293253ba55edda79bbd7c439a911e80c047: Bug 798123 - Fix build bustage. r=Waldo, a=blocking-basecamp
Ryan VanderMeulen <ryanvm@gmail.com> - Thu, 18 Oct 2012 22:21:38 -0400 - rev 117112
Bug 798123 - Fix build bustage. r=Waldo, a=blocking-basecamp
237ca1852d59f6c6b2ff242b91af0b15bc7f66c8: Bug 803692 - Make SHA1Sum::update() take a void* instead of a uint8_t*. r=waldo, a=blocking-basecamp
Justin Lebar <justin.lebar@gmail.com> - Mon, 22 Oct 2012 16:32:34 -0400 - rev 116294
Bug 803692 - Make SHA1Sum::update() take a void* instead of a uint8_t*. r=waldo, a=blocking-basecamp
e51d8558ad641e9fff3e10e20384a2f365c8a9f9: Bug 797123 - Fix JS_ALWAYS_TRUE(fallible ToNumber) in jstypedarray.cpp. r=Waldo
Steve Fink <sfink@mozilla.com> - Thu, 20 Sep 2012 11:21:12 -0700 - rev 115756
Bug 797123 - Fix JS_ALWAYS_TRUE(fallible ToNumber) in jstypedarray.cpp. r=Waldo Apparently, it was once believed that ToNumber is infallible when given a primitive value. It has 2 or 3 different ways of failing on OOM. For example, if you're onverting a string containing a double, you might blow out memory constructing the dtoa cache.
92af89fcb63875b840314f1b0ad1f3d1094b68a9: Bug 796523 - Expire the JS timezone cache whenever we create a new compartment. r=waldo
Justin Lebar <justin.lebar@gmail.com> - Fri, 05 Oct 2012 11:33:36 -0400 - rev 115700
Bug 796523 - Expire the JS timezone cache whenever we create a new compartment. r=waldo This is a hack/heuristic to ensure that the JS timezone cache remains fresh (so that if you navigate to a new page or refresh your gmail, you always get the right timezone), while not interfering with the role the cache plays in benchmark performance.
a2630fb2dbfa056a44106b59c84bfc7f9351a943: Bug 792954. Add a WeakPtr implementation to use instead of nsISupportsWeakReference. r=joe,ehsan,Waldo
Jeff Muizelaar <jmuizelaar@mozilla.com> - Thu, 04 Oct 2012 15:45:07 -0400 - rev 115575
Bug 792954. Add a WeakPtr implementation to use instead of nsISupportsWeakReference. r=joe,ehsan,Waldo This patch also replaces the usage of nsISupportsWeakReference in RasterImage as an example.
8b5a786ee47b5d103a16031119098d1b99900e39: Bug 795574 - name lookup in JSOP_IMPLICITTHIS should default to the global (r=waldo)
Luke Wagner <luke@mozilla.com> - Tue, 02 Oct 2012 10:51:10 -0700 - rev 115215
Bug 795574 - name lookup in JSOP_IMPLICITTHIS should default to the global (r=waldo)
7ffcbd67d18d72b45380f0cc3a48123bbe8f85a5: Bug 792689 - Add some double negations to the macros in Likely.h; r=Waldo
Ms2ger <ms2ger@gmail.com> - Thu, 20 Sep 2012 13:17:05 +0200 - rev 114000
Bug 792689 - Add some double negations to the macros in Likely.h; r=Waldo
6a2d1a3556b94d4bac0d0283dfe6152110d7af79: Bug 792689 - Add some double negations to the macros in Likely.h; r=Waldo
Ms2ger <ms2ger@gmail.com> - Thu, 20 Sep 2012 13:17:05 +0200 - rev 113883
Bug 792689 - Add some double negations to the macros in Likely.h; r=Waldo
7d54dc3c254e888c58ed9a0749c5fd722639de12: Bug 785551 - Remove an orphaned variable: r=Waldo
Terrence Cole <terrence@mozilla.com> - Wed, 19 Sep 2012 17:00:03 -0700 - rev 113860
Bug 785551 - Remove an orphaned variable: r=Waldo
e38d70105ba327cedccd007a7d8bf9d0dbd26c33: Bug 788356 - Fix memory leak in evaluate(). JS shell only; this code is not part of the browser. r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Tue, 18 Sep 2012 06:03:23 -0500 - rev 113671
Bug 788356 - Fix memory leak in evaluate(). JS shell only; this code is not part of the browser. r=Waldo.
2e9d543ae2ec6de6e5b56c39c5a1e4c7c66e653d: Bug 789239 - Unravel 30-line if condition in Parser.cpp. Part 2 - Rewrite IsValidForStatementLHS using early returns. r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Tue, 18 Sep 2012 06:03:22 -0500 - rev 113670
Bug 789239 - Unravel 30-line if condition in Parser.cpp. Part 2 - Rewrite IsValidForStatementLHS using early returns. r=Waldo.
2085233469a0e140c9dd499b47bd9156a43c3e00: Bug 789239 - Unravel 30-line if condition in Parser.cpp. Part 1 - Move the condition into a helper function. r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Tue, 18 Sep 2012 06:03:22 -0500 - rev 113669
Bug 789239 - Unravel 30-line if condition in Parser.cpp. Part 1 - Move the condition into a helper function. r=Waldo.
5acfcf041a4002ead1914420f19eeb4719cfc453: Bug 728079 - "Assertion failure: pn2->pn_u.binary.iflags & 0x1" with JS 1.7, for-of loop, and destructuring. r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Thu, 13 Sep 2012 07:56:52 -0500 - rev 113668
Bug 728079 - "Assertion failure: pn2->pn_u.binary.iflags & 0x1" with JS 1.7, for-of loop, and destructuring. r=Waldo.
79a25e159bfd81ccb0ca7f6e4975afaff825e096: Bug 782647. Move the nullptr workaround macros to MFBT so that it can be shared. r=waldo
Jeff Muizelaar <jmuizelaar@mozilla.com> - Sat, 01 Sep 2012 16:16:17 -0400 - rev 113568
Bug 782647. Move the nullptr workaround macros to MFBT so that it can be shared. r=waldo This also changes the header to use compiler detection instead of a configure test. This makes the header more portable because it doesn't require the configure infrastructure.
8cebabaead164c6c923c7fd0f4b3e138c2c8a8c1: Bug 784631 - Fix some clang build errors in SpiderMonkey; r=Waldo f=espindola
Terrence Cole <terrence@mozilla.com> - Tue, 11 Sep 2012 12:31:04 -0700 - rev 113132
Bug 784631 - Fix some clang build errors in SpiderMonkey; r=Waldo f=espindola Computed gotos are not in the C++ standard: clang and gcc differ on semantics.
c25bdb22bc5e8becd9f068fc70f94e99285f8b24: Bug 722581 - Update comments in mfbt/LinkedList.h. r=waldo
Justin Lebar <justin.lebar@gmail.com> - Sat, 04 Feb 2012 21:49:10 -0500 - rev 112039
Bug 722581 - Update comments in mfbt/LinkedList.h. r=waldo
0704423462e975004aeb64c55b5040bd3f8bb87b: Fix Clang warning (no bug, rs=Waldo)
Jan de Mooij <jdemooij@mozilla.com> - Wed, 28 Dec 2011 17:40:02 +0100 - rev 111770
Fix Clang warning (no bug, rs=Waldo)
04eb40b6fdd0e47a064fcb068678dc7abb57655f: Bug 788261 - Split PNK_FUNCTION into multiple parse node kinds. Part 2, split PNK_FUNCTION{DECL,EXPR}. r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Thu, 06 Sep 2012 11:19:56 -0500 - rev 110801
Bug 788261 - Split PNK_FUNCTION into multiple parse node kinds. Part 2, split PNK_FUNCTION{DECL,EXPR}. r=Waldo.
bb7d4d4693559fc4a6be36161dc9678b5105b53b: Bug 788261 - Split PNK_FUNCTION into multiple parse node kinds. Part 1, split PNK_FUNCTIONNS from PNK_FUNCTION. r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Thu, 06 Sep 2012 08:19:01 -0500 - rev 110800
Bug 788261 - Split PNK_FUNCTION into multiple parse node kinds. Part 1, split PNK_FUNCTIONNS from PNK_FUNCTION. r=Waldo.
1200e475363f7a52f9330631aa18987e37b9d47f: Minor improvements to js::frontend::ParseNode::dump(). Bug 788227, r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Thu, 06 Sep 2012 08:13:10 -0500 - rev 110799
Minor improvements to js::frontend::ParseNode::dump(). Bug 788227, r=Waldo.
c2e5feedaa8fa94e48429b7fb81b795fb83e1af7: Rename PNK_RB and friends to more meaningful names. Bug 788222, r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Thu, 06 Sep 2012 08:00:33 -0500 - rev 110798
Rename PNK_RB and friends to more meaningful names. Bug 788222, r=Waldo.
a3a7de3e29383d24109b21d12c2c83aca7c0c841: Bug 784294 - Convert some array extras to self-hosted js implementations. r=Waldo
Till Schneidereit <tschneidereit@gmail.com> - Tue, 28 Aug 2012 14:35:15 +0200 - rev 110774
Bug 784294 - Convert some array extras to self-hosted js implementations. r=Waldo The following methods are converted: - lastIndexOf - indexOf - forEach - some - every - reduce - reduceRight
7d8832ad7f1f9c99476011313e42eb783b3ad040: Bug 782467 - Remove sharpObjectMap and simplify obj_toSource; r=Waldo r=njn
Terrence Cole <terrence@mozilla.com> - Fri, 17 Aug 2012 16:48:02 -0700 - rev 110273
Bug 782467 - Remove sharpObjectMap and simplify obj_toSource; r=Waldo r=njn The sharpObjectMap is only needed to check for recursion now. This means we can share the necessary cycle detector code with busyArrays and remove the last chunk of sharp related code.
87a15b06c8a838ebca909c03f75b868ac4943259: Bug 669043 - Don't assert when the decompiler temporarily changes script->code (r=waldo)
Luke Wagner <luke@mozilla.com> - Tue, 12 Jul 2011 09:50:25 -0700 - rev 109837
Bug 669043 - Don't assert when the decompiler temporarily changes script->code (r=waldo)
4a1e0b5f95355b086bd2d887177e6786062cbdb5: Bug 650618 - Make sure XML objects get a (rooted-at-global) parent (r=waldo)
Luke Wagner <luke@mozilla.com> - Fri, 15 Jul 2011 13:56:12 -0700 - rev 109836
Bug 650618 - Make sure XML objects get a (rooted-at-global) parent (r=waldo)
28ef082de058889014a0b2f0acb3245ea1b7a36e: Bug 795574 - name lookup in JSOP_IMPLICITTHIS should default to the global (r=waldo,a=bajaj)
Luke Wagner <luke@mozilla.com> - Tue, 02 Oct 2012 10:51:10 -0700 - rev 109418
Bug 795574 - name lookup in JSOP_IMPLICITTHIS should default to the global (r=waldo,a=bajaj)
46f6ff1007bc1eca57538b7cc4ae6ae0c8b7becf: Bug 766448 - Refactor JSPropertySpec and JS_DefineProperties to accept JSJitInfos. (r=Waldo)
Eric Faust <efaust@mozilla.com> - Tue, 07 Aug 2012 22:26:18 -0700 - rev 107255
Bug 766448 - Refactor JSPropertySpec and JS_DefineProperties to accept JSJitInfos. (r=Waldo)
28711b9f49cdd827451380906d9a0226a4436c47: Bug 646599 - Constant folding should happen before deciding whether to turn obj[A] into obj.A. r=Waldo
Tom Schuster <evilpies@gmail.com> - Sat, 21 Jul 2012 13:05:07 +0200 - rev 105499
Bug 646599 - Constant folding should happen before deciding whether to turn obj[A] into obj.A. r=Waldo
2fe4ea4a614ef509002f40afd48ec6d2632e131b: Bug 758408 - Fix XML slot handling (r=Waldo)
Bill McCloskey <wmccloskey@mozilla.com> - Thu, 19 Jul 2012 16:56:14 -0700 - rev 105327
Bug 758408 - Fix XML slot handling (r=Waldo)
18295d17cba2fe08f96f73f7add71c70360e60b8: Bug 725907 - for-of improvements, part 1: minor C++ refactoring, rename Iterator to PropertyIteratorObject. r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Tue, 03 Jul 2012 16:34:40 -0500 - rev 105308
Bug 725907 - for-of improvements, part 1: minor C++ refactoring, rename Iterator to PropertyIteratorObject. r=Waldo.
0be7b0709e5de068a872e0ccc6d92e4d202a25d8: Bug 772688 - add BindingIter and use it instead of directly touching a Binding's shape (r=waldo)
Luke Wagner <luke@mozilla.com> - Thu, 05 Jul 2012 20:35:08 -0700 - rev 105052
Bug 772688 - add BindingIter and use it instead of directly touching a Binding's shape (r=waldo)
430e25acf004af98391055df16d9e1d93ec06a6e: Bug 769192 - Typed array accessors should not use JSPROP_READONLY. r=Waldo
Steve Fink <sfink@mozilla.com> - Mon, 16 Jul 2012 11:11:06 -0700 - rev 105050
Bug 769192 - Typed array accessors should not use JSPROP_READONLY. r=Waldo
811a6217b1b9d23fad65038448fa4699b7cd37e0: Bug 765464 - Part b: Add an exnType to JSErrorReport; r=Waldo
Ms2ger <ms2ger@gmail.com> - Wed, 18 Jul 2012 12:36:08 +0200 - rev 104991
Bug 765464 - Part b: Add an exnType to JSErrorReport; r=Waldo
ba8f96c4918588c9ae6487b8d7aa6295cd5be4e7: Bug 765464 - Part a: Introduce JS_ReportErrorNumberVA; r=Waldo
Ms2ger <ms2ger@gmail.com> - Wed, 18 Jul 2012 12:36:08 +0200 - rev 104990
Bug 765464 - Part a: Introduce JS_ReportErrorNumberVA; r=Waldo
81c6465d31b6d708318f910751c20fa74e1996d5: Bug 758408 - Fix XML slot handling (r=Waldo,a=lsblakk)
Bill McCloskey <wmccloskey@mozilla.com> - Mon, 06 Aug 2012 16:38:19 -0700 - rev 104386
Bug 758408 - Fix XML slot handling (r=Waldo,a=lsblakk)
30546191916b215bb11e07e6b766a2fca53cad93: Bug 769192 - Typed array accessors should not use JSPROP_READONLY. r=Waldo, a=lsblakk
Steve Fink <sfink@mozilla.com> - Mon, 16 Jul 2012 11:11:06 -0700 - rev 104292
Bug 769192 - Typed array accessors should not use JSPROP_READONLY. r=Waldo, a=lsblakk
8590078b5508a69caff1cf76dbc664f359a19e7b: Bug 285615 - Define and implement JS_ClearDateCaches() API. r=waldo
Sean Stangl <sstangl@mozilla.com> - Fri, 13 Jul 2012 15:56:08 -0700 - rev 104047
Bug 285615 - Define and implement JS_ClearDateCaches() API. r=waldo
d99d8b4d0eeb0ecb6e22f8a6434e6de4310d8099: Bug 769192 - Typed array accessors should not use JSPROP_READONLY. r=Waldo
Steve Fink <sfink@mozilla.com> - Wed, 11 Jul 2012 11:54:56 -0700 - rev 103805
Bug 769192 - Typed array accessors should not use JSPROP_READONLY. r=Waldo
5645ad3abc2c7b19e6304993753286655ca51811: Bug 771896 - rm LOAD_ATOM, LOAD_NAME, and 'atoms' from js::Interpret (r=waldo)
Luke Wagner <luke@mozilla.com> - Sun, 08 Jul 2012 04:31:04 -0700 - rev 103506
Bug 771896 - rm LOAD_ATOM, LOAD_NAME, and 'atoms' from js::Interpret (r=waldo)
0da8cb3296fd211ef099159a8287db62e51f13cd: Bug 770407 - Remove overzealous assert in CrossCompartmentWrapper::nativeCall (r=waldo)
Luke Wagner <luke@mozilla.com> - Tue, 03 Jul 2012 18:51:02 -0700 - rev 103393
Bug 770407 - Remove overzealous assert in CrossCompartmentWrapper::nativeCall (r=waldo)
3a488b71b69a7586cb506510a2535f559e7db64b: Bug 725907 - for-of improvements, part 1: minor C++ refactoring, rename Iterator to PropertyIteratorObject. r=Waldo.
Jason Orendorff <jorendorff@mozilla.com> - Tue, 03 Jul 2012 16:34:40 -0500 - rev 103071
Bug 725907 - for-of improvements, part 1: minor C++ refactoring, rename Iterator to PropertyIteratorObject. r=Waldo.
3b86df322556777a22418fcd7a1e6f502422218e: Bug 769743 - Bump the XDR version because bug 769743 forgot to do it (rs=waldo)
Luke Wagner <luke@mozilla.com> - Mon, 02 Jul 2012 14:54:01 -0700 - rev 102932
Bug 769743 - Bump the XDR version because bug 769743 forgot to do it (rs=waldo)