Bug 979456 - [Australis] fix extra padding in bookmarks toolbar on Australis, r=mconley, a=gavin.
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Tue, 11 Mar 2014 19:56:01 -0400
changeset 177471 fd7cb7a420cdfbdb43873b75bb07b4077915f432
parent 177470 551b60c2c917507ab037e84da4f49a7c3ee17b13
child 177472 262af03ee2c6017c914a77b9983fbaf049f80a54
push id5389
push usermconley@mozilla.com
push dateTue, 11 Mar 2014 23:57:31 +0000
treeherdermozilla-aurora@fd7cb7a420cd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmconley, gavin
bugs979456
milestone29.0a2
Bug 979456 - [Australis] fix extra padding in bookmarks toolbar on Australis, r=mconley, a=gavin.
browser/base/content/browser.xul
browser/components/places/content/browserPlacesViews.js
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -934,17 +934,17 @@
         <hbox flex="1"
               id="PlacesToolbar"
               context="placesContext"
               onclick="BookmarksEventHandler.onClick(event, this._placesView);"
               oncommand="BookmarksEventHandler.onCommand(event, this._placesView);"
               tooltip="bhTooltip"
               popupsinherittooltip="true">
           <hbox flex="1">
-            <hbox id="PlacesToolbarDropIndicatorHolder" align="center">
+            <hbox id="PlacesToolbarDropIndicatorHolder" align="center" collapsed="true">
               <image id="PlacesToolbarDropIndicator"
                      mousethrough="always"
                      collapsed="true"/>
             </hbox>
             <scrollbox orient="horizontal"
                        id="PlacesToolbarItems"
                        flex="1"/>
             <toolbarbutton type="menu"
--- a/browser/components/places/content/browserPlacesViews.js
+++ b/browser/components/places/content/browserPlacesViews.js
@@ -1570,16 +1570,17 @@ PlacesToolbar.prototype = {
         this._overFolder.elt.setAttribute("dragover", "true");
 
       this._dropIndicator.collapsed = true;
     }
     else {
       // Dragging over a normal toolbarbutton,
       // show indicator bar and move it to the appropriate drop point.
       let ind = this._dropIndicator;
+      ind.parentNode.collapsed = false;
       let halfInd = ind.clientWidth / 2;
       let translateX;
       if (this.isRTL) {
         halfInd = Math.ceil(halfInd);
         translateX = 0 - this._rootElt.getBoundingClientRect().right - halfInd;
         if (this._rootElt.firstChild) {
           if (dropPoint.beforeIndex == -1)
             translateX += this._rootElt.lastChild.getBoundingClientRect().left;