Bug 1136231 - Unify Reader View type options to be Sans-Serif on Left, Serif on Right. r=bnicholson a=readinglist
authorMargaret Leibovic <margaret.leibovic@gmail.com>
Tue, 24 Feb 2015 09:53:48 -0800
changeset 247895 fa8645257f11179cf987bf2b63e9cdece126be93
parent 247894 10dec7965ec8d7a7c4136c9bc7a6ee267daacb2a
child 247896 d0eef186dc22c8527454d41f17d1c166afbf2c9d
push id7708
push usermleibovic@mozilla.com
push dateWed, 04 Mar 2015 20:33:34 +0000
treeherdermozilla-aurora@9923b668bf68 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbnicholson, readinglist
bugs1136231
milestone38.0a2
Bug 1136231 - Unify Reader View type options to be Sans-Serif on Left, Serif on Right. r=bnicholson a=readinglist
toolkit/components/reader/AboutReader.jsm
--- a/toolkit/components/reader/AboutReader.jsm
+++ b/toolkit/components/reader/AboutReader.jsm
@@ -70,24 +70,24 @@ let AboutReader = function(mm, win) {
 
   let colorScheme = Services.prefs.getCharPref("reader.color_scheme");
   this._setupSegmentedButton("color-scheme-buttons", colorSchemeOptions, colorScheme, this._setColorSchemePref.bind(this));
   this._setColorSchemePref(colorScheme);
 
   let fontTypeSample = gStrings.GetStringFromName("aboutReader.fontTypeSample");
   let fontTypeOptions = [
     { name: fontTypeSample,
-      description: gStrings.GetStringFromName("aboutReader.fontType.serif"),
-      value: "serif",
-      linkClass: "serif" },
-    { name: fontTypeSample,
       description: gStrings.GetStringFromName("aboutReader.fontType.sans-serif"),
       value: "sans-serif",
       linkClass: "sans-serif"
     },
+    { name: fontTypeSample,
+      description: gStrings.GetStringFromName("aboutReader.fontType.serif"),
+      value: "serif",
+      linkClass: "serif" },
   ];
 
   let fontType = Services.prefs.getCharPref("reader.font_type");
   this._setupSegmentedButton("font-type-buttons", fontTypeOptions, fontType, this._setFontType.bind(this));
   this._setFontType(fontType);
 
   let fontSizeSample = gStrings.GetStringFromName("aboutReader.fontSizeSample");
   let fontSizeOptions = [