Bug 1289001 - Remove the MOZ_NORETURN hint from CrashWithReason. r=valentin, a=bustage
authorRyan VanderMeulen <ryanvm@gmail.com>
Mon, 21 Nov 2016 12:38:25 -0500
changeset 349179 f7e648e838578f2095f606602202117f0645ed04
parent 349178 5e14c40ee3b9d104b1cbe46183663fc31ec7d390
child 349180 706ad7566a0838290157ad85b7458fda875190e2
push id10326
push userryanvm@gmail.com
push dateMon, 21 Nov 2016 18:17:37 +0000
treeherdermozilla-aurora@f7e648e83857 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersvalentin, bustage
bugs1289001
milestone52.0a2
Bug 1289001 - Remove the MOZ_NORETURN hint from CrashWithReason. r=valentin, a=bustage
netwerk/ipc/NeckoParent.cpp
--- a/netwerk/ipc/NeckoParent.cpp
+++ b/netwerk/ipc/NeckoParent.cpp
@@ -139,17 +139,17 @@ GetRequestingPrincipal(const FTPChannelC
 
   const FTPChannelOpenArgs& args = aArgs.get_FTPChannelOpenArgs();
   return GetRequestingPrincipal(args.loadInfo());
 }
 
 // Bug 1289001 - If GetValidatedAppInfo returns an error string, that usually
 // leads to a content crash with very little info about the cause.
 // We prefer to crash on the parent, so we get the reason in the crash report.
-static MOZ_NORETURN MOZ_COLD
+static MOZ_COLD
 void CrashWithReason(const char * reason)
 {
 #ifndef RELEASE_OR_BETA
   MOZ_CRASH_ANNOTATE(reason);
   MOZ_REALLY_CRASH();
 #endif
 }