Bug 1278725 - Restore original "up" arrow scaling. r=liuche, a=gchang
authorAndrzej Hunt <ahunt@mozilla.com>
Thu, 09 Jun 2016 10:32:24 -0700
changeset 325426 eaf5b9ddb33ff66c6bbac6f56bc843cef293cf3b
parent 325425 f3e298bcd505bd69c8302d3bbb9e4ed4d5c1988d
child 325427 c5e185e1b58c4162e3bdec04d603c2d9171a425e
push id9785
push usercbook@mozilla.com
push dateThu, 14 Jul 2016 10:36:50 +0000
treeherdermozilla-aurora@3ad93af112af [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersliuche, gchang
bugs1278725
milestone49.0a2
Bug 1278725 - Restore original "up" arrow scaling. r=liuche, a=gchang Before introducing the folder count, the bookmark folder icon was set as the drawable on a TextView. This actually resulted in scaling that doesn't preserve the aspect ratio. To reproduce this in the new ImageView (added when we switched to a two-line folder layout), we simply need to set the icon size explicitly and scale to fit the whole area (as opposed to setting two constraints and fitting while preserving aspect ratio). The folder/reading-list icons are unaffected as they already have the expected aspect-ratio, the back-arrow is now scaled as expected. MozReview-Commit-ID: Fl5JY3Lznau
mobile/android/base/resources/layout/two_line_folder_row.xml
--- a/mobile/android/base/resources/layout/two_line_folder_row.xml
+++ b/mobile/android/base/resources/layout/two_line_folder_row.xml
@@ -6,18 +6,18 @@
 <merge xmlns:android="http://schemas.android.com/apk/res/android"
        xmlns:tools="http://schemas.android.com/tools"
        xmlns:gecko="http://schemas.android.com/apk/res-auto"
        tools:context=".BrowserApp">
 
     <ImageView android:id="@+id/icon"
                android:src="@drawable/folder_closed"
                android:layout_width="24dp"
-               android:layout_height="24dp"
-               android:scaleType="fitCenter"
+               android:layout_height="18dp"
+               android:scaleType="fitXY"
                android:layout_margin="20dp"/>
 
     <LinearLayout android:layout_width="0dp"
                   android:layout_height="wrap_content"
                   android:layout_weight="1"
                   android:layout_gravity="center_vertical"
                   android:paddingRight="10dp"
                   android:orientation="vertical">