Try backing out bug 792689 because it's the only non-merge cset in the MaxHeap regression range for both m-i and m-c.
authorKyle Huey <khuey@kylehuey.com>
Thu, 20 Sep 2012 12:42:13 -0700
changeset 111257 dd72607cee2f5cc820f71aeedd9976b2af8943df
parent 111256 b68455ccdd9a5b87035b71a64a653e307fb5b372
child 111258 8d579bf6e2de0c14846365e8e702080ae9ce4acf
push id2248
push userakeybl@mozilla.com
push dateMon, 08 Oct 2012 19:23:44 +0000
treeherdermozilla-aurora@118a3b748323 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs792689
milestone18.0a1
Try backing out bug 792689 because it's the only non-merge cset in the MaxHeap regression range for both m-i and m-c.
mfbt/Likely.h
--- a/mfbt/Likely.h
+++ b/mfbt/Likely.h
@@ -7,16 +7,16 @@
  * MOZ_LIKELY and MOZ_UNLIKELY macros to hint to the compiler how a
  * boolean predicate should be branch-predicted.
  */
 
 #ifndef mozilla_Likely_h_
 #define mozilla_Likely_h_
 
 #if defined(__clang__) || (defined(__GNUC__) && (__GNUC__ > 2))
-#  define MOZ_LIKELY(x)   (__builtin_expect(!!(x), 1))
-#  define MOZ_UNLIKELY(x) (__builtin_expect(!!(x), 0))
+#  define MOZ_LIKELY(x)   (__builtin_expect((x), 1))
+#  define MOZ_UNLIKELY(x) (__builtin_expect((x), 0))
 #else
-#  define MOZ_LIKELY(x)   (!!(x))
-#  define MOZ_UNLIKELY(x) (!!(x))
+#  define MOZ_LIKELY(x)   (x)
+#  define MOZ_UNLIKELY(x) (x)
 #endif
 
 #endif /* mozilla_Likely_h_ */