Bug 1278505 - Remove unneeded NS_NOTREACHED from DeallocPPrintProgressDialogChild(). r=mconley
authorTing-Yu Chou <janus926@gmail.com>
Fri, 22 Jul 2016 09:35:22 +0800
changeset 331748 da083c6367526ab8d30d1b07b94b2c56b77d7831
parent 331747 0d7f83477045aedfd34ba896c17dac918e24cb35
child 331749 0474eda33487858d28b551875543914695d431c2
push id9858
push userjlund@mozilla.com
push dateMon, 01 Aug 2016 14:37:10 +0000
treeherdermozilla-aurora@203106ef6cb6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmconley
bugs1278505
milestone50.0a1
Bug 1278505 - Remove unneeded NS_NOTREACHED from DeallocPPrintProgressDialogChild(). r=mconley MozReview-Commit-ID: 7WvZM390h8W
embedding/components/printingui/ipc/nsPrintingProxy.cpp
--- a/embedding/components/printingui/ipc/nsPrintingProxy.cpp
+++ b/embedding/components/printingui/ipc/nsPrintingProxy.cpp
@@ -221,21 +221,19 @@ nsPrintingProxy::AllocPPrintProgressDial
   NS_NOTREACHED("Allocator for PPrintProgressDialogChild should not be "
                 "called on nsPrintingProxy.");
   return nullptr;
 }
 
 bool
 nsPrintingProxy::DeallocPPrintProgressDialogChild(PPrintProgressDialogChild* aActor)
 {
-  // The parent process will never initiate the PPrintProgressDialog
-  // protocol connection, so no need to provide an deallocator here.
-  NS_NOTREACHED("Deallocator for PPrintProgressDialogChild should not be "
-                "called on nsPrintingProxy.");
-  return false;
+  // The PrintProgressDialogChild implements refcounting, and
+  // will take itself out.
+  return true;
 }
 
 PPrintSettingsDialogChild*
 nsPrintingProxy::AllocPPrintSettingsDialogChild()
 {
   // The parent process will never initiate the PPrintSettingsDialog
   // protocol connection, so no need to provide an allocator here.
   NS_NOTREACHED("Allocator for PPrintSettingsDialogChild should not be "