Backed out changeset d89783fd81e5 (bug 1315657)
authorSebastian Hengst <archaeopteryx@coole-files.de>
Mon, 07 Nov 2016 17:53:10 +0100
changeset 348109 d5de5a3e2d828782458ebd0c8b28671ba128418c
parent 348108 a2484fe7cfc43bdcc2f0ea1cc2f3ff988cdae262
child 348110 9ee234b75a3ee9ec75bd6209e3bafe6b41bff1e2
push id10298
push userraliiev@mozilla.com
push dateMon, 14 Nov 2016 12:33:03 +0000
treeherdermozilla-aurora@7e29173b1641 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1315657
milestone52.0a1
backs outd89783fd81e527b8189d59a2c49ee745ef832aec
Backed out changeset d89783fd81e5 (bug 1315657)
testing/mozharness/mozharness/mozilla/testing/testbase.py
--- a/testing/mozharness/mozharness/mozilla/testing/testbase.py
+++ b/testing/mozharness/mozharness/mozilla/testing/testbase.py
@@ -8,17 +8,16 @@
 import copy
 import os
 import platform
 import pprint
 import re
 import urllib2
 import json
 import socket
-import errno
 
 from mozharness.base.errors import BaseErrorList
 from mozharness.base.log import FATAL, WARNING
 from mozharness.base.python import (
     ResourceMonitoringMixin,
     VirtualenvMixin,
     virtualenv_config_options,
 )
@@ -753,25 +752,17 @@ Did you run with --create-virtualenv? Is
                     cache=c.get('tooltool_cache')
                 )
             except KeyError:
                 self.error('missing a required key.')
 
             abs_minidump_path = os.path.join(dirs['abs_work_dir'],
                                              minidump_stackwalk_path)
             if os.path.exists(abs_minidump_path):
-                try:
-                    self.chmod(abs_minidump_path, 0755)
-                except OSError as e:
-                    # docker image for Linux tests on Taskcluster already
-                    # ship minidump stackwalk. If mozharness finds it, it
-                    # won't have permission to modify bits. It is harmless,
-                    # however, because it already has executable permission.
-                    if e.errno != errno.EPERM:
-                        raise
+                self.chmod(abs_minidump_path, 0755)
                 self.minidump_stackwalk_path = abs_minidump_path
             else:
                 self.warning("minidump stackwalk path was given but couldn't be found. "
                              "Tried looking in '%s'" % abs_minidump_path)
                 # don't burn the job but we should at least turn them orange so it is caught
                 self.buildbot_status(TBPL_WARNING, WARNING)
 
         return self.minidump_stackwalk_path