Bug 1113723: play a sound when someone joins a room. r=MattN a=lsblakk
authorMike de Boer <mdeboer@mozilla.com>
Tue, 23 Dec 2014 17:39:32 +0100
changeset 234508 d21cf86760b06279765f924cc908b3683af66b82
parent 234507 1fd71b58a91b6f0ea1cda5c678d2e064ccc2c1d8
child 234509 8d887c4a25f87a9dccbfefc9b1a3723d41518f40
push id7407
push userrjesup@wgate.com
push dateFri, 26 Dec 2014 16:27:15 +0000
treeherdermozilla-aurora@d21cf86760b0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersMattN, lsblakk
bugs1113723
milestone36.0a2
Bug 1113723: play a sound when someone joins a room. r=MattN a=lsblakk
browser/base/content/browser-loop.js
--- a/browser/base/content/browser-loop.js
+++ b/browser/base/content/browser-loop.js
@@ -232,18 +232,19 @@ XPCOMUtils.defineLazyModuleGetter(this, 
         body: options.message || ""
       };
       if (options.icon) {
         notificationOptions.icon = options.icon;
       }
       if (options.sound) {
         // This will not do anything, until bug bug 1105222 is resolved.
         notificationOptions.mozbehavior = {
-          soundFile: `chrome://browser/content/loop/shared/sounds/${options.sound}.ogg`
+          soundFile: ""
         };
+        this.playSound(options.sound);
       }
 
       let notification = new window.Notification(options.title, notificationOptions);
       notification.addEventListener("click", e => {
         if (window.closed) {
           return;
         }