Bug 1342306 (part 2a) - Fix a comment that part 2 made out-of-date. r=me.
authorNicholas Nethercote <nnethercote@mozilla.com>
Mon, 06 Mar 2017 12:53:37 +1100
changeset 375071 d01cc63b45043da203c2324c14658f8c5854156e
parent 375070 7c3ed29c6ffb3483b4ddf25a82183480bc013a9d
child 375072 86ba78dc87ce16041ea22671bfe7bc0fd3aa32d4
push id10863
push userjlorenzo@mozilla.com
push dateMon, 06 Mar 2017 23:02:23 +0000
treeherdermozilla-aurora@0931190cd725 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
Bug 1342306 (part 2a) - Fix a comment that part 2 made out-of-date. r=me. DONTBUILD because it's a comment-only change.
--- a/tools/profiler/public/PseudoStack.h
+++ b/tools/profiler/public/PseudoStack.h
@@ -415,18 +415,17 @@ private:
   // been previously observed. This is used for an optimization: in some cases,
   // when a thread is asleep, we duplicate the previous sample, which is
   // cheaper than taking a new sample.
   // mSleep is atomic because it is accessed from multiple threads.
   // - It is written only by this thread, via setSleeping() and setAwake().
-  // - It is read by the SamplerThread (on Win32 and Mac) or the SigprofSender
-  //   thread (on Linux and Android).
+  // - It is read by SamplerThread::Run().
   // There are two cases where racing between threads can cause an issue.
   // - If CanDuplicateLastSampleDueToSleep() returns false but that result is
   //   invalidated before being acted upon, we will take a full sample
   //   unnecessarily. This is additional work but won't cause any correctness
   //   issues. (In actual fact, this case is impossible. In order to go from
   //   CanDuplicateLastSampleDueToSleep() returning false to it returning true