Bug 459563 - Let <description> and <label> on OS X have the same margin as on Windows and Linux. r=gijs
☠☠ backed out by 9bd7e886acd3 ☠ ☠
authorDão Gottwald <dao@mozilla.com>
Wed, 27 May 2015 14:25:03 +0200
changeset 265522 cab24498e09595dcf086c93b6fd2ad21d189c30f
parent 265521 707f94ce1881bb69fdb03f53c08500eee0db97ca
child 265523 ef991e9a6395d08bd9064b7bf3b9de2db9b66e67
push id8157
push userjlund@mozilla.com
push dateMon, 29 Jun 2015 20:36:23 +0000
treeherdermozilla-aurora@d480e05bd276 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgijs
bugs459563
milestone41.0a1
Bug 459563 - Let <description> and <label> on OS X have the same margin as on Windows and Linux. r=gijs
browser/base/content/urlbarBindings.xml
browser/themes/linux/browser.css
browser/themes/osx/browser.css
browser/themes/windows/browser.css
toolkit/themes/osx/global/global.css
toolkit/themes/osx/global/notification.css
--- a/browser/base/content/urlbarBindings.xml
+++ b/browser/base/content/urlbarBindings.xml
@@ -2175,17 +2175,17 @@ file, You can obtain one at http://mozil
                   xbl:inherits="popupid">
                   &mixedContentBlocked2.message;
                 </xul:description>
                 <xul:description class="popup-notification-item-message"
                   xbl:inherits="popupid,mixedblockdisabled">
                   &mixedContentBlocked2.moreinfo;
                 </xul:description>
                 <xul:label anonid="mixedContent.helplink"
-                  class="text-link plain" href=""
+                  class="text-link" href=""
                   value="&mixedContentBlocked2.learnMore;"/>
               </xul:vbox>
               <xul:button
                 type="menu" label="&mixedContentBlocked2.options;"
                 sizetopopup="none">
                 <xul:menupopup>
                   <xul:menuitem anonid="mixedContentAction.unblock"
                     hidden="true" label="&mixedContentBlocked2.unblock.label;"
@@ -2213,17 +2213,17 @@ file, You can obtain one at http://mozil
                   xbl:inherits="popupid">
                   &trackingContentBlocked.message;
                 </xul:description>
                 <xul:description class="popup-notification-item-message"
                   xbl:inherits="popupid,trackingblockdisabled">
                   &trackingContentBlocked.moreinfo;
                 </xul:description>
                 <xul:label anonid="trackingContent.helplink"
-                  class="text-link plain" href=""
+                  class="text-link" href=""
                   value="&trackingContentBlocked.learnMore;"/>
               </xul:vbox>
               <xul:button
                 type="menu" label="&trackingContentBlocked.options;"
                 sizetopopup="none">
                 <xul:menupopup>
                   <xul:menuitem anonid="trackingContentAction.unblock"
                     hidden="true" label="&trackingContentBlocked.unblock2.label;"
--- a/browser/themes/linux/browser.css
+++ b/browser/themes/linux/browser.css
@@ -1914,20 +1914,16 @@ toolbarbutton.chevron > .toolbarbutton-i
   text-shadow: none;
   background-image: linear-gradient(#B4211B, #8A1915);
   border-radius: 1px;
   -moz-margin-end: 2px;
 }
 
 /* Social toolbar item */
 
-#social-undoactivation-button {
-  -moz-margin-start: 0; /* override default label margin to match description margin */
-}
-
 .social-activation-icon {
   width: auto;
   height: auto;
   max-height: 64px;
   max-width: 64px;
 }
 
 #social-activation-message {
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -3426,30 +3426,18 @@ notification[value="loop-sharing-notific
 }
 
 .popup-notification-body[popupid="addon-progress"],
 .popup-notification-body[popupid="addon-install-confirmation"] {
   width: 28em;
   max-width: 28em;
 }
 
-#addon-progress-notification-progresstext,
-#addon-progress-notification-progressmeter {
-  /* override default label margin to match description margin */
-  -moz-margin-start: 0;
-  -moz-margin-end: 0;
-}
-
 .addon-install-confirmation-name {
   font-weight: bold;
-  -moz-margin-start: 0 !important; /* override default label margin to match description margin */
-}
-
-#pointerLock-cancel {
-  margin: 0px;
 }
 
 /* Popup Buttons */
 #identity-popup-more-info-button {
   @hudButton@
   margin: 10px 0 0;
   min-height: 0px;
 }
@@ -3663,20 +3651,16 @@ notification[value="loop-sharing-notific
 #developer-toolbar-toolbox-button[error-count]:before {
   color: #FDF3DE;
   min-width: 16px;
   text-shadow: none;
   background-image: linear-gradient(#B4211B, #8A1915);
   border-radius: 1px;
 }
 
-#social-undoactivation-button {
-  -moz-margin-start: 0; /* override default label margin to match description margin */
-}
-
 .social-activation-icon {
   width: auto;
   height: auto;
   max-height: 64px;
   max-width: 64px;
 }
 
 #social-activation-message {
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -2561,20 +2561,16 @@ notification[value="loop-sharing-notific
   text-shadow: none;
   background-image: linear-gradient(#B4211B, #8A1915);
   border-radius: 1px;
   -moz-margin-end: 5px;
 }
 
 /* Social toolbar item */
 
-#social-undoactivation-button {
-  -moz-margin-start: 0; /* override default label margin to match description margin */
-}
-
 #socialActivatedNotification .popup-notification-button-container {
   margin-left: 6px;
 }
 
 .social-activation-icon {
   width: auto;
   height: auto;
   max-height: 64px;
--- a/toolkit/themes/osx/global/global.css
+++ b/toolkit/themes/osx/global/global.css
@@ -171,36 +171,35 @@ separator.groove[orient="vertical"] {
   margin: 0 !important;
   border: none;
   padding: 0;
 }
 
 description,
 label {
   cursor: default;
+  margin-top: 1px;
+  margin-bottom: 2px;
+  -moz-margin-start: 6px;
+  -moz-margin-end: 5px;
 }
 
-label {
-  margin: 2px 6px;
+description {
+  margin-bottom: 4px;
 }
 
 label[disabled="true"] {
   color: GrayText;
 }
 
 .tooltip-label {
   margin: 0;
 }
 
-description {
-  margin-bottom: 4px;
-}
-
 .header {
-  margin-bottom: 6px;
   font-weight: bold;
 }
 
 .monospace {
   font-family: monospace;
 }
 
 .indent {
--- a/toolkit/themes/osx/global/notification.css
+++ b/toolkit/themes/osx/global/notification.css
@@ -107,22 +107,20 @@ notification[type="info"]:not([value="tr
 
 .popup-notification-origin:not([value]),
 .popup-notification-learnmore-link:not([href]) {
   display: none;
 }
 
 .popup-notification-origin {
   margin-bottom: .3em !important;
-  -moz-margin-start: 0 !important; /* override default label margin to match description margin */
 }
 
 .popup-notification-learnmore-link {
   margin-top: .5em !important;
-  -moz-margin-start: 0 !important; /* override default label margin to match description margin */
 }
 
 .popup-notification-button-container {
   margin-top: 17px;
 }
 
 .popup-notification-menubutton {
   -moz-appearance: none;