Bug 1324661 part 2. Reenable various table reftests that were disabled before. They all seem to be passing, or at least failing for unrelated reasons, with the part 1 patch applied. r=bholley,emilio
authorBoris Zbarsky <bzbarsky@mit.edu>
Fri, 17 Feb 2017 15:06:14 -0500
changeset 372678 c69baa105d70a30dd408e4758a07c4bfc83e8284
parent 372677 a300522006bc5e93e841e0132fa940874180afcd
child 372679 31fedf253dbf78d6ce4042d3b65f80285cf5253d
push id10863
push userjlorenzo@mozilla.com
push dateMon, 06 Mar 2017 23:02:23 +0000
treeherdermozilla-aurora@0931190cd725 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbholley, emilio
bugs1324661
milestone54.0a1
Bug 1324661 part 2. Reenable various table reftests that were disabled before. They all seem to be passing, or at least failing for unrelated reasons, with the part 1 patch applied. r=bholley,emilio MozReview-Commit-ID: 24VFWXJJE4E
layout/reftests/bugs/reftest-stylo.list
layout/reftests/table-background/reftest-stylo.list
layout/reftests/text/reftest-stylo.list
layout/reftests/writing-mode/tables/reftest-stylo.list
--- a/layout/reftests/bugs/reftest-stylo.list
+++ b/layout/reftests/bugs/reftest-stylo.list
@@ -769,19 +769,19 @@ fails == 386470-1b.html 386470-1b.html
 == 387876-3b.html 387876-3b.html
 == 388026-1.html 388026-1.html
 fails == 389074-1.html 389074-1.html
 # == 389224-1.html 389224-1.html
 # == 389224-2.html 389224-2.html
 fails == 389468-1.html 389468-1.html
 == 389623-1.html 389623-1.html
 == 389636-1.html 389636-1.html
-# == 389924-1a.html 389924-1a.html
+== 389924-1a.html 389924-1a.html
 == 389924-1b.html 389924-1b.html
-# == 389924-1a.html 389924-1a.html
+== 389924-1a.html 389924-1a.html
 == 390318-1a.html 390318-1a.html
 == 390318-1b.html 390318-1b.html
 == 390318-1c.html 390318-1c.html
 == 390318-1d.html 390318-1d.html
 == 390318-1e.html 390318-1e.html
 == 390318-1f.html 390318-1f.html
 skip-if(!winWidget) == 391045.html 391045.html
 fails == 391140-1.html 391140-1.html
@@ -873,17 +873,17 @@ fails random == 403134-1.html 403134-1.h
 fails == 403249-1a.html 403249-1a.html
 fails == 403249-1b.html 403249-1b.html
 fails == 403249-2a.html 403249-2a.html
 fails == 403249-2b.html 403249-2b.html
 == 403328-1.html 403328-1.html
 == 403426-1.html 403426-1.html
 fails == 403455-1.html 403455-1.html
 == 403505-1.xml 403505-1.xml
-#== 403519-1.html 403519-1.html
+fails == 403519-1.html 403519-1.html
 == 403519-2.html 403519-2.html
 fails == 403656-1.html 403656-1.html
 fails == 403656-2.html 403656-2.html
 fails == 403656-3.html 403656-3.html
 fails == 403656-4.html 403656-4.html
 fails == 403656-5.html 403656-5.html
 #== 403657-1.html 403657-1.html
 fails == 403733-1.html 403733-1.html
--- a/layout/reftests/table-background/reftest-stylo.list
+++ b/layout/reftests/table-background/reftest-stylo.list
@@ -39,25 +39,25 @@ fails == backgr_simple-table.html backgr
 == border-collapse-table-column-group.html border-collapse-table-column-group.html
 == border-collapse-table-column.html border-collapse-table-column.html
 == border-collapse-table-row-group.html border-collapse-table-row-group.html
 == border-collapse-table-row.html border-collapse-table-row.html
 == border-collapse-table.html border-collapse-table.html
 == border-collapse-opacity-table-cell.html border-collapse-opacity-table-cell.html
 == border-collapse-opacity-table-column-group.html border-collapse-opacity-table-column-group.html
 == border-collapse-opacity-table-column.html border-collapse-opacity-table-column.html
-# fuzzy-if(d2d,1,16359) fuzzy-if(skiaContent,1,17000) == border-collapse-opacity-table-row-group.html border-collapse-opacity-table-row-group.html
+fuzzy-if(d2d,1,16359) fuzzy-if(skiaContent,1,17000) == border-collapse-opacity-table-row-group.html border-collapse-opacity-table-row-group.html
 fuzzy-if(d2d,1,5453) fuzzy-if(skiaContent,1,11000) == border-collapse-opacity-table-row.html border-collapse-opacity-table-row.html
-# fuzzy-if(stylo||d2d||skiaContent,1,60000) == border-collapse-opacity-table.html border-collapse-opacity-table.html
+fuzzy-if(stylo||d2d||skiaContent,1,60000) == border-collapse-opacity-table.html border-collapse-opacity-table.html
 == border-separate-opacity-table-cell.html border-separate-opacity-table-cell.html
 == border-separate-opacity-table-column-group.html border-separate-opacity-table-column-group.html
 == border-separate-opacity-table-column.html border-separate-opacity-table-column.html
 fuzzy-if(d2d,1,37170) fuzzy-if(skiaContent,1,38000) == border-separate-opacity-table-row-group.html border-separate-opacity-table-row-group.html
 fuzzy-if(d2d,1,12390) fuzzy-if(skiaContent,1,13000) == border-separate-opacity-table-row.html border-separate-opacity-table-row.html
-# fuzzy-if(stylo||d2d||skiaContent,1,95000) == border-separate-opacity-table.html border-separate-opacity-table.html
-# == scrollable-rowgroup-collapse-background.html scrollable-rowgroup-collapse-background.html
+fuzzy-if(stylo||d2d||skiaContent,1,95000) == border-separate-opacity-table.html border-separate-opacity-table.html
+== scrollable-rowgroup-collapse-background.html scrollable-rowgroup-collapse-background.html
 == scrollable-rowgroup-collapse-border.html scrollable-rowgroup-collapse-border.html
-# == scrollable-rowgroup-separate-background.html scrollable-rowgroup-separate-background.html
+== scrollable-rowgroup-separate-background.html scrollable-rowgroup-separate-background.html
 == scrollable-rowgroup-separate-border.html scrollable-rowgroup-separate-border.html
 == empty-cells-default-1.html empty-cells-default-1.html
 == empty-cells-default-2.html empty-cells-default-2.html
 == table-row-opacity-dynamic-1.html table-row-opacity-dynamic-1.html
-# == table-row-opacity-dynamic-2.html table-row-opacity-dynamic-2.html
+== table-row-opacity-dynamic-2.html table-row-opacity-dynamic-2.html
--- a/layout/reftests/text/reftest-stylo.list
+++ b/layout/reftests/text/reftest-stylo.list
@@ -38,18 +38,18 @@ fails == pre-space-1.html pre-space-1.ht
 fails == pre-wrap-1.html pre-wrap-1.html
 == soft-hyphens-1a.html soft-hyphens-1a.html
 == soft-hyphens-1b.html soft-hyphens-1b.html
 == soft-hyphens-1c.html soft-hyphens-1c.html
 == soft-hyphens-break-word-1a.html soft-hyphens-break-word-1a.html
 == soft-hyphens-break-word-1b.html soft-hyphens-break-word-1b.html
 == soft-hyphens-break-word-1c.html soft-hyphens-break-word-1c.html
 # Tests for soft hyphens in table cells, bug 418975
-# == soft-hyphen-in-table-1.html soft-hyphen-in-table-1.html
-# == soft-hyphen-in-table-1.html soft-hyphen-in-table-1.html
+== soft-hyphen-in-table-1.html soft-hyphen-in-table-1.html
+== soft-hyphen-in-table-1.html soft-hyphen-in-table-1.html
 == soft-hyphen-in-table-2.html soft-hyphen-in-table-2.html
 # Cairo's FreeType and GDI backends snap glyphs to pixels, while Mac (usually),
 # D2D, and Skia have subpixel positioning.  The tests for pixel-snapping assume that
 # 1 CSS pixel == 1 device device
 fails-if(Android) skip-if(d2d||cocoaWidget||skiaContent) == subpixel-glyphs-x-1a.html subpixel-glyphs-x-1a.html
 # Platforms with subpixel positioning already have inconsistent glyphs by
 # design, but that is considered more tolerable because they are subpixel
 # inconsistencies.  On those platforms we just test that glyph positions are
--- a/layout/reftests/writing-mode/tables/reftest-stylo.list
+++ b/layout/reftests/writing-mode/tables/reftest-stylo.list
@@ -7,67 +7,67 @@
 == vertical-table-rowspan-2.html vertical-table-rowspan-2.html
 == vertical-table-colspan-1.html vertical-table-colspan-1.html
 == vertical-table-colspan-2.html vertical-table-colspan-2.html
 == vertical-table-specified-width-1.html vertical-table-specified-width-1.html
 asserts(1-2) == vertical-table-specified-width-2.html vertical-table-specified-width-2.html
 == vertical-border-collapse-1.html vertical-border-collapse-1.html
 == vertical-border-collapse-2.html vertical-border-collapse-2.html
 
-# == fixed-table-layout-002-vlr.html fixed-table-layout-002-vlr.html
-# == fixed-table-layout-003-vlr.html fixed-table-layout-003-vlr.html
-# == fixed-table-layout-004-vlr.html fixed-table-layout-004-vlr.html
-# == fixed-table-layout-005-vlr.html fixed-table-layout-005-vlr.html
-# == fixed-table-layout-006-vlr.html fixed-table-layout-006-vlr.html
-# == fixed-table-layout-007-vlr.html fixed-table-layout-007-vlr.html
-# == fixed-table-layout-009-vlr.html fixed-table-layout-009-vlr.html
-# == fixed-table-layout-010-vlr.html fixed-table-layout-010-vlr.html
-# == fixed-table-layout-012-vlr.html fixed-table-layout-012-vlr.html
-# == fixed-table-layout-013-vlr.html fixed-table-layout-013-vlr.html
-# == fixed-table-layout-014-vlr.html fixed-table-layout-014-vlr.html
+== fixed-table-layout-002-vlr.html fixed-table-layout-002-vlr.html
+== fixed-table-layout-003-vlr.html fixed-table-layout-003-vlr.html
+== fixed-table-layout-004-vlr.html fixed-table-layout-004-vlr.html
+== fixed-table-layout-005-vlr.html fixed-table-layout-005-vlr.html
+== fixed-table-layout-006-vlr.html fixed-table-layout-006-vlr.html
+== fixed-table-layout-007-vlr.html fixed-table-layout-007-vlr.html
+== fixed-table-layout-009-vlr.html fixed-table-layout-009-vlr.html
+== fixed-table-layout-010-vlr.html fixed-table-layout-010-vlr.html
+== fixed-table-layout-012-vlr.html fixed-table-layout-012-vlr.html
+== fixed-table-layout-013-vlr.html fixed-table-layout-013-vlr.html
+== fixed-table-layout-014-vlr.html fixed-table-layout-014-vlr.html
 == fixed-table-layout-015-vlr.html fixed-table-layout-015-vlr.html
-# == fixed-table-layout-016-vlr.html fixed-table-layout-016-vlr.html
-# == fixed-table-layout-017-vlr.html fixed-table-layout-017-vlr.html
-# == fixed-table-layout-018-vlr.html fixed-table-layout-018-vlr.html
-# == fixed-table-layout-021-vlr.html fixed-table-layout-021-vlr.html
-# == fixed-table-layout-022-vlr.html fixed-table-layout-022-vlr.html
-# == fixed-table-layout-023-vlr.html fixed-table-layout-023-vlr.html
-# == fixed-table-layout-025-vlr.html fixed-table-layout-025-vlr.html
-# == fixed-table-layout-026-vlr.html fixed-table-layout-026-vlr.html
-# == fixed-table-layout-027-vlr.html fixed-table-layout-027-vlr.html
-# == fixed-table-layout-028-vlr.html fixed-table-layout-028-vlr.html
-# == fixed-table-layout-029-vlr.html fixed-table-layout-029-vlr.html
-# == fixed-table-layout-030-vlr.html fixed-table-layout-030-vlr.html
-# == fixed-table-layout-031-vlr.html fixed-table-layout-031-vlr.html
+== fixed-table-layout-016-vlr.html fixed-table-layout-016-vlr.html
+== fixed-table-layout-017-vlr.html fixed-table-layout-017-vlr.html
+== fixed-table-layout-018-vlr.html fixed-table-layout-018-vlr.html
+== fixed-table-layout-021-vlr.html fixed-table-layout-021-vlr.html
+== fixed-table-layout-022-vlr.html fixed-table-layout-022-vlr.html
+== fixed-table-layout-023-vlr.html fixed-table-layout-023-vlr.html
+== fixed-table-layout-025-vlr.html fixed-table-layout-025-vlr.html
+== fixed-table-layout-026-vlr.html fixed-table-layout-026-vlr.html
+== fixed-table-layout-027-vlr.html fixed-table-layout-027-vlr.html
+== fixed-table-layout-028-vlr.html fixed-table-layout-028-vlr.html
+== fixed-table-layout-029-vlr.html fixed-table-layout-029-vlr.html
+== fixed-table-layout-030-vlr.html fixed-table-layout-030-vlr.html
+== fixed-table-layout-031-vlr.html fixed-table-layout-031-vlr.html
 
-# == fixed-table-layout-002-vrl.html fixed-table-layout-002-vrl.html
-# == fixed-table-layout-003-vrl.html fixed-table-layout-003-vrl.html
-# == fixed-table-layout-004-vrl.html fixed-table-layout-004-vrl.html
-# == fixed-table-layout-005-vrl.html fixed-table-layout-005-vrl.html
-# == fixed-table-layout-006-vrl.html fixed-table-layout-006-vrl.html
-# == fixed-table-layout-007-vrl.html fixed-table-layout-007-vrl.html
-# == fixed-table-layout-009-vrl.html fixed-table-layout-009-vrl.html
-# == fixed-table-layout-010-vrl.html fixed-table-layout-010-vrl.html
-# == fixed-table-layout-012-vrl.html fixed-table-layout-012-vrl.html
-# == fixed-table-layout-013-vrl.html fixed-table-layout-013-vrl.html
-# == fixed-table-layout-014-vrl.html fixed-table-layout-014-vrl.html
-# == fixed-table-layout-015-vrl.html fixed-table-layout-015-vrl.html
-# == fixed-table-layout-016-vrl.html fixed-table-layout-016-vrl.html
-# == fixed-table-layout-017-vrl.html fixed-table-layout-017-vrl.html
-# == fixed-table-layout-018-vrl.html fixed-table-layout-018-vrl.html
-# == fixed-table-layout-021-vrl.html fixed-table-layout-021-vrl.html
-# == fixed-table-layout-022-vrl.html fixed-table-layout-022-vrl.html
-# == fixed-table-layout-023-vrl.html fixed-table-layout-023-vrl.html
+== fixed-table-layout-002-vrl.html fixed-table-layout-002-vrl.html
+== fixed-table-layout-003-vrl.html fixed-table-layout-003-vrl.html
+== fixed-table-layout-004-vrl.html fixed-table-layout-004-vrl.html
+== fixed-table-layout-005-vrl.html fixed-table-layout-005-vrl.html
+== fixed-table-layout-006-vrl.html fixed-table-layout-006-vrl.html
+== fixed-table-layout-007-vrl.html fixed-table-layout-007-vrl.html
+== fixed-table-layout-009-vrl.html fixed-table-layout-009-vrl.html
+== fixed-table-layout-010-vrl.html fixed-table-layout-010-vrl.html
+== fixed-table-layout-012-vrl.html fixed-table-layout-012-vrl.html
+== fixed-table-layout-013-vrl.html fixed-table-layout-013-vrl.html
+== fixed-table-layout-014-vrl.html fixed-table-layout-014-vrl.html
+== fixed-table-layout-015-vrl.html fixed-table-layout-015-vrl.html
+== fixed-table-layout-016-vrl.html fixed-table-layout-016-vrl.html
+== fixed-table-layout-017-vrl.html fixed-table-layout-017-vrl.html
+== fixed-table-layout-018-vrl.html fixed-table-layout-018-vrl.html
+== fixed-table-layout-021-vrl.html fixed-table-layout-021-vrl.html
+== fixed-table-layout-022-vrl.html fixed-table-layout-022-vrl.html
+== fixed-table-layout-023-vrl.html fixed-table-layout-023-vrl.html
 == fixed-table-layout-025-vrl.html fixed-table-layout-025-vrl.html
-# == fixed-table-layout-026-vrl.html fixed-table-layout-026-vrl.html
-# == fixed-table-layout-027-vrl.html fixed-table-layout-027-vrl.html
-# == fixed-table-layout-028-vrl.html fixed-table-layout-028-vrl.html
-# == fixed-table-layout-029-vrl.html fixed-table-layout-029-vrl.html
-# == fixed-table-layout-030-vrl.html fixed-table-layout-030-vrl.html
-# == fixed-table-layout-031-vrl.html fixed-table-layout-031-vrl.html
+== fixed-table-layout-026-vrl.html fixed-table-layout-026-vrl.html
+== fixed-table-layout-027-vrl.html fixed-table-layout-027-vrl.html
+== fixed-table-layout-028-vrl.html fixed-table-layout-028-vrl.html
+== fixed-table-layout-029-vrl.html fixed-table-layout-029-vrl.html
+== fixed-table-layout-030-vrl.html fixed-table-layout-030-vrl.html
+== fixed-table-layout-031-vrl.html fixed-table-layout-031-vrl.html
 
 # HTTP(../..) == s72-border-spacing-002.xht s72-border-spacing-002.xht
 # HTTP(../..) == s72-border-spacing-003.xht s72-border-spacing-003.xht
 # HTTP(../..) == s72-border-spacing-004.xht s72-border-spacing-004.xht
 # HTTP(../..) == s72-border-spacing-005.xht s72-border-spacing-005.xht
 fails == wm-row-progression-002.xht wm-row-progression-002.xht
 fails == wm-row-progression-003.xht wm-row-progression-003.xht
 fails == wm-row-progression-004.xht wm-row-progression-004.xht