Properly propagate return values in LOCALINC/ARGINC. no bug, r=dvander
authorAndrew Drake <adrake@adrake.org>
Fri, 12 Aug 2011 13:31:16 -0700
changeset 108717 c34b8613959d3bdb6875035e311af549ba453432
parent 108716 0988a70d95be51559fb2556af191efc93b404197
child 108718 e8ce2d102fdaacf14c0418bac846494f846807d0
push id2248
push userakeybl@mozilla.com
push dateMon, 08 Oct 2012 19:23:44 +0000
treeherdermozilla-aurora@118a3b748323 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdvander
milestone8.0a1
Properly propagate return values in LOCALINC/ARGINC. no bug, r=dvander
js/src/ion/IonBuilder.cpp
--- a/js/src/ion/IonBuilder.cpp
+++ b/js/src/ion/IonBuilder.cpp
@@ -1563,17 +1563,17 @@ IonBuilder::jsop_localinc(JSOp op)
     current->pushLocal(GET_SLOTNO(pc));
 
     if (!pushConstant(Int32Value(amt)))
         return false;
 
     if (!jsop_binary(JSOP_ADD))
         return false;
 
-    if (current->setLocal(GET_SLOTNO(pc)))
+    if (!current->setLocal(GET_SLOTNO(pc)))
         return false;
 
     if (post_incr)
         current->pop();
 
     return true;
 }
 
@@ -1589,17 +1589,17 @@ IonBuilder::jsop_arginc(JSOp op)
     current->pushArg(GET_SLOTNO(pc));
 
     if (!pushConstant(Int32Value(amt)))
         return false;
 
     if (!jsop_binary(JSOP_ADD))
         return false;
 
-    if (current->setArg(GET_SLOTNO(pc)))
+    if (!current->setArg(GET_SLOTNO(pc)))
         return false;
 
     if (post_incr)
         current->pop();
 
     return true;
 }