Bug 1246904 - Change devtools eslint warnings to be errors instead; r=jryans
authorPatrick Brosset <pbrosset@mozilla.com>
Thu, 25 Feb 2016 17:45:57 +0100
changeset 308706 c09bd7a978cf5c87834644d01721ec438d87976a
parent 308705 6fe18594d84e5d68012d6d6ed5adc994fb6829f3
child 308707 daf17f7cf7f61da7e44ebd2814b01fb5eb4cf036
push id9214
push userraliiev@mozilla.com
push dateMon, 07 Mar 2016 14:25:21 +0000
treeherdermozilla-aurora@8849dd1a4a79 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjryans
bugs1246904
milestone47.0a1
Bug 1246904 - Change devtools eslint warnings to be errors instead; r=jryans MozReview-Commit-ID: BBE2kZKF1cY
devtools/.eslintrc
--- a/devtools/.eslintrc
+++ b/devtools/.eslintrc
@@ -30,40 +30,40 @@
     "mozilla/reject-importGlobalProperties": 1,
     "mozilla/var-only-at-top-level": 1,
 
     // Disallow using variables outside the blocks they are defined (especially
     // since only let and const are used, see "no-var").
     "block-scoped-var": 2,
     // Enforce one true brace style (opening brace on the same line) and avoid
     // start and end braces on the same line.
-    "brace-style": [1, "1tbs", {"allowSingleLine": false}],
+    "brace-style": [2, "1tbs", {"allowSingleLine": false}],
     // Require camel case names
-    "camelcase": 1,
+    "camelcase": 2,
     // Allow trailing commas for easy list extension.  Having them does not
     // impair readability, but also not required either.
     "comma-dangle": 0,
     // Enforce spacing before and after comma
-    "comma-spacing": [1, {"before": false, "after": true}],
+    "comma-spacing": [2, {"before": false, "after": true}],
     // Enforce one true comma style.
-    "comma-style": [1, "last"],
+    "comma-style": [2, "last"],
     // Warn about cyclomatic complexity in functions.
-    "complexity": 1,
+    "complexity": 2,
     // Require return statements to either always or never specify values.
     "consistent-return": 2,
     // Don't warn for inconsistent naming when capturing this (not so important
     // with auto-binding fat arrow functions).
     "consistent-this": 0,
     // Enforce curly brace conventions for all control statements.
     "curly": 2,
     // Don't require a default case in switch statements. Avoid being forced to
     // add a bogus default when you know all possible cases are handled.
     "default-case": 0,
     // Enforce dots on the next line with property name.
-    "dot-location": [1, "property"],
+    "dot-location": [2, "property"],
     // Encourage the use of dot notation whenever possible.
     "dot-notation": 2,
     // Enforce newline at the end of file, with no multiple empty lines.
     "eol-last": 2,
     // Allow using == instead of ===, in the interest of landing something since
     // the devtools codebase is split on convention here.
     "eqeqeq": 0,
     // Don't require function expressions to have a name.
@@ -72,25 +72,25 @@
     // the enclosing function name, and worst case you have a line number that
     // you can just look up.
     "func-names": 0,
     // Allow use of function declarations and expressions.
     "func-style": 0,
     // Deprecated, will be removed in 1.0.
     "generator-star": 0,
     // Enforce the spacing around the * in generator functions.
-    "generator-star-spacing": [1, "after"],
+    "generator-star-spacing": [2, "after"],
     // Deprecated, will be removed in 1.0.
     "global-strict": 0,
     // Only useful in a node environment.
     "handle-callback-err": 0,
     // Tab width.
-    "indent": [1, 2, {"SwitchCase": 1}],
+    "indent": [2, 2, {"SwitchCase": 1}],
     // Enforces spacing between keys and values in object literal properties.
-    "key-spacing": [1, {"beforeColon": false, "afterColon": true}],
+    "key-spacing": [2, {"beforeColon": false, "afterColon": true}],
     // Allow mixed 'LF' and 'CRLF' as linebreaks.
     "linebreak-style": 0,
     // Don't enforce the maximum depth that blocks can be nested. The complexity
     // rule is a better rule to check this.
     "max-depth": 0,
     // Maximum length of a line.
     "max-len": [2, 80, 2, {"ignoreUrls": true, "ignorePattern": "\\s*require\\s*\\(|^\\s*loader\\.lazy|-\\*-"}],
     // Maximum depth callbacks can be nested.
@@ -110,17 +110,17 @@
     // Disallow use of the Array constructor.
     "no-array-constructor": 2,
     // Allow use of bitwise operators.
     "no-bitwise": 0,
     // Disallow use of arguments.caller or arguments.callee.
     "no-caller": 2,
     // Disallow the catch clause parameter name being the same as a variable in
     // the outer scope, to avoid confusion.
-    "no-catch-shadow": 1,
+    "no-catch-shadow": 2,
     // Deprecated, will be removed in 1.0.
     "no-comma-dangle": 0,
     // Disallow assignment in conditional expressions.
     "no-cond-assign": 2,
     // Allow using the console API.
     "no-console": 0,
     // Allow using constant expressions in conditions like while (true)
     "no-constant-condition": 0,
@@ -162,47 +162,47 @@
     "no-extend-native": 2,
     // Disallow unnecessary function binding.
     "no-extra-bind": 2,
     // Disallow double-negation boolean casts in a boolean context.
     "no-extra-boolean-cast": 2,
     // Allow unnecessary parentheses, as they may make the code more readable.
     "no-extra-parens": 0,
     // Disallow unnecessary semicolons.
-    "no-extra-semi": 1,
+    "no-extra-semi": 2,
     // Deprecated, will be removed in 1.0.
     "no-extra-strict": 0,
     // Disallow fallthrough of case statements, except if there is a comment.
     "no-fallthrough": 2,
     // Allow the use of leading or trailing decimal points in numeric literals.
     "no-floating-decimal": 0,
     // Disallow comments inline after code.
-    "no-inline-comments": 1,
+    "no-inline-comments": 2,
     // Disallow if as the only statement in an else block.
     "no-lonely-if": 2,
     // Allow mixing regular variable and require declarations (not a node env).
     "no-mixed-requires": 0,
     // Disallow mixed spaces and tabs for indentation.
     "no-mixed-spaces-and-tabs": 2,
     // Disallow use of multiple spaces (sometimes used to align const values,
     // array or object items, etc.). It's hard to maintain and doesn't add that
     // much benefit.
-    "no-multi-spaces": 1,
+    "no-multi-spaces": 2,
     // Disallow use of multiline strings (use template strings instead).
-    "no-multi-str": 1,
+    "no-multi-str": 2,
     // Disallow multiple empty lines.
-    "no-multiple-empty-lines": [1, {"max": 1}],
+    "no-multiple-empty-lines": [2, {"max": 1}],
     // Disallow reassignments of native objects.
     "no-native-reassign": 2,
     // Disallow nested ternary expressions, they make the code hard to read.
     "no-nested-ternary": 2,
     // Allow use of new operator with the require function.
     "no-new-require": 0,
     // Disallow use of octal literals.
-    "no-octal": 1,
+    "no-octal": 2,
     // Allow reassignment of function parameters.
     "no-param-reassign": 0,
     // Allow string concatenation with __dirname and __filename (not a node env).
     "no-path-concat": 0,
     // Allow use of unary operators, ++ and --.
     "no-plusplus": 0,
     // Allow using process.env (not a node environment).
     "no-process-env": 0,
@@ -227,23 +227,23 @@
     "no-self-compare": 2,
     // Disallow use of comma operator.
     "no-sequences": 2,
     // Warn about declaration of variables already declared in the outer scope.
     // This isn't an error because it sometimes is useful to use the same name
     // in a small helper function rather than having to come up with another
     // random name.
     // Still, making this a warning can help people avoid being confused.
-    "no-shadow": 1,
+    "no-shadow": 2,
     // Disallow shadowing of names such as arguments.
     "no-shadow-restricted-names": 2,
     // Deprecated, will be removed in 1.0.
     "no-space-before-semi": 0,
     // Disallow space between function identifier and application.
-    "no-spaced-func": 1,
+    "no-spaced-func": 2,
     // Disallow sparse arrays, eg. let arr = [,,2].
     // Array destructuring is fine though:
     // for (let [, breakpointPromise] of aPromises)
     "no-sparse-arrays": 2,
     // Allow use of synchronous methods (not a node environment).
     "no-sync": 0,
     // Allow the use of ternary operators.
     "no-ternary": 0,
@@ -278,57 +278,57 @@
     "no-with": 2,
     // Don't require method and property shorthand syntax for object literals.
     // We use this in the code a lot, but not consistently, and this seems more
     // like something to check at code review time.
     "object-shorthand": 0,
     // Allow more than one variable declaration per function.
     "one-var": 0,
     // Disallow padding within blocks.
-    "padded-blocks": [1, "never"],
+    "padded-blocks": [2, "never"],
     // Don't require quotes around object literal property names.
     "quote-props": 0,
     // Double quotes should be used.
-    "quotes": [1, "double", "avoid-escape"],
+    "quotes": [2, "double", "avoid-escape"],
     // Require use of the second argument for parseInt().
     "radix": 2,
     // Always require use of semicolons wherever they are valid.
-    "semi": [1, "always"],
+    "semi": [2, "always"],
     // Enforce spacing after semicolons.
-    "semi-spacing": [1, {"before": false, "after": true}],
+    "semi-spacing": [2, {"before": false, "after": true}],
     // Don't require to sort variables within the same declaration block.
     // Anyway, one-var is disabled.
     "sort-vars": 0,
     // Deprecated, will be removed in 1.0.
     "space-after-function-name": 0,
     // Require a space after keywords.
-    "space-after-keywords": [1, "always"],
+    "space-after-keywords": [2, "always"],
     // Require a space before the start brace of a block.
-    "space-before-blocks": [1, "always"],
+    "space-before-blocks": [2, "always"],
     // Deprecated, will be removed in 1.0.
     "space-before-function-parentheses": 0,
     // Disallow space before function opening parenthesis.
-    "space-before-function-paren": [1, "never"],
+    "space-before-function-paren": [2, "never"],
     // Disable the rule that checks if spaces inside {} and [] are there or not.
     // Our code is split on conventions, and it'd be nice to have 2 rules
     // instead, one for [] and one for {}. So, disabling until we write them.
     "space-in-brackets": 0,
     // Disallow spaces inside parentheses.
-    "space-in-parens": [1, "never"],
+    "space-in-parens": [2, "never"],
     // Require spaces around operators, except for a|0.
-    "space-infix-ops": [1, {"int32Hint": true}],
+    "space-infix-ops": [2, {"int32Hint": true}],
     // Require a space after return, throw, and case.
-    "space-return-throw-case": 1,
+    "space-return-throw-case": 2,
     // Require spaces before/after unary operators (words on by default,
     // nonwords off by default).
-    "space-unary-ops": [1, { "words": true, "nonwords": false }],
+    "space-unary-ops": [2, { "words": true, "nonwords": false }],
     // Deprecated, will be removed in 1.0.
     "space-unary-word-ops": 0,
     // Require a space immediately following the // in a line comment.
-    "spaced-comment": [1, "always"],
+    "spaced-comment": [2, "always"],
     // Require "use strict" to be defined globally in the script.
     "strict": [2, "global"],
     // Disallow comparisons with the value NaN.
     "use-isnan": 2,
     // Warn about invalid JSDoc comments.
     // Disabled for now because of https://github.com/eslint/eslint/issues/2270
     // The rule fails on some jsdoc comments like in:
     // devtools/client/webconsole/console-output.js