Bug 1340928 (part 4) - Remove redundant PlatformStop() call in profiler_stop(). r=mstange.
authorNicholas Nethercote <nnethercote@mozilla.com>
Wed, 15 Feb 2017 14:44:12 +1100
changeset 373443 c043ce740d1bed8c359290b5b7125cc27f238147
parent 373442 cbc8f0119f8ba08e5c2f9782107531c085e794d7
child 373444 7e6850af9372989b7dd66318076deb6df02ddf55
push id10863
push userjlorenzo@mozilla.com
push dateMon, 06 Mar 2017 23:02:23 +0000
treeherdermozilla-aurora@0931190cd725 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange
bugs1340928
milestone54.0a1
Bug 1340928 (part 4) - Remove redundant PlatformStop() call in profiler_stop(). r=mstange. There is another PlatformStop() call earlier in the function, and gIsActive is always false by the time we reach the removed call, so it's dead code.
tools/profiler/core/platform.cpp
--- a/tools/profiler/core/platform.cpp
+++ b/tools/profiler/core/platform.cpp
@@ -2134,19 +2134,16 @@ profiler_stop()
   gDisplayListDump  = false;
   gLayersDump       = false;
   gProfileGPU       = false;
   gProfileMemory    = false;
   gProfileRestyle   = false;
   gProfileThreads   = false;
   gUseStackWalk     = false;
 
-  if (gIsActive)
-    PlatformStop();
-
   // Destroy ThreadInfo for all threads
   {
     StaticMutexAutoLock lock(gRegisteredThreadsMutex);
 
     for (uint32_t i = 0; i < gRegisteredThreads->size(); i++) {
       ThreadInfo* info = gRegisteredThreads->at(i);
       // We've stopped profiling. We no longer need to retain
       // information for an old thread.