Bug 1287006 - Followup bustage fix. r=bustage in a CLOSED TREE
authorJeff Walden <jwalden@mit.edu>
Wed, 22 Feb 2017 20:41:37 -0800
changeset 373493 bc8c006751c6b4e526de1b15f4e8048f7a6cf8e6
parent 373492 e0f2e64261cc3e1a535b1500f13cefe7e32be2dd
child 373494 57775a0cc6f42b207d686499ffd847ebae0fcb03
push id10863
push userjlorenzo@mozilla.com
push dateMon, 06 Mar 2017 23:02:23 +0000
treeherdermozilla-aurora@0931190cd725 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbustage
bugs1287006
milestone54.0a1
Bug 1287006 - Followup bustage fix. r=bustage in a CLOSED TREE
media/webrtc/signaling/gtest/jsep_session_unittest.cpp
--- a/media/webrtc/signaling/gtest/jsep_session_unittest.cpp
+++ b/media/webrtc/signaling/gtest/jsep_session_unittest.cpp
@@ -97,17 +97,17 @@ protected:
     tdata->mIceUfrag = session->GetName() + "-ufrag";
     tdata->mIcePwd = session->GetName() + "-1234567890";
     session->SetIceCredentials(tdata->mIceUfrag, tdata->mIcePwd);
     AddDtlsFingerprint("sha-1", session, tdata);
     AddDtlsFingerprint("sha-256", session, tdata);
   }
 
   std::string
-  CreateOffer(const Maybe<JsepOfferOptions> options = Nothing())
+  CreateOffer(const Maybe<JsepOfferOptions>& options = Nothing())
   {
     JsepOfferOptions defaultOptions;
     const JsepOfferOptions& optionsRef = options ? *options : defaultOptions;
     std::string offer;
     nsresult rv = mSessionOff.CreateOffer(optionsRef, &offer);
     EXPECT_EQ(NS_OK, rv) << mSessionOff.GetLastError();
 
     std::cerr << "OFFER: " << offer << std::endl;
@@ -527,17 +527,17 @@ protected:
   }
 
   static const uint32_t NO_CHECKS = 0;
   static const uint32_t CHECK_SUCCESS = 1;
   static const uint32_t CHECK_TRACKS = 1 << 2;
   static const uint32_t ALL_CHECKS = CHECK_SUCCESS | CHECK_TRACKS;
 
   void OfferAnswer(uint32_t checkFlags = ALL_CHECKS,
-                   const Maybe<JsepOfferOptions> options = Nothing()) {
+                   const Maybe<JsepOfferOptions>& options = Nothing()) {
     std::string offer = CreateOffer(options);
     SetLocalOffer(offer, checkFlags);
     SetRemoteOffer(offer, checkFlags);
 
     std::string answer = CreateAnswer();
     SetLocalAnswer(answer, checkFlags);
     SetRemoteAnswer(answer, checkFlags);
   }