bug 522829 - add an extra print statement to checkForCrashes to try to figure out what's going wrong
authorTed Mielczarek <ted.mielczarek@gmail.com>
Tue, 20 Oct 2009 13:27:02 -0400
changeset 34036 ba9c06d83b3ecc509ad94e0ddbdcca5ca5fea7f1
parent 34035 5a68b843f4d99b34bcaa9cd199732c7b78f7cb93
child 34037 a830ed8bf8dc98ee974b2d80043233eb1c3ba20d
push idunknown
push userunknown
push dateunknown
bugs522829
milestone1.9.3a1pre
bug 522829 - add an extra print statement to checkForCrashes to try to figure out what's going wrong
build/automationutils.py
--- a/build/automationutils.py
+++ b/build/automationutils.py
@@ -100,26 +100,29 @@ def checkForCrashes(dumpDir, symbolsPath
       testName = os.path.basename(sys._getframe(1).f_code.co_filename)
     except:
       testName = "unknown"
 
   foundCrash = False
   dumps = glob.glob(os.path.join(dumpDir, '*.dmp'))
   for d in dumps:
     log.info("TEST-UNEXPECTED-FAIL | %s | application crashed (minidump found)", testName)
-    if symbolsPath and stackwalkPath:
+    if symbolsPath and stackwalkPath and os.path.exists(stackwalkPath):
       nullfd = open(os.devnull, 'w')
       # eat minidump_stackwalk errors
       subprocess.call([stackwalkPath, d, symbolsPath], stderr=nullfd)
       nullfd.close()
     else:
       if not symbolsPath:
         print "No symbols path given, can't process dump."
       if not stackwalkPath:
         print "MINIDUMP_STACKWALK not set, can't process dump."
+      else:
+        if not os.path.exists(stackwalkPath):
+          print "MINIDUMP_STACKWALK binary not found: %s" % stackwalkPath
     os.remove(d)
     extra = os.path.splitext(d)[0] + ".extra"
     if os.path.exists(extra):
       os.remove(extra)
     foundCrash = True
 
   return foundCrash