Bug 1314981 - Remove clean working directory check; r=dustin
authorGregory Szorc <gps@mozilla.com>
Thu, 03 Nov 2016 08:17:54 -0700
changeset 347626 b39b2ddf6ab9ddb067208d7c94bb0c483ab5c750
parent 347625 6225ca668757c3982a90fefeeb310a1dae2785d7
child 347627 4e9e418ab29349ee950b57aa4bd2dbc2ee372af0
push id10298
push userraliiev@mozilla.com
push dateMon, 14 Nov 2016 12:33:03 +0000
treeherdermozilla-aurora@7e29173b1641 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdustin
bugs1314981
milestone52.0a1
Bug 1314981 - Remove clean working directory check; r=dustin As the inline comment says, this was meant to be temporary. The check has never fired AFAIK. The check adds ~5s overhead to run-task when there is a source checkout. So let's remove it and get our time back. MozReview-Commit-ID: FqwCaDAyiSE
testing/docker/recipes/run-task
--- a/testing/docker/recipes/run-task
+++ b/testing/docker/recipes/run-task
@@ -130,29 +130,16 @@ def vcs_checkout(source_repo, dest, stor
         source_repo, dest,
     ])
 
     res = run_and_prefix_output(b'vcs', args,
                                 extra_env={b'PYTHONUNBUFFERED': b'1'})
     if res:
         sys.exit(res)
 
-    # Meant to be temporary to flush out what's going on in bug 1292071.
-    print_line(b'vcs', b'verifying working directory is clean\n')
-    status = subprocess.check_output([b'/usr/bin/hg', b'status', b'--all'],
-                                     cwd=dest, stderr=subprocess.STDOUT)
-    status = status.strip()
-    status_lines = [l for l in status.splitlines() if not l.startswith(b'C ')]
-    if status_lines:
-        print_line(b'vcs', b'Error: checkout is not pristine! '
-                           b'Report this in bug 1292071\n')
-        for line in status_lines:
-            print_line(b'vcs', b'%s\n' % line)
-        sys.exit(1)
-
     # Update the current revision hash and ensure that it is well formed.
     revision = subprocess.check_output(
         [b'/usr/bin/hg', b'log',
          b'--rev', b'.',
          b'--template', b'{node}'],
         cwd=dest)
 
     assert re.match('^[a-f0-9]{40}$', revision)