Bug 1284031 (Part 3) - Remove the FromSourceBuffer suffix from StreamingLexer test names. r=njn
authorSeth Fowler <mark.seth.fowler@gmail.com>
Thu, 14 Jul 2016 20:01:18 -0700
changeset 330265 b1e09b3b77dd0253abb363c2146323393c9c0592
parent 330264 0284587d752d35d2ddf6f2d9983047597ff1e38e
child 330266 ff5028ff81cb2c1c05b6a440a981c6e426c4801a
push id9858
push userjlund@mozilla.com
push dateMon, 01 Aug 2016 14:37:10 +0000
treeherdermozilla-aurora@203106ef6cb6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnjn
bugs1284031
milestone50.0a1
Bug 1284031 (Part 3) - Remove the FromSourceBuffer suffix from StreamingLexer test names. r=njn
image/test/gtest/TestStreamingLexer.cpp
--- a/image/test/gtest/TestStreamingLexer.cpp
+++ b/image/test/gtest/TestStreamingLexer.cpp
@@ -151,29 +151,29 @@ TEST_F(ImageStreamingLexer, ZeroLengthDa
   mSourceBuffer->Complete(NS_OK);
 
   Maybe<TerminalState> result = mLexer.Lex(mIterator, mExpectNoResume, DoLex);
 
   EXPECT_TRUE(result.isSome());
   EXPECT_EQ(Some(TerminalState::FAILURE), result);
 }
 
-TEST_F(ImageStreamingLexer, SingleChunkFromSourceBuffer)
+TEST_F(ImageStreamingLexer, SingleChunk)
 {
   // Test delivering all the data at once.
   mSourceBuffer->Append(mData, sizeof(mData));
   mSourceBuffer->Complete(NS_OK);
 
   Maybe<TerminalState> result = mLexer.Lex(mIterator, mExpectNoResume, DoLex);
 
   EXPECT_TRUE(result.isSome());
   EXPECT_EQ(Some(TerminalState::SUCCESS), result);
 }
 
-TEST_F(ImageStreamingLexer, SingleChunkWithUnbufferedFromSourceBuffer)
+TEST_F(ImageStreamingLexer, SingleChunkWithUnbuffered)
 {
   Vector<char> unbufferedVector;
 
   // Test delivering all the data at once.
   mSourceBuffer->Append(mData, sizeof(mData));
   mSourceBuffer->Complete(NS_OK);
 
   Maybe<TerminalState> result =
@@ -181,17 +181,17 @@ TEST_F(ImageStreamingLexer, SingleChunkW
                [&](TestState aState, const char* aData, size_t aLength) {
       return DoLexWithUnbuffered(aState, aData, aLength, unbufferedVector);
   });
 
   EXPECT_TRUE(result.isSome());
   EXPECT_EQ(Some(TerminalState::SUCCESS), result);
 }
 
-TEST_F(ImageStreamingLexer, ChunkPerStateFromSourceBuffer)
+TEST_F(ImageStreamingLexer, ChunkPerState)
 {
   // Test delivering in perfectly-sized chunks, one per state.
   for (unsigned i = 0; i < 3; ++i) {
     mSourceBuffer->Append(mData + 3 * i, 3);
     Maybe<TerminalState> result = mLexer.Lex(mIterator, mCountResumes, DoLex);
 
     if (i == 2) {
       EXPECT_TRUE(result.isSome());
@@ -200,17 +200,17 @@ TEST_F(ImageStreamingLexer, ChunkPerStat
       EXPECT_TRUE(result.isNothing());
     }
   }
 
   EXPECT_EQ(2u, mCountResumes->Count());
   mSourceBuffer->Complete(NS_OK);
 }
 
-TEST_F(ImageStreamingLexer, ChunkPerStateWithUnbufferedFromSourceBuffer)
+TEST_F(ImageStreamingLexer, ChunkPerStateWithUnbuffered)
 {
   Vector<char> unbufferedVector;
 
   // Test delivering in perfectly-sized chunks, one per state.
   for (unsigned i = 0; i < 3; ++i) {
     mSourceBuffer->Append(mData + 3 * i, 3);
     Maybe<TerminalState> result =
       mLexer.Lex(mIterator, mCountResumes,
@@ -225,17 +225,17 @@ TEST_F(ImageStreamingLexer, ChunkPerStat
       EXPECT_TRUE(result.isNothing());
     }
   }
 
   EXPECT_EQ(2u, mCountResumes->Count());
   mSourceBuffer->Complete(NS_OK);
 }
 
-TEST_F(ImageStreamingLexer, OneByteChunksFromSourceBuffer)
+TEST_F(ImageStreamingLexer, OneByteChunks)
 {
   // Test delivering in one byte chunks.
   for (unsigned i = 0; i < 9; ++i) {
     mSourceBuffer->Append(mData + i, 1);
     Maybe<TerminalState> result = mLexer.Lex(mIterator, mCountResumes, DoLex);
 
     if (i == 8) {
       EXPECT_TRUE(result.isSome());
@@ -244,17 +244,17 @@ TEST_F(ImageStreamingLexer, OneByteChunk
       EXPECT_TRUE(result.isNothing());
     }
   }
 
   EXPECT_EQ(8u, mCountResumes->Count());
   mSourceBuffer->Complete(NS_OK);
 }
 
-TEST_F(ImageStreamingLexer, OneByteChunksWithUnbufferedFromSourceBuffer)
+TEST_F(ImageStreamingLexer, OneByteChunksWithUnbuffered)
 {
   Vector<char> unbufferedVector;
 
   // Test delivering in one byte chunks.
   for (unsigned i = 0; i < 9; ++i) {
     mSourceBuffer->Append(mData + i, 1);
     Maybe<TerminalState> result =
       mLexer.Lex(mIterator, mCountResumes,
@@ -303,17 +303,17 @@ TEST_F(ImageStreamingLexer, ZeroLengthSt
 
   Maybe<TerminalState> result =
     lexer.Lex(mIterator, mExpectNoResume, DoLexWithZeroLengthStatesUnbuffered);
 
   EXPECT_TRUE(result.isSome());
   EXPECT_EQ(Some(TerminalState::SUCCESS), result);
 }
 
-TEST_F(ImageStreamingLexer, TerminateSuccessFromSourceBuffer)
+TEST_F(ImageStreamingLexer, TerminateSuccess)
 {
   mSourceBuffer->Append(mData, sizeof(mData));
   mSourceBuffer->Complete(NS_OK);
 
   // Test that Terminate is "sticky".
   SourceBufferIterator iterator = mSourceBuffer->Iterator();
   Maybe<TerminalState> result =
     mLexer.Lex(iterator, mExpectNoResume,
@@ -330,17 +330,17 @@ TEST_F(ImageStreamingLexer, TerminateSuc
                [&](TestState aState, const char* aData, size_t aLength) {
       EXPECT_TRUE(false);  // Shouldn't get here.
       return Transition::TerminateFailure();
   });
   EXPECT_TRUE(result.isSome());
   EXPECT_EQ(Some(TerminalState::SUCCESS), result);
 }
 
-TEST_F(ImageStreamingLexer, TerminateFailureFromSourceBuffer)
+TEST_F(ImageStreamingLexer, TerminateFailure)
 {
   mSourceBuffer->Append(mData, sizeof(mData));
   mSourceBuffer->Complete(NS_OK);
 
   // Test that Terminate is "sticky".
   SourceBufferIterator iterator = mSourceBuffer->Iterator();
   Maybe<TerminalState> result =
     mLexer.Lex(iterator, mExpectNoResume,
@@ -357,17 +357,17 @@ TEST_F(ImageStreamingLexer, TerminateFai
                [&](TestState aState, const char* aData, size_t aLength) {
       EXPECT_TRUE(false);  // Shouldn't get here.
       return Transition::TerminateFailure();
   });
   EXPECT_TRUE(result.isSome());
   EXPECT_EQ(Some(TerminalState::FAILURE), result);
 }
 
-TEST_F(ImageStreamingLexer, TerminateUnbufferedFromSourceBuffer)
+TEST_F(ImageStreamingLexer, TerminateUnbuffered)
 {
   // Test that Terminate works during an unbuffered read.
   for (unsigned i = 0; i < 9; ++i) {
     mSourceBuffer->Append(mData + i, 1);
     Maybe<TerminalState> result =
       mLexer.Lex(mIterator, mCountResumes, DoLexWithUnbufferedTerminate);
 
     if (i > 2) {