Bug 1143970 - clicking on an item in the reading list sidebar now opens the item. r=gavin a=readinglist
authorMark Hammond <mhammond@skippinet.com.au>
Mon, 16 Mar 2015 18:25:24 -0700
changeset 248425 a7946db30b62636c1c893a22d6b9c831893199db
parent 248424 c8f5fabac3693dca7d0f8bf5a4855cd333bf05bc
child 248426 3af32770b0f3628c0a4e17ae4518bb2a34b7dd31
push id7837
push userjwein@mozilla.com
push dateFri, 27 Mar 2015 00:27:16 +0000
treeherdermozilla-aurora@cb0db44ce60e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgavin, readinglist
bugs1143970
milestone38.0a2
Bug 1143970 - clicking on an item in the reading list sidebar now opens the item. r=gavin a=readinglist
browser/components/readinglist/sidebar.js
--- a/browser/components/readinglist/sidebar.js
+++ b/browser/components/readinglist/sidebar.js
@@ -265,19 +265,17 @@ let RLSidebar = {
 
   /**
    * Open a given URL. The event is used to determine where it should be opened
    * (current tab, new tab, new window).
    * @param {string} url - URL to open.
    * @param {Event} event - KeyEvent or MouseEvent that triggered this action.
    */
   openURL(url, event) {
-    // TODO: Disabled while working on the listbox mechanics.
     log.debug(`Opening page ${url}`);
-    return;
 
     let mainWindow = window.QueryInterface(Ci.nsIInterfaceRequestor)
                            .getInterface(Ci.nsIWebNavigation)
                            .QueryInterface(Ci.nsIDocShellTreeItem)
                            .rootTreeItem
                            .QueryInterface(Ci.nsIInterfaceRequestor)
                            .getInterface(Ci.nsIDOMWindow);
     mainWindow.openUILink(url, event);