Bug 829975: Mark classes in nsGIOService.cpp & .h as MOZ_FINAL to fix their Wdelete-non-virtual-dtor build warnings. r=ehsan
authorDaniel Holbert <dholbert@cs.stanford.edu>
Sun, 13 Jan 2013 12:28:59 -0800
changeset 124821 a2a89856f0a2cfdbb027017f6ecf9f950bdc4696
parent 124820 ca9a07b19e7960a50754198ee237b91ad7cde767
child 124822 11b7a6a6bc4cba763ad25c4739196e5911d6b16d
push id3384
push userlsblakk@mozilla.com
push dateTue, 19 Feb 2013 18:42:39 +0000
treeherdermozilla-aurora@d8c97bae8521 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersehsan
bugs829975
milestone21.0a1
Bug 829975: Mark classes in nsGIOService.cpp & .h as MOZ_FINAL to fix their Wdelete-non-virtual-dtor build warnings. r=ehsan
toolkit/system/gnome/nsGIOService.cpp
toolkit/system/gnome/nsGIOService.h
--- a/toolkit/system/gnome/nsGIOService.cpp
+++ b/toolkit/system/gnome/nsGIOService.cpp
@@ -31,17 +31,17 @@ get_content_type_from_mime_type(const ch
     g_free(mimeTypeFromContentType);
     ct_ptr = ct_ptr->next;
   }
   g_list_foreach(contentTypes, (GFunc) g_free, NULL);
   g_list_free(contentTypes);
   return foundContentType;
 }
 
-class nsGIOMimeApp : public nsIGIOMimeApp
+class nsGIOMimeApp MOZ_FINAL : public nsIGIOMimeApp
 {
 public:
   NS_DECL_ISUPPORTS
   NS_DECL_NSIGIOMIMEAPP
 
   nsGIOMimeApp(GAppInfo* aApp) : mApp(aApp) {}
   ~nsGIOMimeApp() { g_object_unref(mApp); }
 
@@ -96,17 +96,17 @@ nsGIOMimeApp::Launch(const nsACString& a
     g_warning("Cannot launch application: %s", error->message);
     g_error_free(error);
     return NS_ERROR_FAILURE;
   }
 
   return NS_OK;
 }
 
-class GIOUTF8StringEnumerator : public nsIUTF8StringEnumerator
+class GIOUTF8StringEnumerator MOZ_FINAL : public nsIUTF8StringEnumerator
 {
 public:
   GIOUTF8StringEnumerator() : mIndex(0) { }
   ~GIOUTF8StringEnumerator() { }
 
   NS_DECL_ISUPPORTS
   NS_DECL_NSIUTF8STRINGENUMERATOR
 
--- a/toolkit/system/gnome/nsGIOService.h
+++ b/toolkit/system/gnome/nsGIOService.h
@@ -6,17 +6,17 @@
 #ifndef nsGIOService_h_
 #define nsGIOService_h_
 
 #include "nsIGIOService.h"
 
 #define NS_GIOSERVICE_CID \
 {0xe3a1f3c9, 0x3ae1, 0x4b40, {0xa5, 0xe0, 0x7b, 0x45, 0x7f, 0xc9, 0xa9, 0xad}}
 
-class nsGIOService : public nsIGIOService
+class nsGIOService MOZ_FINAL : public nsIGIOService
 {
 public:
   NS_DECL_ISUPPORTS
   NS_DECL_NSIGIOSERVICE
 };
 
 #endif