Bug 1133142 - Downgrade 'mTempFile not equal to mTargetFile' from assertion to warning. r=yoric, a=NPOTB
authorJesse Ruderman <jruderman@gmail.com>
Thu, 05 Mar 2015 01:31:41 -0800
changeset 247968 9ea4d014791b70ac5047e224b1b831747cd25ace
parent 247967 643bbfda477319a4c6a76d9bf1ddef35674b3b2d
child 247969 6d66dccc94f8019fe32179cc249abb7baf9b722b
push id7729
push userryanvm@gmail.com
push dateWed, 11 Mar 2015 19:08:10 +0000
treeherdermozilla-aurora@bb6535c6211b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersyoric, NPOTB
bugs1133142
milestone38.0a2
Bug 1133142 - Downgrade 'mTempFile not equal to mTargetFile' from assertion to warning. r=yoric, a=NPOTB
netwerk/base/nsFileStreams.cpp
--- a/netwerk/base/nsFileStreams.cpp
+++ b/netwerk/base/nsFileStreams.cpp
@@ -959,17 +959,17 @@ nsAtomicFileOutputStream::Finish()
         if (!mTargetFileExists) {
             // If the target file did not exist when we were initialized, then the
             // temp file we gave out was actually a reference to the target file.
             // since we succeeded in writing to the temp file (and hence succeeded
             // in writing to the target file), there is nothing more to do.
 #ifdef DEBUG
             bool equal;
             if (NS_FAILED(mTargetFile->Equals(mTempFile, &equal)) || !equal)
-                NS_ERROR("mTempFile not equal to mTargetFile");
+                NS_WARNING("mTempFile not equal to mTargetFile");
 #endif
         }
         else {
             nsAutoString targetFilename;
             rv = mTargetFile->GetLeafName(targetFilename);
             if (NS_SUCCEEDED(rv)) {
                 // This will replace target.
                 rv = mTempFile->MoveTo(nullptr, targetFilename);