Bug 920317: Banner cuts off TopSitesPage. [r=margaret] [a=lsblakk]
authorSriram Ramasubramanian <sriram@mozilla.com>
Thu, 26 Sep 2013 15:39:36 -0700
changeset 155869 9c524d4d834a6a5d4f297389d62711e9b11825af
parent 155868 92d60b740d289dfacda9b41a75e4155570aebdab
child 155870 5bd7c307b8a559bade1c141873bb862be153026c
push id4454
push usersramasubramanian@mozilla.com
push dateTue, 22 Oct 2013 05:36:10 +0000
treeherdermozilla-aurora@1cb44a39126e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmargaret, lsblakk
bugs920317
milestone26.0a2
Bug 920317: Banner cuts off TopSitesPage. [r=margaret] [a=lsblakk]
mobile/android/base/resources/layout/home_top_sites_page.xml
--- a/mobile/android/base/resources/layout/home_top_sites_page.xml
+++ b/mobile/android/base/resources/layout/home_top_sites_page.xml
@@ -1,29 +1,28 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
-<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-              android:layout_width="fill_parent"
-              android:layout_height="fill_parent"
-              android:orientation="vertical">
+<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
+             android:layout_width="fill_parent"
+             android:layout_height="fill_parent"
+             android:orientation="vertical">
 
     <org.mozilla.gecko.home.HomeListView
             android:id="@+id/list"
             style="@style/Widget.TopSitesListView"
             android:layout_width="fill_parent"
-            android:layout_height="0dp"
-            android:layout_weight="1"/>
+            android:layout_height="fill_parent"/>
 
     <org.mozilla.gecko.home.HomeBanner android:id="@+id/home_banner"
                                        style="@style/Widget.HomeBanner"
                                        android:layout_width="fill_parent"
                                        android:layout_height="@dimen/home_banner_height"
                                        android:background="@drawable/home_banner"
                                        android:layout_gravity="bottom"
                                        android:gravity="center_vertical"
                                        android:visibility="gone"
                                        android:clickable="true"
                                        android:focusable="true"/>
 
-</LinearLayout>
+</FrameLayout>