Bug 859021 followup: Add missing "f" suffixes for float-valued numeric literals, even where it's not strictly required by MSVC build warnings.
authorDaniel Holbert <dholbert@cs.stanford.edu>
Mon, 08 Apr 2013 15:06:28 -0700
changeset 134842 9bda607c832db0a3086e028c75a8b2d758e93800
parent 134841 1b86d1d851def3e223bdefb8aa46d76f92a9dc7f
child 134843 d61fd3898e79a76b0787bca2464a294754ed0995
push id3752
push userlsblakk@mozilla.com
push dateMon, 13 May 2013 17:21:10 +0000
treeherdermozilla-aurora@1580544aef0b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs859021
milestone23.0a1
Bug 859021 followup: Add missing "f" suffixes for float-valued numeric literals, even where it's not strictly required by MSVC build warnings.
content/svg/content/src/nsSVGFilters.cpp
--- a/content/svg/content/src/nsSVGFilters.cpp
+++ b/content/svg/content/src/nsSVGFilters.cpp
@@ -715,22 +715,22 @@ GenerateNormal(float *N, const uint8_t *
       { { {  0, -2, -1}, { 0,  0,  0}, { 0,  2,  1} },
         { { -1, -2, -1}, { 0,  0,  0}, { 1,  2,  1} },
         { { -1, -2,  0}, { 0,  0,  0}, { 1,  2,  0} } },
       { { {  0, -2, -1}, { 0,  2,  1}, { 0,  0,  0} },
         { { -1, -2, -1}, { 1,  2,  1}, { 0,  0,  0} },
         { { -1, -2,  0}, { 1,  2,  0}, { 0,  0,  0} } } };
   static const float FACTORx[3][3] =
     { { 2.0f / 3.0f, 1.0f / 3.0f, 2.0f / 3.0f },
-      { 1.0 / 2.0, 1.0 / 4.0, 1.0 / 2.0 },
+      { 1.0f / 2.0f, 1.0f / 4.0f, 1.0f / 2.0f },
       { 2.0f / 3.0f, 1.0f / 3.0f, 2.0f / 3.0f } };
   static const float FACTORy[3][3] =
-    { { 2.0f / 3.0f, 1.0 / 2.0, 2.0f / 3.0f },
-      { 1.0f / 3.0f, 1.0 / 4.0, 1.0f / 3.0f },
-      { 2.0f / 3.0f, 1.0 / 2.0, 2.0f / 3.0f } };
+    { { 2.0f / 3.0f, 1.0f / 2.0f, 2.0f / 3.0f },
+      { 1.0f / 3.0f, 1.0f / 4.0f, 1.0f / 3.0f },
+      { 2.0f / 3.0f, 1.0f / 2.0f, 2.0f / 3.0f } };
 
   // degenerate cases
   if (surfaceWidth == 1 || surfaceHeight == 1) {
     // just return a unit vector pointing towards the viewer
     N[0] = 0;
     N[1] = 0;
     N[2] = 255;
     return;