Bug 1271714. Annotate expected asserts in layout/printing/crashtests/576878.xhtml. r=mstange
authorTimothy Nikkel <tnikkel@gmail.com>
Wed, 13 Jul 2016 01:08:17 -0500
changeset 330004 8e3acbc708b62db2a091a587c40953e9ed41c786
parent 330003 2f8d5f889b47589b79a8ad95456f863c1b83cfb4
child 330005 a8e5e8ecc28e1d7f7645652788709e07356a37ac
push id9858
push userjlund@mozilla.com
push dateMon, 01 Aug 2016 14:37:10 +0000
treeherdermozilla-aurora@203106ef6cb6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange
bugs1271714, 576878
milestone50.0a1
Bug 1271714. Annotate expected asserts in layout/printing/crashtests/576878.xhtml. r=mstange The asserts are: ###!!! ASSERTION: Bounds computation mismatch: 'mContainerBounds.IsEqualInterior(mAccumulatedChildBounds)', /layout/base/FrameLayerBuilder.cpp, line 4887 ###!!! ASSERTION: bad aListVisibleBounds: 'r.GetBounds().IsEqualInterior(aListVisibleBounds)', /layout/base/nsDisplayList.cpp, line 1637 They happen because we have a wrap list item that contains an out of flow frame with no saved clip data. So the patch for this bug changes the scroll clip of the wrap list item from the scroll clip induced by the root scroll frame to the null scroll clip. All of the display items that the wrap list contains have the root scroll frame scroll clip, so this causes the scroll clipped bounds for the wrap list item to expand to the whole content area. These expanded bounds of the wrap list item get incorporated into the bounds of a parent transform item. Later the wrap list item is flattened away, and so it's no longer around to provide the expanded bounds, leading to the assertions. I've thought through options like changing how scroll clipped bounds work for wrap list items, but I can't seem to find any solution that would be consistent. The best thing would be to get the proper clip on out of flows we are going to descend into, but I can't think of a good way to do that either in this case (or in general).
layout/printing/crashtests/crashtests.list
--- a/layout/printing/crashtests/crashtests.list
+++ b/layout/printing/crashtests/crashtests.list
@@ -1,4 +1,4 @@
 load 509839-1.html
 load 509839-2.html
-load 576878.xhtml
+asserts(4) load 576878.xhtml
 load 793844.html