Backed out changeset 59d4978e8726 (bug 1289723) for eslint failure
authorCarsten "Tomcat" Book <cbook@mozilla.com>
Tue, 21 Feb 2017 12:11:04 +0100
changeset 373083 8babccb56f91673c2fbdf1d7bbf9f80194940750
parent 373082 c0c0e10ed6131dda7d98315574b3b739081055b0
child 373084 72f6eace33a1897d9d3d00189894e6e85c7b97ae
push id10863
push userjlorenzo@mozilla.com
push dateMon, 06 Mar 2017 23:02:23 +0000
treeherdermozilla-aurora@0931190cd725 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1289723
milestone54.0a1
backs out59d4978e8726f56e6d0ad1752a489b8cb8fcf7f8
Backed out changeset 59d4978e8726 (bug 1289723) for eslint failure
browser/components/sessionstore/test/browser_crashedTabs.js
toolkit/content/widgets/remote-browser.xml
--- a/browser/components/sessionstore/test/browser_crashedTabs.js
+++ b/browser/components/sessionstore/test/browser_crashedTabs.js
@@ -8,16 +8,17 @@ requestLongerTimeout(10);
 const PAGE_1 = "data:text/html,<html><body>A%20regular,%20everyday,%20normal%20page.";
 const PAGE_2 = "data:text/html,<html><body>Another%20regular,%20everyday,%20normal%20page.";
 
 // Turn off tab animations for testing and use a single content process
 // for these tests since we want to test tabs within the crashing process here.
 add_task(function* test_initialize() {
   yield SpecialPowers.pushPrefEnv({
     set: [
+      [ "dom.ipc.processCount", 1 ],
       [ "browser.tabs.animate", false]
   ] });
 });
 
 // Allow tabs to restore on demand so we can test pending states
 Services.prefs.clearUserPref("browser.sessionstore.restore_on_demand");
 
 function clickButton(browser, id) {
@@ -235,17 +236,17 @@ add_task(function* test_revive_tab_from_
   gBrowser.selectedTab = newTab;
   let browser = newTab.linkedBrowser;
   ok(browser.isRemoteBrowser, "Should be a remote browser");
   yield promiseBrowserLoaded(browser);
 
   browser.loadURI(PAGE_1);
   yield promiseBrowserLoaded(browser);
 
-  let newTab2 = gBrowser.addTab("about:blank", { sameProcessAsFrameLoader: browser.frameLoader });
+  let newTab2 = gBrowser.addTab();
   let browser2 = newTab2.linkedBrowser;
   ok(browser2.isRemoteBrowser, "Should be a remote browser");
   yield promiseBrowserLoaded(browser2);
 
   browser.loadURI(PAGE_1);
   yield promiseBrowserLoaded(browser);
 
   browser.loadURI(PAGE_2);
@@ -292,17 +293,17 @@ add_task(function* test_revive_all_tabs_
 
   browser.loadURI(PAGE_1);
   yield promiseBrowserLoaded(browser);
 
   // In order to see a second about:tabcrashed page, we'll need
   // a second window, since only selected tabs will show
   // about:tabcrashed.
   let win2 = yield BrowserTestUtils.openNewBrowserWindow();
-  let newTab2 = win2.gBrowser.addTab(PAGE_1, { sameProcessAsFrameLoader: browser.frameLoader });
+  let newTab2 = win2.gBrowser.addTab(PAGE_1);
   win2.gBrowser.selectedTab = newTab2;
   let browser2 = newTab2.linkedBrowser;
   ok(browser2.isRemoteBrowser, "Should be a remote browser");
   yield promiseBrowserLoaded(browser2);
 
   browser.loadURI(PAGE_1);
   yield promiseBrowserLoaded(browser);
 
@@ -399,17 +400,17 @@ add_task(function* test_hide_restore_all
   gBrowser.selectedTab = newTab;
 
   browser.loadURI(PAGE_2);
   yield promiseBrowserLoaded(browser);
 
   // Load up a second window so we can get another tab to show
   // about:tabcrashed
   let win2 = yield BrowserTestUtils.openNewBrowserWindow();
-  let newTab3 = win2.gBrowser.addTab(PAGE_2, { sameProcessAsFrameLoader: browser.frameLoader });
+  let newTab3 = win2.gBrowser.addTab(PAGE_2);
   win2.gBrowser.selectedTab = newTab3;
   let otherWinBrowser = newTab3.linkedBrowser;
   yield promiseBrowserLoaded(otherWinBrowser);
   // We'll need to make sure the second tab's browser has finished
   // sending its AboutTabCrashedReady event before we know for
   // sure whether or not we're showing the right Restore buttons.
   let otherBrowserReady = promiseTabCrashedReady(otherWinBrowser);
 
--- a/toolkit/content/widgets/remote-browser.xml
+++ b/toolkit/content/widgets/remote-browser.xml
@@ -185,19 +185,17 @@
       <property name="fullZoom">
         <getter><![CDATA[
           return this._fullZoom;
         ]]></getter>
         <setter><![CDATA[
           let changed = val.toFixed(2) != this._fullZoom.toFixed(2);
 
           this._fullZoom = val;
-          try {
-            this.messageManager.sendAsyncMessage("FullZoom", {value: val});
-          } catch(ex) {}
+          this.messageManager.sendAsyncMessage("FullZoom", {value: val});
 
           if (changed) {
             let event = new Event("FullZoomChange", {bubbles: true});
             this.dispatchEvent(event);
           }
         ]]></setter>
       </property>
 
@@ -205,19 +203,17 @@
       <property name="textZoom">
         <getter><![CDATA[
           return this._textZoom;
         ]]></getter>
         <setter><![CDATA[
           let changed = val.toFixed(2) != this._textZoom.toFixed(2);
 
           this._textZoom = val;
-          try {
-            this.messageManager.sendAsyncMessage("TextZoom", {value: val});
-          } catch(ex) {}
+          this.messageManager.sendAsyncMessage("TextZoom", {value: val});
 
           if (changed) {
             let event = new Event("TextZoomChange", {bubbles: true});
             this.dispatchEvent(event);
           }
         ]]></setter>
       </property>