Bug 1284987 - Entries API - part 5 - Get rid of remove methods, r=smaug
authorAndrea Marchesini <amarchesini@mozilla.com>
Thu, 03 Nov 2016 07:57:09 +0100
changeset 347545 89b07c9ea3ce3ec1bca86ce690145f9414ce63fe
parent 347544 508a6a6fb5348247c111e2ff174e2950e774270a
child 347546 552ad078563f102d1479b9769ab37547ad94e714
push id10298
push userraliiev@mozilla.com
push dateMon, 14 Nov 2016 12:33:03 +0000
treeherdermozilla-aurora@7e29173b1641 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs1284987
milestone52.0a1
Bug 1284987 - Entries API - part 5 - Get rid of remove methods, r=smaug
dom/filesystem/compat/FileSystemDirectoryEntry.cpp
dom/filesystem/compat/FileSystemDirectoryEntry.h
dom/webidl/FileSystemDirectoryEntry.webidl
--- a/dom/filesystem/compat/FileSystemDirectoryEntry.cpp
+++ b/dom/filesystem/compat/FileSystemDirectoryEntry.cpp
@@ -98,18 +98,10 @@ FileSystemDirectoryEntry::GetInternal(co
                        aSuccessCallback.WasPassed()
                          ? &aSuccessCallback.Value() : nullptr,
                        aErrorCallback.WasPassed()
                          ? &aErrorCallback.Value() : nullptr,
                        aType);
   helper->Run();
 }
 
-void
-FileSystemDirectoryEntry::RemoveRecursively(VoidCallback& aSuccessCallback,
-                                            const Optional<OwningNonNull<ErrorCallback>>& aErrorCallback) const
-{
-  ErrorCallbackHelper::Call(GetParentObject(), aErrorCallback,
-                            NS_ERROR_DOM_SECURITY_ERR);
-}
-
 } // dom namespace
 } // mozilla namespace
--- a/dom/filesystem/compat/FileSystemDirectoryEntry.h
+++ b/dom/filesystem/compat/FileSystemDirectoryEntry.h
@@ -58,20 +58,16 @@ public:
   GetDirectory(const Optional<nsAString>& aPath, const FileSystemFlags& aFlag,
                const Optional<OwningNonNull<FileSystemEntryCallback>>& aSuccessCallback,
                const Optional<OwningNonNull<ErrorCallback>>& aErrorCallback)
   {
     GetInternal(aPath.WasPassed() ? aPath.Value() : EmptyString(),
                 aFlag, aSuccessCallback, aErrorCallback, eGetDirectory);
   }
 
-  void
-  RemoveRecursively(VoidCallback& aSuccessCallback,
-                    const Optional<OwningNonNull<ErrorCallback>>& aErrorCallback) const;
-
   enum GetInternalType { eGetFile, eGetDirectory };
 
   virtual void
   GetInternal(const nsAString& aPath, const FileSystemFlags& aFlag,
               const Optional<OwningNonNull<FileSystemEntryCallback>>& aSuccessCallback,
               const Optional<OwningNonNull<ErrorCallback>>& aErrorCallback,
               GetInternalType aType);
 
--- a/dom/webidl/FileSystemDirectoryEntry.webidl
+++ b/dom/webidl/FileSystemDirectoryEntry.webidl
@@ -11,14 +11,9 @@ interface FileSystemDirectoryEntry : Fil
                  optional FileSystemFlags options,
                  optional FileSystemEntryCallback successCallback,
                  optional ErrorCallback errorCallback);
 
     void getDirectory(optional USVString? path,
                       optional FileSystemFlags options,
                       optional FileSystemEntryCallback successCallback,
                       optional ErrorCallback errorCallback);
-
-    // This method is not implemented. ErrorCallback will be called
-    // with SecurityError
-    void removeRecursively(VoidCallback successCallback,
-                           optional ErrorCallback errorCallback);
 };