Bug 1145909 - Use an image instead of toolbarbutton for the reading list button. r=florian a=readinglist
authorJared Wein <jwein@mozilla.com>
Fri, 20 Mar 2015 19:29:56 -0700
changeset 248457 79bc8606e3155585c3f61f1abe70180d48f90970
parent 248456 b7de0775a8d922415b69c9d552daf621638e23c7
child 248458 4f9d6ba4a684ad19c207c3240740a4b0fde1fde3
push id7837
push userjwein@mozilla.com
push dateFri, 27 Mar 2015 00:27:16 +0000
treeherdermozilla-aurora@cb0db44ce60e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersflorian, readinglist
bugs1145909
milestone38.0a2
Bug 1145909 - Use an image instead of toolbarbutton for the reading list button. r=florian a=readinglist
browser/base/content/browser.xul
browser/themes/linux/browser.css
browser/themes/osx/browser.css
browser/themes/shared/readinglist/readinglist.inc.css
browser/themes/windows/browser.css
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -822,20 +822,20 @@
                 <label class="urlbar-display urlbar-display-switchtab" value="&urlbar.switchToTab.label;"/>
               </box>
               <hbox id="urlbar-icons">
                 <image id="page-report-button"
                        class="urlbar-icon"
                        hidden="true"
                        tooltiptext="&pageReportIcon.tooltip;"
                        onclick="gPopupBlockerObserver.onReportButtonClick(event);"/>
-                <toolbarbutton id="readinglist-addremove-button"
-                               class="tabbable urlbar-icon"
-                               hidden="true"
-                               oncommand="ReadingListUI.togglePageByBrowser(gBrowser.selectedBrowser);"/>
+                <image id="readinglist-addremove-button"
+                       class="urlbar-icon"
+                       hidden="true"
+                       onclick="ReadingListUI.togglePageByBrowser(gBrowser.selectedBrowser);"/>
                 <image id="reader-mode-button"
                        class="urlbar-icon"
                        hidden="true"
                        onclick="ReaderParent.toggleReaderMode(event);"/>
               </hbox>
               <toolbarbutton id="urlbar-go-button"
                              class="chromeclass-toolbar-additional"
                              onclick="gURLBar.handleCommand(event);"
--- a/browser/themes/linux/browser.css
+++ b/browser/themes/linux/browser.css
@@ -1626,20 +1626,16 @@ richlistitem[type~="action"][actiontype=
 
 /* Popup blocker button */
 #page-report-button {
   list-style-image: url("chrome://browser/skin/Info.png");
 }
 
 %include ../shared/readinglist/readinglist.inc.css
 
-#readinglist-addremove-button {
-  padding: 0 2px;
-}
-
 /* Reader mode button */
 
 #reader-mode-button {
   list-style-image: url("chrome://browser/skin/readerMode.svg");
   -moz-image-region: rect(0, 16px, 16px, 0);
 }
 
 #reader-mode-button:hover,
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -2520,22 +2520,16 @@ richlistitem[type~="action"][actiontype=
   #page-report-button:hover:active,
   #page-report-button[open="true"] {
     -moz-image-region: rect(0, 64px, 32px, 32px);
   }
 }
 
 %include ../shared/readinglist/readinglist.inc.css
 
-#readinglist-addremove-button {
-  padding: 3px;
-  -moz-padding-start: 2px;
-  -moz-padding-end: 1px;
-}
-
 /* Reader mode button */
 
 #reader-mode-button {
   list-style-image: url("chrome://browser/skin/readerMode.svg");
   -moz-image-region: rect(0, 16px, 16px, 0);
 }
 
 #reader-mode-button:hover:active {
--- a/browser/themes/shared/readinglist/readinglist.inc.css
+++ b/browser/themes/shared/readinglist/readinglist.inc.css
@@ -1,27 +1,17 @@
 /* Reading List button */
 
 #urlbar:not([focused]):not(:hover) #readinglist-addremove-button {
   display: none;
 }
 
 #readinglist-addremove-button {
-  -moz-appearance: none;
-  border: none;
   list-style-image: url("chrome://browser/skin/readinglist/icons.svg#addpage");
-}
-
-#readinglist-addremove-button:hover {
-  border: none;
-}
-
-#readinglist-addremove-button > .toolbarbutton-icon {
-  width: 14px;
-  height: 14px
+  -moz-image-region: rect(0, 14px, 14px, 0);
 }
 
 #readinglist-addremove-button:hover {
   list-style-image: url("chrome://browser/skin/readinglist/icons.svg#addpage-hover");
 }
 
 #readinglist-addremove-button:active {
   list-style-image: url("chrome://browser/skin/readinglist/icons.svg#addpage-active");
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -1573,20 +1573,16 @@ richlistitem[type~="action"][actiontype=
 
 #page-report-button:hover:active,
 #page-report-button[open="true"] {
   -moz-image-region: rect(0, 48px, 16px, 32px);
 }
 
 %include ../shared/readinglist/readinglist.inc.css
 
-#readinglist-addremove-button {
-  padding: 0 2px;
-}
-
 /* Reader mode button */
 
 #reader-mode-button {
   list-style-image: url("chrome://browser/skin/readerMode.svg");
   -moz-image-region: rect(0, 16px, 16px, 0);
 }
 
 #reader-mode-button:hover,