Bug 1341586 - Fix localization of Inspector's attribute context menu by adding quotations to the values. r=gl
authordjmdev <djmdeveloper060796@gmail.com>
Thu, 23 Feb 2017 09:21:09 +0530
changeset 373495 6d5d1dfa86961f5e968c0566d673741c6d08774e
parent 373494 57775a0cc6f42b207d686499ffd847ebae0fcb03
child 373496 8b7597b2fffa3d67426dac03a67a4f67f767b66a
push id10863
push userjlorenzo@mozilla.com
push dateMon, 06 Mar 2017 23:02:23 +0000
treeherdermozilla-aurora@0931190cd725 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgl
bugs1341586
milestone54.0a1
Bug 1341586 - Fix localization of Inspector's attribute context menu by adding quotations to the values. r=gl Removed quotes from context menu item and added them to their respective localization string.
devtools/client/inspector/inspector.js
devtools/client/locales/en-US/inspector.properties
--- a/devtools/client/inspector/inspector.js
+++ b/devtools/client/inspector/inspector.js
@@ -1285,33 +1285,33 @@ Inspector.prototype = {
       label: INSPECTOR_L10N.getStr("inspectorAddAttribute.label"),
       accesskey: INSPECTOR_L10N.getStr("inspectorAddAttribute.accesskey"),
       disabled: !isEditableElement,
       click: () => this.onAddAttribute(),
     }));
     attributesSubmenu.append(new MenuItem({
       id: "node-menu-copy-attribute",
       label: INSPECTOR_L10N.getFormatStr("inspectorCopyAttributeValue.label",
-                                        isAttributeClicked ? `"${nodeInfo.value}"` : ""),
+                                        isAttributeClicked ? `${nodeInfo.value}` : ""),
       accesskey: INSPECTOR_L10N.getStr("inspectorCopyAttributeValue.accesskey"),
       disabled: !isAttributeClicked,
       click: () => this.onCopyAttributeValue(),
     }));
     attributesSubmenu.append(new MenuItem({
       id: "node-menu-edit-attribute",
       label: INSPECTOR_L10N.getFormatStr("inspectorEditAttribute.label",
-                                        isAttributeClicked ? `"${nodeInfo.name}"` : ""),
+                                        isAttributeClicked ? `${nodeInfo.name}` : ""),
       accesskey: INSPECTOR_L10N.getStr("inspectorEditAttribute.accesskey"),
       disabled: !isAttributeClicked,
       click: () => this.onEditAttribute(),
     }));
     attributesSubmenu.append(new MenuItem({
       id: "node-menu-remove-attribute",
       label: INSPECTOR_L10N.getFormatStr("inspectorRemoveAttribute.label",
-                                        isAttributeClicked ? `"${nodeInfo.name}"` : ""),
+                                        isAttributeClicked ? `${nodeInfo.name}` : ""),
       accesskey: INSPECTOR_L10N.getStr("inspectorRemoveAttribute.accesskey"),
       disabled: !isAttributeClicked,
       click: () => this.onRemoveAttribute(),
     }));
 
     return attributesSubmenu;
   },
 
--- a/devtools/client/locales/en-US/inspector.properties
+++ b/devtools/client/locales/en-US/inspector.properties
@@ -102,31 +102,31 @@ inspector.menu.copyUrlToClipboard.label=
 # element in the DOM (like with <label for="input-id">), and that allows to
 # select that element in the inspector.
 inspector.menu.selectElement.label=Select Element #%S
 
 # LOCALIZATION NOTE (inspectorEditAttribute.label): This is the label of a
 # sub-menu "Attribute" in the inspector contextual-menu that appears
 # when the user right-clicks on the node in the inspector, and that allows
 # to edit an attribute on this node.
-inspectorEditAttribute.label=Edit Attribute %S
+inspectorEditAttribute.label=Edit Attribute "%S"
 inspectorEditAttribute.accesskey=E
 
 # LOCALIZATION NOTE (inspectorRemoveAttribute.label): This is the label of a
 # sub-menu "Attribute" in the inspector contextual-menu that appears
 # when the user right-clicks on the attribute of a node in the inspector,
 # and that allows to remove this attribute.
-inspectorRemoveAttribute.label=Remove Attribute %S
+inspectorRemoveAttribute.label=Remove Attribute "%S"
 inspectorRemoveAttribute.accesskey=R
 
 # LOCALIZATION NOTE (inspectorCopyAttributeValue.label): This is the label of a
 # sub-menu "Attribute" in the inspector contextual-menu that appears
 # when the user right-clicks on the attribute of a node in the inspector,
 # and that allows to copy the attribute value to clipboard.
-inspectorCopyAttributeValue.label=Copy Attribute Value %S
+inspectorCopyAttributeValue.label=Copy Attribute Value "%S"
 inspectorCopyAttributeValue.accesskey=V
 
 # LOCALIZATION NOTE (inspector.nodePreview.selectNodeLabel):
 # This string is displayed in a tooltip that is shown when hovering over a DOM
 # node preview (e.g. something like "div#foo.bar").
 # DOM node previews can be displayed in places like the animation-inspector, the
 # console or the object inspector.
 # The tooltip invites the user to click on the node in order to select it in the