servo: Merge #15696 - Do not pool HTTP connections (from jdm:no-http-pool); r=emilio
authorJosh Matthews <josh@joshmatthews.net>
Thu, 23 Feb 2017 03:55:45 -0800
changeset 373521 6b8aba91bf73cfc89e21ef402b25dca5fa469ceb
parent 373520 17c17916321826e2d0ee56e033d6b06fc3d6782c
child 373522 ff243ef8853142dd0a99d71569e00d12fb97c1d9
push id10863
push userjlorenzo@mozilla.com
push dateMon, 06 Mar 2017 23:02:23 +0000
treeherdermozilla-aurora@0931190cd725 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersemilio
milestone54.0a1
servo: Merge #15696 - Do not pool HTTP connections (from jdm:no-http-pool); r=emilio HTTP connection pooling triggers consistent failures in #14620. Let's disable it until there's more time to solve the underlying problem in #15694. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes Source-Repo: https://github.com/servo/servo Source-Revision: a780f6f28cf5d0f4faa7ad84822692d9bab1d031
servo/components/net/resource_thread.rs
--- a/servo/components/net/resource_thread.rs
+++ b/servo/components/net/resource_thread.rs
@@ -320,17 +320,18 @@ impl CoreResourceManager {
              init: RequestInit,
              mut sender: IpcSender<FetchResponseMsg>,
              group: &ResourceGroup) {
         let http_state = HttpState {
             hsts_list: group.hsts_list.clone(),
             cookie_jar: group.cookie_jar.clone(),
             auth_cache: group.auth_cache.clone(),
             blocked_content: BLOCKED_CONTENT_RULES.clone(),
-            connector_pool: group.connector.clone(),
+            // FIXME(#15694): use group.connector.clone() instead.
+            connector_pool: create_http_connector("certs"),
         };
         let ua = self.user_agent.clone();
         let dc = self.devtools_chan.clone();
         let filemanager = self.filemanager.clone();
 
         thread::Builder::new().name(format!("fetch thread for {}", init.url)).spawn(move || {
             let request = Request::from_init(init);
             // XXXManishearth: Check origin against pipeline id (also ensure that the mode is allowed)