Bug 402104 - Places Organizer window misses accesskeys. Patch by Cedric Corazza, r=me.
authormozilla.mano@sent.com
Mon, 14 Jan 2008 14:37:12 -0800
changeset 10264 61018e3d395372fa4653728d00a2a93536a384c7
parent 10263 59b218ca5f5dd62a663f6418e27e64737d7bbb1e
child 10265 772c3eeb3609e992393169f81b8d6a02ac73e5dd
push idunknown
push userunknown
push dateunknown
reviewersme
bugs402104
milestone1.9b3pre
Bug 402104 - Places Organizer window misses accesskeys. Patch by Cedric Corazza, r=me.
browser/components/places/content/editBookmarkOverlay.xul
browser/components/places/content/places.js
browser/components/places/content/places.xul
browser/locales/en-US/chrome/browser/places/editBookmarkOverlay.dtd
browser/locales/en-US/chrome/browser/places/places.dtd
--- a/browser/components/places/content/editBookmarkOverlay.xul
+++ b/browser/components/places/content/editBookmarkOverlay.xul
@@ -55,16 +55,17 @@
     <grid id="editBookmarkPanelGrid" flex="1">
       <columns>
         <column/>
         <column flex="1"/>
       </columns>
       <rows>
         <row align="center" id="editBMPanel_nameRow">
           <label value="&editBookmarkOverlay.name.label;"
+                 accesskey="&editBookmarkOverlay.name.accesskey;"
                  control="editBMPanel_namePicker"
                  observes="paneElementsBroadcaster"/>
           <menulist id="editBMPanel_namePicker"
                     flex="1"
                     editable="true"
                     droppable="false"
                     oninput="gEditItemOverlay.onNamePickerInput();"
                     onblur="gEditItemOverlay.onNamePickerChange();"
@@ -77,34 +78,37 @@
                 <label value="&editBookmarkOverlay.liveTitlesSeparator.label;"/>
               </menuitem>
             </menupopup>
           </menulist>
         </row>
 
         <row align="center" id="editBMPanel_locationRow">
           <label value="&editBookmarkOverlay.location.label;"
+                 accesskey="&editBookmarkOverlay.location.accesskey;"
                  control="editBMPanel_locationField"
                  observes="paneElementsBroadcaster"/>
           <textbox id="editBMPanel_locationField"
                    onblur="gEditItemOverlay.onLocationFieldBlur();"
                    observes="paneElementsBroadcaster"/>
         </row>
 
         <row align="center" id="editBMPanel_feedLocationRow">
           <label value="&editBookmarkOverlay.feedLocation.label;"
+                 accesskey="&editBookmarkOverlay.feedLocation.accesskey;"
                  control="editBMPanel_feedLocationField"
                  observes="paneElementsBroadcaster"/>
           <textbox id="editBMPanel_feedLocationField"
                    onblur="gEditItemOverlay.onFeedLocationFieldBlur();"
                    observes="paneElementsBroadcaster"/>
         </row>
 
         <row align="center" id="editBMPanel_siteLocationRow">
           <label value="&editBookmarkOverlay.siteLocation.label;"
+                 accesskey="&editBookmarkOverlay.siteLocation.accesskey;"
                  control="editBMPanel_siteLocationField"
                  observes="paneElementsBroadcaster"/>
           <textbox id="editBMPanel_siteLocationField"
                    onblur="gEditItemOverlay.onSiteLocationFieldBlur();"
                    observes="paneElementsBroadcaster"/>
         </row>
 
         <row align="center" id="editBMPanel_folderRow">
@@ -146,16 +150,17 @@
           <treecols>
             <treecol anonid="title" flex="1" primary="true" hideheader="true"/>
           </treecols>
           <treechildren flex="1"/>
         </tree>
 
         <row align="center" id="editBMPanel_tagsRow">
           <label value="&editBookmarkOverlay.tags.label;"
+                 accesskey="&editBookmarkOverlay.tags.accesskey;"
                  control="editBMPanel_tagsField"
                  observes="paneElementsBroadcaster"/>
           <textbox id="editBMPanel_tagsField"
                    onblur="gEditItemOverlay.onTagsFieldBlur();"
                    observes="paneElementsBroadcaster"/>
           <button id="editBMPanel_tagsSelectorExpander"
                   class="expander-down"
                   tooltiptext="&editBookmarkOverlay.tagsExpanderDown.tooltip;"
@@ -166,32 +171,35 @@
         </row>
 
         <listbox id="editBMPanel_tagsSelector"
                  height="150" collapsed="true"
                  observes="paneElementsBroadcaster"/>
 
         <row id="editBMPanel_keywordRow">
           <label value="&editBookmarkOverlay.keyword.label;"
+                 accesskey="&editBookmarkOverlay.keyword.accesskey;"
                  control="editBMPanel_keywordField"
                  observes="paneElementsBroadcaster"/>
           <textbox id="editBMPanel_keywordField"
                    onblur="gEditItemOverlay.onKeywordFieldBlur();"
                    observes="paneElementsBroadcaster"/>
         </row>
 
         <row id="editBMPanel_descriptionRow">
           <label value="&editBookmarkOverlay.description.label;"
+                 accesskey="&editBookmarkOverlay.description.accesskey;"
                  control="editBMPanel_descriptionField"
                  observes="paneElementsBroadcaster"/>
           <textbox id="editBMPanel_descriptionField"
                    multiline="true"
                    onblur="gEditItemOverlay.onDescriptionFieldBlur();"
                    observes="paneElementsBroadcaster"/>
         </row>
         <checkbox id="editBMPanel_loadInSidebarCheckbox"
                   label="&editBookmarkOverlay.loadInSidebar.label;"
+                  accesskey="&editBookmarkOverlay.loadInSidebar.accesskey;"
                   oncommand="gEditItemOverlay.onLoadInSidebarCheckboxCommand();"
                   observes="paneElementsBroadcaster"/>
       </rows>
     </grid>
   </vbox>
 </overlay>
--- a/browser/components/places/content/places.js
+++ b/browser/components/places/content/places.js
@@ -609,20 +609,22 @@ var PlacesOrganizer = {
   },
 
   toggleAdditionalInfoFields: function PO_toggleAdditionalInfoFields() {
     var infoScrollbox = document.getElementById("infoScrollbox");
     var scrollboxExpander = document.getElementById("infoScrollboxExpander");
     if (infoScrollbox.getAttribute("minimal") == "true") {
       infoScrollbox.removeAttribute("minimal");
       scrollboxExpander.label = scrollboxExpander.getAttribute("lesslabel");
+      scrollboxExpander.accessKey = scrollboxExpander.getAttribute("lessaccesskey");
     }
     else {
       infoScrollbox.setAttribute("minimal", "true");
       scrollboxExpander.label = scrollboxExpander.getAttribute("morelabel");
+      scrollboxExpander.accessKey = scrollboxExpander.getAttribute("moreaccesskey");
     }
   },
 
   /**
    * Save the current search (or advanced query) to the bookmarks root.
    */
   saveSearch: function PO_saveSearch() {
     // Get the place: uri for the query.
--- a/browser/components/places/content/places.xul
+++ b/browser/components/places/content/places.xul
@@ -447,18 +447,21 @@
                   </description>
                   <spacer flex="3"/>
                 </vbox>
                 <scrollbox id="infoScrollbox" minimal="true" orient="vertical" flex="1" style='overflow: auto;'>
                   <vbox id="editBookmarkPanelContent"/>
                   <hbox>
                     <button type="image" id="infoScrollboxExpander"
                             lesslabel="&detailsPane.less.label;"
+                            lessaccesskey="&detailsPane.less.accesskey;"
                             morelabel="&detailsPane.more.label;"
+                            moreaccesskey="&detailsPane.more.accesskey;"
                             label="&detailsPane.more.label;"
+                            accesskey="&detailsPane.more.accesskey;"
                             oncommand="PlacesOrganizer.toggleAdditionalInfoFields();"
                             observes="paneElementsBroadcaster"/>
                     <spacer flex="1"/>
                   </hbox>
                 </scrollbox>
               </deck>
             </hbox>
           </vbox>
--- a/browser/locales/en-US/chrome/browser/places/editBookmarkOverlay.dtd
+++ b/browser/locales/en-US/chrome/browser/places/editBookmarkOverlay.dtd
@@ -1,13 +1,21 @@
 <!ENTITY editBookmarkOverlay.name.label                      "Name:">
+<!ENTITY editBookmarkOverlay.name.accesskey                  "N">
 <!ENTITY editBookmarkOverlay.location.label                  "Location:">
+<!ENTITY editBookmarkOverlay.location.accesskey              "L">
 <!ENTITY editBookmarkOverlay.feedLocation.label              "Feed Location:">
+<!ENTITY editBookmarkOverlay.feedLocation.accesskey          "F">
 <!ENTITY editBookmarkOverlay.siteLocation.label              "Site Location:">
+<!ENTITY editBookmarkOverlay.siteLocation.accesskey          "S">
 <!ENTITY editBookmarkOverlay.liveTitlesSeparator.label       "Live Titles">
 <!ENTITY editBookmarkOverlay.folder.label                    "Folder:">
 <!ENTITY editBookmarkOverlay.foldersExpanderDown.tooltip     "Show all the bookmarks folders">
 <!ENTITY editBookmarkOverlay.expanderUp.tooltip              "Hide">
 <!ENTITY editBookmarkOverlay.tags.label                      "Tags:">
+<!ENTITY editBookmarkOverlay.tags.accesskey                  "T">
 <!ENTITY editBookmarkOverlay.description.label               "Description:">
+<!ENTITY editBookmarkOverlay.description.accesskey           "D">
 <!ENTITY editBookmarkOverlay.keyword.label                   "Keyword:">
+<!ENTITY editBookmarkOverlay.keyword.accesskey               "K">
 <!ENTITY editBookmarkOverlay.tagsExpanderDown.tooltip        "Show all tags">
 <!ENTITY editBookmarkOverlay.loadInSidebar.label             "Load this bookmark in the sidebar">
+<!ENTITY editBookmarkOverlay.loadInSidebar.accesskey         "h">
--- a/browser/locales/en-US/chrome/browser/places/places.dtd
+++ b/browser/locales/en-US/chrome/browser/places/places.dtd
@@ -199,11 +199,13 @@
 <!ENTITY backCmd.accesskey   "B">
 <!ENTITY backButton.tooltip  "Go back">
 
 <!ENTITY forwardCmd.label       "Forward">
 <!ENTITY forwardCmd.accesskey   "F">
 <!ENTITY forwardButton.tooltip  "Go forward">
 
 <!ENTITY detailsPane.more.label "More">
+<!ENTITY detailsPane.more.accesskey "e">
 <!ENTITY detailsPane.less.label "Less">
+<!ENTITY detailsPane.less.accesskey "e">
 <!ENTITY detailsPane.noPreviewAvailable.label "Preview">
 <!ENTITY detailsPane.selectAnItemText.description "Select an item to view and edit its properties">