Bug 889885 - Avoid releasing scripted observers from PSM off the main thread. r=bsmith a=bajaj
--- a/security/manager/ssl/src/PSMRunnable.h
+++ b/security/manager/ssl/src/PSMRunnable.h
@@ -3,16 +3,17 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef PSMRunnable_h
#define PSMRunnable_h
#include "mozilla/Monitor.h"
#include "nsThreadUtils.h"
#include "nsIObserver.h"
+#include "nsProxyRelease.h"
namespace mozilla { namespace psm {
// Wait for the event to run on the target thread without spinning the event
// loop on the calling thread. (Dispatching events to a thread using
// NS_DISPATCH_SYNC would cause the event loop on the calling thread to spin.)
class SyncRunnableBase : public nsRunnable
{
@@ -26,18 +27,20 @@ private:
mozilla::Monitor monitor;
};
class NotifyObserverRunnable : public nsRunnable
{
public:
NotifyObserverRunnable(nsIObserver * observer,
const char * topicStringLiteral)
- : mObserver(), mTopic(topicStringLiteral) { mObserver = observer; }
+ : mObserver(), mTopic(topicStringLiteral) {
+ mObserver = new nsMainThreadPtrHolder<nsIObserver>(observer);
+ }
NS_DECL_NSIRUNNABLE
private:
- nsCOMPtr<nsIObserver> mObserver;
+ nsMainThreadPtrHandle<nsIObserver> mObserver;
const char * const mTopic;
};
} } // namespace mozilla::psm
#endif