Bug 844181 - Fix testing-impacting only failure in crashes provider; r=me, a=bustage + test-only + dolske
authorGregory Szorc <gps@mozilla.com>
Fri, 01 Mar 2013 23:56:41 -0800
changeset 128477 5d5e8ec04d862dec5e7242cd8332b581c126c973
parent 128476 00e8a50057cc709f3d310789a879db20f2d08028
child 128478 7a909ecf04bd2e9144ae258639917cd2473efc1c
push id3430
push usergszorc@mozilla.com
push dateSat, 02 Mar 2013 07:58:22 +0000
treeherdermozilla-aurora@5d5e8ec04d86 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme, bustage
bugs844181
milestone21.0a2
Bug 844181 - Fix testing-impacting only failure in crashes provider; r=me, a=bustage + test-only + dolske The code this is patching was green on mozilla-central a little over a week ago and is now failing on Aurora for an unknown reason. There is a legitimate bug and the fix is trivial. The xpcshell failure this fixes was only occurring on Windows and appeared to be intermittent (although there was only 1 success out of 8+ runs). The change only impacts test code because the added return statement prevents a race condition that should only occur during tests. After a discussion in #developers, it was decided that because of the trivial nature of the fix and the alternative of backing out FHR would be drastic, that it would be OK to push this without explicit approval from one of the usual suspects.
services/healthreport/providers.jsm
--- a/services/healthreport/providers.jsm
+++ b/services/healthreport/providers.jsm
@@ -759,17 +759,17 @@ function DailyCrashesMeasurement() {
 DailyCrashesMeasurement.prototype = Object.freeze({
   __proto__: Metrics.Measurement.prototype,
 
   name: "crashes",
   version: 1,
 
   configureStorage: function () {
     this.registerStorageField("pending", this.storage.FIELD_DAILY_COUNTER);
-    this.registerStorageField("submitted", this.storage.FIELD_DAILY_COUNTER);
+    return this.registerStorageField("submitted", this.storage.FIELD_DAILY_COUNTER);
   },
 });
 
 this.CrashesProvider = function () {
   Metrics.Provider.call(this);
 };
 
 CrashesProvider.prototype = Object.freeze({