Bug 714829 - Unused StringBuffer is created in GeckoApp.addEnvToIntent [r=dougt]
authorMark Finkle <mfinkle@mozilla.com>
Tue, 03 Jan 2012 12:19:51 -0500
changeset 84921 5bbbb0127380504fccaaacb64e807a74af9cb789
parent 84920 91e7e04c53b5f3a6a6e09902fb265b93320ca677
child 84922 7f4ccc0e14d32631b78053853bd0ab923fa33657
push id805
push userakeybl@mozilla.com
push dateWed, 01 Feb 2012 18:17:35 +0000
treeherdermozilla-aurora@6fb3bf232436 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdougt
bugs714829
milestone12.0a1
Bug 714829 - Unused StringBuffer is created in GeckoApp.addEnvToIntent [r=dougt]
embedding/android/GeckoApp.java
mobile/android/base/GeckoApp.java
--- a/embedding/android/GeckoApp.java
+++ b/embedding/android/GeckoApp.java
@@ -688,17 +688,16 @@ abstract public class GeckoApp
         outFile.setLastModified(fileEntry.getTime());
         return true;
     }
 
     public void addEnvToIntent(Intent intent) {
         Map<String,String> envMap = System.getenv();
         Set<Map.Entry<String,String>> envSet = envMap.entrySet();
         Iterator<Map.Entry<String,String>> envIter = envSet.iterator();
-        StringBuffer envstr = new StringBuffer();
         int c = 0;
         while (envIter.hasNext()) {
             Map.Entry<String,String> entry = envIter.next();
             intent.putExtra("env" + c, entry.getKey() + "="
                             + entry.getValue());
             c++;
         }
     }
--- a/mobile/android/base/GeckoApp.java
+++ b/mobile/android/base/GeckoApp.java
@@ -1843,17 +1843,16 @@ abstract public class GeckoApp
 
     abstract public String getPackageName();
     abstract public String getContentProcessName();
 
     public void addEnvToIntent(Intent intent) {
         Map<String,String> envMap = System.getenv();
         Set<Map.Entry<String,String>> envSet = envMap.entrySet();
         Iterator<Map.Entry<String,String>> envIter = envSet.iterator();
-        StringBuffer envstr = new StringBuffer();
         int c = 0;
         while (envIter.hasNext()) {
             Map.Entry<String,String> entry = envIter.next();
             intent.putExtra("env" + c, entry.getKey() + "="
                             + entry.getValue());
             c++;
         }
     }