Bug 697043 - GCLI's inspect command should use an overlay rather than direct node manipulation; r=dcamp
authorJoe Walker <jwalker@mozilla.com>
Fri, 27 Jan 2012 13:42:05 +0000
changeset 86785 50250bac846bfd658847dc822e57f20b970b5f81
parent 86784 8dcdd01df6842ab086be219dee1c7428276a3c4a
child 86786 a5d23f7e5cb56cb7350fd6223d22cec3ab1386be
push id805
push userakeybl@mozilla.com
push dateWed, 01 Feb 2012 18:17:35 +0000
treeherdermozilla-aurora@6fb3bf232436 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdcamp
bugs697043
milestone12.0a1
Bug 697043 - GCLI's inspect command should use an overlay rather than direct node manipulation; r=dcamp
browser/devtools/webconsole/gcli.jsm
--- a/browser/devtools/webconsole/gcli.jsm
+++ b/browser/devtools/webconsole/gcli.jsm
@@ -3598,25 +3598,18 @@ NodeType.prototype.name = 'node';
 define('gcli/host', ['require', 'exports', 'module' ], function(require, exports, module) {
 
 
 /**
  * Helper to turn a node background it's complementary color for 1 second.
  * There is likely a better way to do this, but this will do for now.
  */
 exports.flashNode = function(node, color) {
-  if (!node.__gcliHighlighting) {
-    node.__gcliHighlighting = true;
-    var original = node.style.background;
-    node.style.background = color;
-    setTimeout(function() {
-      node.style.background = original;
-      delete node.__gcliHighlighting;
-    }, 1000);
-  }
+  // We avoid changing the DOM under firefox developer tools so this is a no-op
+  // In future we will use the multi-highlighter implemented in bug 653545.
 };
 
 
 });
 /*
  * Copyright 2009-2011 Mozilla Foundation and contributors
  * Licensed under the New BSD license. See LICENSE.txt or:
  * http://opensource.org/licenses/BSD-3-Clause