Bug 1270886 - only use lwtheme styling for search bar borders in the main toolbox, r=dao
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Mon, 09 May 2016 17:03:48 +0100
changeset 321082 4dd60a8b9e2b229e8551c08ad4302433081ecced
parent 321081 6ec6d9e1f660dd473ce69648fe1863792e4e740c
child 321083 ea89f71fc38e4f4627b3e3075159cddc31aae645
push id9671
push userraliiev@mozilla.com
push dateMon, 06 Jun 2016 20:27:52 +0000
treeherdermozilla-aurora@cea65ca3d0bd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1270886
milestone49.0a1
Bug 1270886 - only use lwtheme styling for search bar borders in the main toolbox, r=dao This is still not completely perfect in that in principle it is possible for add-ons to add toolbars that they force to be non-transparent, but there is no way to select for that. Keeping a list of toolbars we know are transparent would break the more common case of third-party toolbars that do behave 'normally' when used with lightweight themes. So for now, just assume navigator-toolbox is all transparent when a lwtheme is in use. MozReview-Commit-ID: 4I8l3Bn7DQf
browser/themes/linux/browser.css
browser/themes/windows/browser.css
--- a/browser/themes/linux/browser.css
+++ b/browser/themes/linux/browser.css
@@ -814,17 +814,17 @@ menuitem:not([type]):not(.menuitem-toolt
   list-style-image: url("chrome://global/skin/icons/Close.gif");
 }
 
 /* Location bar */
 #main-window {
   --urlbar-border-color: ThreeDShadow;
 }
 
-#main-window:-moz-lwtheme {
+#navigator-toolbox:-moz-lwtheme {
   --urlbar-border-color: rgba(0,0,0,.3);
 }
 
 #urlbar,
 .searchbar-textbox {
   -moz-appearance: none;
   padding: 0;
   border: 1px solid var(--urlbar-border-color);
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -1096,17 +1096,17 @@ toolbar[brighttext] .toolbarbutton-1 > .
 
 /* ::::: Location Bar ::::: */
 
 #main-window {
   --urlbar-border-color: ThreeDShadow;
   --urlbar-border-color-hover: var(--urlbar-border-color);
 }
 
-#main-window:-moz-lwtheme {
+#navigator-toolbox:-moz-lwtheme {
   --urlbar-border-color: var(--toolbarbutton-hover-bordercolor);
 }
 
 @media (-moz-windows-default-theme) {
   @media (-moz-os-version: windows-vista),
          (-moz-os-version: windows-win7),
          (-moz-os-version: windows-win8) {
     #main-window:not(:-moz-lwtheme) {