Bug 1350887 - Warn when non-loopback connections are allowed; r=whimboo, a=test-only
authorAndreas Tolfsen <ato@mozilla.com>
Tue, 28 Mar 2017 17:06:06 +0100
changeset 375743 4ab26e8674260f8a1e4dc89c1e10efa2ba544c9b
parent 375742 39f487bdf0a3cafd1f19d63f52b6ea3205361523
child 375744 eb0d361dc73c32867d5fd54dc47733994bd48e7a
push id11019
push userryanvm@gmail.com
push dateWed, 05 Apr 2017 21:18:17 +0000
treeherdermozilla-aurora@eb0d361dc73c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerswhimboo, test-only
bugs1350887
milestone54.0a2
Bug 1350887 - Warn when non-loopback connections are allowed; r=whimboo, a=test-only MozReview-Commit-ID: LG8f5q5QbD6
testing/marionette/server.js
--- a/testing/marionette/server.js
+++ b/testing/marionette/server.js
@@ -319,16 +319,18 @@ server.TCPListener = class {
           this.alteredPrefs.add(k);
         }
       }
     }
 
     let flags = Ci.nsIServerSocket.KeepWhenOffline;
     if (this.forceLocal) {
       flags |= Ci.nsIServerSocket.LoopbackOnly;
+    } else {
+      logger.warn("Server socket is not limited to loopback connections");
     }
     this.listener = new ServerSocket(this.port, flags, 1);
     this.listener.asyncListen(this);
 
     this.alive = true;
     this._acceptConnections = true;
   }