Bug 423169 (and likely bug 423163) - drag and drop to bookmarks toolbar is broken. Patch by Michael Schonfeld <dev@schonfeld.org>, r=me.
authormozilla.mano@sent.com
Sun, 16 Mar 2008 23:34:57 -0700
changeset 13164 41cb077459799ee1596a3590acdd8cd7389a9924
parent 13163 941ced6f9e4c80067d4cad9289a82428be48b39b
child 13165 100062f1913dc24a4d66c568305bffc68cca30a5
push idunknown
push userunknown
push dateunknown
reviewersme
bugs423169, 423163
milestone1.9b5pre
Bug 423169 (and likely bug 423163) - drag and drop to bookmarks toolbar is broken. Patch by Michael Schonfeld <dev@schonfeld.org>, r=me.
browser/components/places/content/menu.xml
browser/components/places/content/toolbar.xml
--- a/browser/components/places/content/menu.xml
+++ b/browser/components/places/content/menu.xml
@@ -310,17 +310,17 @@
             dropPoint.ip = new InsertionPoint(resultNode.itemId, -1, 1);
             dropPoint.beforeIndex = -1;
             return dropPoint;
         ]]></body>
       </method>
 
       <method name="canDrop">
         <body><![CDATA[
-          var ip = this.insertionPoint;
+          var ip = this._rootView.insertionPoint;
           return ip && PlacesControllerDragHelper.canDrop(ip);
         ]]></body>
       </method>
 
       <!-- Sub-menus should be opened when the mouse drags over them, and closed
            when the mouse drags off.  The overFolder object manages opening and
            closing of folders when the mouse hovers. -->
       <field name="_overFolder"><![CDATA[({
--- a/browser/components/places/content/toolbar.xml
+++ b/browser/components/places/content/toolbar.xml
@@ -820,17 +820,17 @@
           this._self.focus();
           xferData.data = this._self._controller.getTransferData(dragAction.action);
 #ifdef XP_WIN
           return true;
 #endif
         },
 
         canDrop: function TBV_DO_canDrop(event, session) {
-          var ip = this.insertionPoint;
+          var ip = this._self.insertionPoint;
           return ip && PlacesControllerDragHelper.canDrop(ip);
         },
 
         onDragOver: function TBV_DO_onDragOver(event, flavor, session) {
           PlacesControllerDragHelper.currentDropTarget = event.target;
           var dropPoint = this._getDropPoint(event);
 
           var ib = this._self._dropIndicatorBar;