Bug 1300663 - Catch HTTPError when query for symbols url. r=jlund, a=test-only
authorArmen Zambrano Gasparnian <armenzg@mozilla.com>
Fri, 23 Sep 2016 13:37:58 -0400
changeset 340247 3f844a9c455756d243650d2f89730cd4d723ba88
parent 340246 bed31970262c50f05f33876debd00affd8e575e4
child 340248 e1501ff97cdb8799e75dad600e03e65c1bfb5b5d
push id10069
push userryanvm@gmail.com
push dateTue, 27 Sep 2016 21:28:07 +0000
treeherdermozilla-aurora@1283217c5463 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjlund, test-only
bugs1300663
milestone51.0a2
Bug 1300663 - Catch HTTPError when query for symbols url. r=jlund, a=test-only If we don't catch HTTPError, the whole job fails since we get an uncaught exception. MozReview-Commit-ID: 8jwW7ZSieyC
testing/mozharness/mozharness/mozilla/testing/testbase.py
--- a/testing/mozharness/mozharness/mozilla/testing/testbase.py
+++ b/testing/mozharness/mozharness/mozilla/testing/testbase.py
@@ -194,17 +194,17 @@ class TestingMixin(VirtualenvMixin, Buil
         elif self.installer_url:
             symbols_url = self.query_prefixed_build_dir_url('.crashreporter-symbols.zip')
 
             # Check if the URL exists. If not, use none to allow mozcrash to auto-check for symbols
             try:
                 if symbols_url:
                     self._urlopen(symbols_url, timeout=120)
                     self.symbols_url = symbols_url
-            except (urllib2.URLError, socket.error, socket.timeout):
+            except (urllib2.HTTPError, urllib2.URLError, socket.error, socket.timeout):
                 self.exception("Can't figure out symbols_url from installer_url: %s!" % self.installer_url, level=WARNING)
 
         # If no symbols URL can be determined let minidump_stackwalk query the symbols.
         # As of now this only works for Nightly and release builds.
         if not self.symbols_url:
             self.warning("No symbols_url found. Let minidump_stackwalk query for symbols.")
 
         return self.symbols_url