Bug 1244166 - Don't ignore stroke/fill properties in high-contrast mode, since doing so can produce icons that are invisible or whose colors are unrelated to the user's chosen high-contrast colors. r=longsonr, a=lizzard
authorDaniel Holbert <dholbert@cs.stanford.edu>
Mon, 01 Feb 2016 11:23:09 -0800
changeset 303770 347963c97481a309675e018c92eaf6c574759aaf
parent 303769 48111b5e5b2b4014c536fe87c7ec71948d9adfe9
child 303771 4b8fab96a86d5cf8b3c7b6a663da76d4e1bc3eb4
push id9013
push usercbook@mozilla.com
push dateThu, 04 Feb 2016 10:40:35 +0000
treeherdermozilla-aurora@bdaf65deb7b3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslongsonr, lizzard
bugs1244166
milestone46.0a2
Bug 1244166 - Don't ignore stroke/fill properties in high-contrast mode, since doing so can produce icons that are invisible or whose colors are unrelated to the user's chosen high-contrast colors. r=longsonr, a=lizzard
layout/style/nsCSSPropList.h
--- a/layout/style/nsCSSPropList.h
+++ b/layout/style/nsCSSPropList.h
@@ -3955,18 +3955,17 @@ CSS_PROP_SVGRESET(
     VARIANT_HK,
     kDominantBaselineKTable,
     offsetof(nsStyleSVGReset, mDominantBaseline),
     eStyleAnimType_EnumU8)
 CSS_PROP_SVG(
     fill,
     fill,
     Fill,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_IGNORED_WHEN_COLORS_DISABLED,
+    CSS_PROPERTY_PARSE_FUNCTION,
     "",
     0,
     kContextPatternKTable,
     offsetof(nsStyleSVG, mFill),
     eStyleAnimType_PaintServer)
 CSS_PROP_SVG(
     fill-opacity,
     fill_opacity,
@@ -4125,18 +4124,17 @@ CSS_PROP_SVGRESET(
     VARIANT_HN,
     nullptr,
     offsetof(nsStyleSVGReset, mStopOpacity),
     eStyleAnimType_float)
 CSS_PROP_SVG(
     stroke,
     stroke,
     Stroke,
-    CSS_PROPERTY_PARSE_FUNCTION |
-        CSS_PROPERTY_IGNORED_WHEN_COLORS_DISABLED,
+    CSS_PROPERTY_PARSE_FUNCTION,
     "",
     0,
     kContextPatternKTable,
     offsetof(nsStyleSVG, mStroke),
     eStyleAnimType_PaintServer)
 CSS_PROP_SVG(
     stroke-dasharray,
     stroke_dasharray,