Bug 1295536 - Update performance schema to treeherder latest;r=jmaher
☠☠ backed out by 8d682fddd924 ☠ ☠
authorWilliam Lachance <wlachance@mozilla.com>
Tue, 16 Aug 2016 13:30:06 -0400
changeset 336373 31cde7bb6a9e20cfffe822a9b531144234db6f7b
parent 336372 3c5392487166bfb6b4733278bd6b353eaf2ae2b2
child 336374 a22d1d1dbb3e7fd7a446c5bc6b6ce927eb4c62e7
push id10033
push userraliiev@mozilla.com
push dateMon, 19 Sep 2016 13:50:26 +0000
treeherdermozilla-aurora@5dddbefdf759 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs1295536
milestone51.0a1
Bug 1295536 - Update performance schema to treeherder latest;r=jmaher This new version of the schema validates that numeric values are within an acceptable range (i.e. are not infinite) MozReview-Commit-ID: 32oT39Bfcwg
testing/mozharness/external_tools/performance-artifact-schema.json
--- a/testing/mozharness/external_tools/performance-artifact-schema.json
+++ b/testing/mozharness/external_tools/performance-artifact-schema.json
@@ -13,47 +13,57 @@
             "properties": {
                 "name": {
                     "title": "Subtest name",
                     "type": "string"
                 },
                 "value": {
                     "description": "Summary value for subtest",
                     "title": "Subtest value",
-                    "type": "number"
+                    "type": "number",
+                    "minimum": -1000000000000.0,
+                    "maximum": 1000000000000.0
                 },
                 "lowerIsBetter": {
                     "description": "Whether lower values are better for subtest",
                     "title": "Lower is better",
                     "type": "boolean"
                 },
                 "shouldAlert": {
                     "description": "Whether we should alert",
                     "title": "Should alert",
                     "type": "boolean"
                 },
                 "alertThreshold": {
                     "description": "% change threshold before alerting",
                     "title": "Alert threshold",
-                    "type": "number"
+                    "type": "number",
+                    "minimum": 0.0,
+                    "maximum": 1000.0
                 },
                 "minBackWindow": {
                     "description": "Minimum back window to use for alerting",
                     "title": "Minimum back window",
-                    "type": "number"
+                    "type": "number",
+                    "minimum": 1,
+                    "maximum": 255
                 },
                 "maxBackWindow": {
                     "description": "Maximum back window to use for alerting",
                     "title": "Maximum back window",
-                    "type": "number"
+                    "type": "number",
+                    "minimum": 1,
+                    "maximum": 255
                 },
                 "foreWindow": {
                     "description": "Fore window to use for alerting",
                     "title": "Fore window",
-                    "type": "number"
+                    "type": "number",
+                    "minimum": 1,
+                    "maximum": 255
                 }
             },
             "required": [
                 "name",
                 "value"
             ],
             "type": "object"
         },
@@ -75,47 +85,57 @@
                     "items": {
                         "$ref": "#/definitions/subtest_schema"
                     },
                     "title": "Subtests",
                     "type": "array"
                 },
                 "value": {
                     "title": "Suite value",
-                    "type": "number"
+                    "type": "number",
+                    "minimum": -1000000000000.0,
+                    "maximum": 1000000000000.0
                 },
                 "lowerIsBetter": {
                     "description": "Whether lower values are better for suite",
                     "title": "Lower is better",
                     "type": "boolean"
                 },
                 "shouldAlert": {
                     "description": "Whether we should alert on this suite (overrides default behaviour)",
                     "title": "Should alert",
                     "type": "boolean"
                 },
                 "alertThreshold": {
                     "description": "% change threshold before alerting",
                     "title": "Alert threshold",
-                    "type": "number"
+                    "type": "number",
+                    "minimum": 0.0,
+                    "maximum": 1000.0
                 },
                 "minBackWindow": {
                     "description": "Minimum back window to use for alerting",
                     "title": "Minimum back window",
-                    "type": "number"
+                    "type": "integer",
+                    "minimum": 1,
+                    "maximum": 255
                 },
                 "maxBackWindow": {
                     "description": "Maximum back window to use for alerting",
                     "title": "Maximum back window",
-                    "type": "number"
+                    "type": "integer",
+                    "minimum": 1,
+                    "maximum": 255
                 },
                 "foreWindow": {
                     "description": "Fore window to use for alerting",
                     "title": "Fore window",
-                    "type": "number"
+                    "type": "integer",
+                    "minimum": 1,
+                    "maximum": 255
                 }
             },
             "required": [
                 "name",
                 "subtests"
             ],
             "type": "object"
         }