Bug 1261703. When moving flex frame, position its view as well as any child views. r=dholbert
authorTimothy Nikkel <tnikkel@gmail.com>
Fri, 08 Apr 2016 01:13:56 -0500
changeset 316175 2d9d427348ed0c29174e7586002fed1f90133d2e
parent 316174 9b32d06e03c420dc30f43c8a13a65d4a9b765abb
child 316176 cb8a49f92cba589b168aeea3d7dbc076bf3509c6
push id9480
push userjlund@mozilla.com
push dateMon, 25 Apr 2016 17:12:58 +0000
treeherdermozilla-aurora@0d6a91c76a9e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1261703
milestone48.0a1
Bug 1261703. When moving flex frame, position its view as well as any child views. r=dholbert This is unlikely to change any behaviour, but is more correct.
layout/generic/nsFlexContainerFrame.cpp
--- a/layout/generic/nsFlexContainerFrame.cpp
+++ b/layout/generic/nsFlexContainerFrame.cpp
@@ -4128,16 +4128,17 @@ nsFlexContainerFrame::MoveFlexItemToFina
     MOZ_ASSERT(cachedOffsets,
                "relpos previously-reflowed frame should've cached its offsets");
     logicalOffsets = LogicalMargin(outerWM, *cachedOffsets);
   }
   nsHTMLReflowState::ApplyRelativePositioning(aItem.Frame(), outerWM,
                                               logicalOffsets, &aFramePos,
                                               aContainerSize);
   aItem.Frame()->SetPosition(outerWM, aFramePos, aContainerSize);
+  PositionFrameView(aItem.Frame());
   PositionChildViews(aItem.Frame());
 }
 
 void
 nsFlexContainerFrame::ReflowFlexItem(nsPresContext* aPresContext,
                                      const FlexboxAxisTracker& aAxisTracker,
                                      const nsHTMLReflowState& aReflowState,
                                      const FlexItem& aItem,