Bug 1120080 - Fix about:firefox updater hooks. r=mfinkle
authorRichard Newman <rnewman@mozilla.com>
Sat, 10 Jan 2015 12:44:58 -0800
changeset 239995 2c8cdce4fed4dadf98f1ef32ced6f6518a400478
parent 239994 35144551829c6ae3d8784885c0db2ba5554da614
child 239996 c4d908fa4442a6132527bd49bbc9bc1186c91ee7
push id7472
push userraliiev@mozilla.com
push dateMon, 12 Jan 2015 20:36:27 +0000
treeherdermozilla-aurora@300ca104f8fb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmfinkle
bugs1120080
milestone37.0a1
Bug 1120080 - Fix about:firefox updater hooks. r=mfinkle
mobile/android/chrome/content/about.js
mobile/android/chrome/content/about.xhtml
--- a/mobile/android/chrome/content/about.js
+++ b/mobile/android/chrome/content/about.js
@@ -93,16 +93,20 @@ function init() {
 
   let updateLink = document.getElementById("updateLink");
   let checkingSpan = document.getElementById("update-message-checking");
   let noneSpan = document.getElementById("update-message-none");
   let foundSpan = document.getElementById("update-message-found");
   let downloadingSpan = document.getElementById("update-message-downloading");
   let downloadedSpan = document.getElementById("update-message-downloaded");
 
+  updateLink.onclick = checkForUpdates;
+  foundSpan.onclick = downloadUpdate;
+  downloadedSpan.onclick = installUpdate;
+
   function showCheckAction() {
     checkingSpan.style.display = "none";
     noneSpan.style.display = "none";
     foundSpan.style.display = "none";
     downloadingSpan.style.display = "none";
     downloadedSpan.style.display = "none";
     updateLink.style.display = "block";
   }
--- a/mobile/android/chrome/content/about.xhtml
+++ b/mobile/android/chrome/content/about.xhtml
@@ -26,22 +26,22 @@
     <div id="wordmark"></div>
 #expand <p id="version">__MOZ_APP_VERSION__</p>
   </div>
 
   <div id="banner">
     <div id="logo"/>
 #ifdef MOZ_UPDATER
     <div id="updateBox">
-      <a id="updateLink" href="" onclick="checkForUpdates();">&aboutPage.checkForUpdates.link;</a>
+      <a id="updateLink" href="">&aboutPage.checkForUpdates.link;</a>
       <span id="update-message-checking">&aboutPage.checkForUpdates.checking;</span>
       <span id="update-message-none">&aboutPage.checkForUpdates.none;</span>
-      <span id="update-message-found" onclick="downloadUpdate()">&aboutPage.checkForUpdates.available2;</span>
+      <span id="update-message-found">&aboutPage.checkForUpdates.available2;</span>
       <span id="update-message-downloading">&aboutPage.checkForUpdates.downloading;</span>
-      <span id="update-message-downloaded" onclick="installUpdate()">&aboutPage.checkForUpdates.downloaded2;</span>
+      <span id="update-message-downloaded">&aboutPage.checkForUpdates.downloaded2;</span>
     </div>
 #endif
 
     <div id="messages">
       <p id="distributionAbout" hidden="true"/>
       <p id="distributionID" hidden="true"/>
       <p id="telemetry" hidden="true">
         &aboutPage.warningVersion;